Nulo/qmk_firmware
1
0
Fork 0
Code Releases Activity

[Keyboard] Remove i2c write command when reading columns on Ergodox EZ (#8092)

Browse source 
* Remove i2c write command when reading cols on Ergodox EZ

* Comment on mcp23018 address state during read_cols
This commit is contained in:
esinlayo 2020-02-07 18:52:02 -08:00 committed by GitHub
parent 3b1f29a5d6
commit 7182e9a8ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
keyboards/ergodox_ez/matrix.c
View file

@ -208,10 +208,8 @@ static matrix_row_t read_cols(uint8_t row) {
return 0; return 0;
} else { } else {
uint8_t data = 0; uint8_t data = 0;
mcp23018_status = i2c_start(I2C_ADDR_WRITE, ERGODOX_EZ_I2C_TIMEOUT); // reading GPIOB (column port) since in mcp23018's sequential mode
if (mcp23018_status) goto out; // it is addressed directly after writing to GPIOA in select_row()
mcp23018_status = i2c_write(GPIOB, ERGODOX_EZ_I2C_TIMEOUT);
if (mcp23018_status) goto out;
mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT); mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT);
if (mcp23018_status) goto out; if (mcp23018_status) goto out;
mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT); mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT);