Nulo/qmk_firmware
1
0
Fork 0
Code Releases Activity

fixed a bug related to mod + Grave with combined ESC/Grave key

Browse source 
This only applies to keymaps that has combined esc/grave. Here we call it theKEY.
Think about the motion when we do shift + theKEY (typing ~), or CMD + theKEY (switching window on MAC). Based on the original code, we must do following sequence:  press shift -> press theKEY -> release theKEY -> release shift. However, it is very possible and natural that we do this stroke sequence instead: press shift -> press theKEY -> release shift -> release theKEY.

If we do the 2nd stroke sequence, the code will del_key(ESC) instead of (GRV) when we release theKEY. This caused some inconvenient issues and ghost typing.

By adding a flag, this issue is eliminated and will not affect any other functions.
This commit is contained in:
tengg 2017-03-22 00:03:30 -04:00 committed by GitHub
parent c36a4496eb
commit 9e0ca927f9
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
keyboards/clueboard/keymaps/mac_optimized/keymap.c
View file

@ -50,6 +50,7 @@ const uint16_t PROGMEM fn_actions[] = {
void action_function(keyrecord_t *record, uint8_t id, uint8_t opt) { void action_function(keyrecord_t *record, uint8_t id, uint8_t opt) {
static uint8_t mods_pressed; static uint8_t mods_pressed;
static bool mods_flag;
switch (id) { switch (id) {
case 0: case 0:
@ -62,6 +63,7 @@ void action_function(keyrecord_t *record, uint8_t id, uint8_t opt) {
*/ */
if (mods_pressed) { if (mods_pressed) {
add_key(KC_GRV); add_key(KC_GRV);
mod_flag = true;
send_keyboard_report(); send_keyboard_report();
} else { } else {
add_key(KC_ESC); add_key(KC_ESC);
@ -70,8 +72,9 @@ void action_function(keyrecord_t *record, uint8_t id, uint8_t opt) {
} else { } else {
/* The key is being released. /* The key is being released.
*/ */
if (mods_pressed) { if (mod_flag) {
del_key(KC_GRV); del_key(KC_GRV);
mod_flag = false;
send_keyboard_report(); send_keyboard_report();
} else { } else {
del_key(KC_ESC); del_key(KC_ESC);