cursor: add option to warp on output change

On output change, if the cursor is not already on the newly focused
output, it will now be warped to its center. The check is necessary,
since focusing outputs with the pointer will be implemented in
the future.
This commit is contained in:
Leon Henrik Plickat 2021-05-07 03:46:26 +02:00 committed by Isaac Freund
parent 505639432e
commit 085cca0d5e
5 changed files with 48 additions and 2 deletions

View file

@ -228,7 +228,7 @@ A complete list may be found in _/usr/include/linux/input-event-codes.h_
There are three available modes: There are three available modes:
- _disabled_: Moving the cursor does not affect focus. This is - _disabled_: Moving the cursor does not affect focus. This is
the default the default.
- _normal_: Moving the cursor over a view will focus that view. - _normal_: Moving the cursor over a view will focus that view.
Moving the cursor within a view will not re-focus that view if Moving the cursor within a view will not re-focus that view if
focus has moved elsewhere. focus has moved elsewhere.
@ -238,6 +238,13 @@ A complete list may be found in _/usr/include/linux/input-event-codes.h_
If the view to be focused is on an output that does not have focus, If the view to be focused is on an output that does not have focus,
focus is switched to that output. focus is switched to that output.
*set-cursor-warp* *disabled*|*on-output-change*
Set the cursor warp mode. There are two available modes:
- _disabled_: Cursor will not be warped. This is the default.
- _on-output-change_: When a different output is focused, the cursor will be
warped to its center.
*opacity* _focused_ _unfocused_ _initial_ _step-size_ _delta-t_ *opacity* _focused_ _unfocused_ _initial_ _step-size_ _delta-t_
Configure server-side opacity of views, including transition Configure server-side opacity of views, including transition
animations. A value of 0.0 is fully transparent while 1.0 is fully animations. A value of 0.0 is fully transparent while 1.0 is fully

View file

@ -33,6 +33,11 @@ pub const FocusFollowsCursorMode = enum {
strict, strict,
}; };
pub const WarpCursorMode = enum {
disabled,
@"on-output-change",
};
/// Color of background in RGBA (alpha should only affect nested sessions) /// Color of background in RGBA (alpha should only affect nested sessions)
background_color: [4]f32 = [_]f32{ 0.0, 0.16862745, 0.21176471, 1.0 }, // Solarized base03 background_color: [4]f32 = [_]f32{ 0.0, 0.16862745, 0.21176471, 1.0 }, // Solarized base03
@ -60,6 +65,9 @@ csd_filter: std.ArrayList([]const u8),
/// The selected focus_follows_cursor mode /// The selected focus_follows_cursor mode
focus_follows_cursor: FocusFollowsCursorMode = .disabled, focus_follows_cursor: FocusFollowsCursorMode = .disabled,
/// If true, the cursor warps to the center of the focused output
warp_cursor: WarpCursorMode = .disabled,
/// The default layout namespace for outputs which have never had a per-output /// The default layout namespace for outputs which have never had a per-output
/// value set. Call Output.handleLayoutNamespaceChange() on setting this if /// value set. Call Output.handleLayoutNamespaceChange() on setting this if
/// Output.layout_namespace is null. /// Output.layout_namespace is null.

View file

@ -266,6 +266,23 @@ pub fn setFocusRaw(self: *Self, new_focus: FocusTarget) void {
pub fn focusOutput(self: *Self, output: *Output) void { pub fn focusOutput(self: *Self, output: *Output) void {
if (self.focused_output == output) return; if (self.focused_output == output) return;
// Warp pointer to center of newly focused output (In layout coordinates),
// but only if cursor is not already on the output and this feature is enabled.
switch (server.config.warp_cursor) {
.disabled => {},
.@"on-output-change" => {
const layout_box = server.root.output_layout.getBox(output.wlr_output).?;
if (!layout_box.containsPoint(self.cursor.wlr_cursor.x, self.cursor.wlr_cursor.y)) {
const eff_res = output.getEffectiveResolution();
const lx = @intToFloat(f32, layout_box.x + @intCast(i32, eff_res.width / 2));
const ly = @intToFloat(f32, layout_box.y + @intCast(i32, eff_res.height / 2));
if (!self.cursor.wlr_cursor.warp(null, lx, ly)) {
log.err("failed to warp cursor on output change", .{});
}
}
},
}
var it = self.status_trackers.first; var it = self.status_trackers.first;
while (it) |node| : (it = node.next) node.data.sendOutput(.unfocused); while (it) |node| : (it = node.next) node.data.sendOutput(.unfocused);

View file

@ -58,8 +58,8 @@ const str_to_impl_fn = [_]struct {
.{ .name = "focus-output", .impl = @import("command/output.zig").focusOutput }, .{ .name = "focus-output", .impl = @import("command/output.zig").focusOutput },
.{ .name = "focus-view", .impl = @import("command/focus_view.zig").focusView }, .{ .name = "focus-view", .impl = @import("command/focus_view.zig").focusView },
.{ .name = "input", .impl = @import("command/input.zig").input }, .{ .name = "input", .impl = @import("command/input.zig").input },
.{ .name = "list-inputs", .impl = @import("command/input.zig").listInputs },
.{ .name = "list-input-configs", .impl = @import("command/input.zig").listInputConfigs}, .{ .name = "list-input-configs", .impl = @import("command/input.zig").listInputConfigs},
.{ .name = "list-inputs", .impl = @import("command/input.zig").listInputs },
.{ .name = "map", .impl = @import("command/map.zig").map }, .{ .name = "map", .impl = @import("command/map.zig").map },
.{ .name = "map-pointer", .impl = @import("command/map.zig").mapPointer }, .{ .name = "map-pointer", .impl = @import("command/map.zig").mapPointer },
.{ .name = "mod-layout-value", .impl = @import("command/layout.zig").modLayoutValue }, .{ .name = "mod-layout-value", .impl = @import("command/layout.zig").modLayoutValue },
@ -68,6 +68,7 @@ const str_to_impl_fn = [_]struct {
.{ .name = "output-layout", .impl = @import("command/layout.zig").outputLayout }, .{ .name = "output-layout", .impl = @import("command/layout.zig").outputLayout },
.{ .name = "resize", .impl = @import("command/move.zig").resize }, .{ .name = "resize", .impl = @import("command/move.zig").resize },
.{ .name = "send-to-output", .impl = @import("command/output.zig").sendToOutput }, .{ .name = "send-to-output", .impl = @import("command/output.zig").sendToOutput },
.{ .name = "set-cursor-warp", .impl = @import("command/config.zig").setCursorWarp },
.{ .name = "set-focused-tags", .impl = @import("command/tags.zig").setFocusedTags }, .{ .name = "set-focused-tags", .impl = @import("command/tags.zig").setFocusedTags },
.{ .name = "set-layout-value", .impl = @import("command/layout.zig").setLayoutValue }, .{ .name = "set-layout-value", .impl = @import("command/layout.zig").setLayoutValue },
.{ .name = "set-repeat", .impl = @import("command/set_repeat.zig").setRepeat }, .{ .name = "set-repeat", .impl = @import("command/set_repeat.zig").setRepeat },

View file

@ -21,6 +21,7 @@ const server = &@import("../main.zig").server;
const Error = @import("../command.zig").Error; const Error = @import("../command.zig").Error;
const Seat = @import("../Seat.zig"); const Seat = @import("../Seat.zig");
const Config = @import("../Config.zig");
pub fn borderWidth( pub fn borderWidth(
allocator: *std.mem.Allocator, allocator: *std.mem.Allocator,
@ -81,6 +82,18 @@ pub fn borderColorUnfocused(
while (it) |node| : (it = node.next) node.data.damage.addWhole(); while (it) |node| : (it = node.next) node.data.damage.addWhole();
} }
pub fn setCursorWarp(
allocator: *std.mem.Allocator,
seat: *Seat,
args: []const []const u8,
out: *?[]const u8,
) Error!void {
if (args.len < 2) return Error.NotEnoughArguments;
if (args.len > 2) return Error.TooManyArguments;
server.config.warp_cursor = std.meta.stringToEnum(Config.WarpCursorMode, args[1]) orelse
return Error.UnknownOption;
}
/// Parse a color in the format #RRGGBB or #RRGGBBAA /// Parse a color in the format #RRGGBB or #RRGGBBAA
fn parseRgba(string: []const u8) ![4]f32 { fn parseRgba(string: []const u8) ![4]f32 {
if (string[0] != '#' or (string.len != 7 and string.len != 9)) return error.InvalidRgba; if (string[0] != '#' or (string.len != 7 and string.len != 9)) return error.InvalidRgba;