From 3c1f1df0c0faa561f5f993e05ba0c8ad3e56954f Mon Sep 17 00:00:00 2001 From: Isaac Freund Date: Sun, 28 Mar 2021 13:55:22 +0200 Subject: [PATCH] render: don't schedule new frame on output commit failure This reverts commit c457b12cf3c2040f37f9322095a20ad16a15b337. This attempted workaround seems to work fine if the output commit only fails with EBUSY, but enters an infinite loop otherwise. --- river/render.zig | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/river/render.zig b/river/render.zig index 204d760..1878c6b 100644 --- a/river/render.zig +++ b/river/render.zig @@ -142,10 +142,9 @@ pub fn renderOutput(output: *Output) void { output.wlr_output.setDamage(&damage); } - output.wlr_output.commit() catch { - log.err("output commit failed for {}, retrying", .{std.mem.spanZ(&output.wlr_output.name)}); - output.wlr_output.scheduleFrame(); - }; + // TODO: handle failure + output.wlr_output.commit() catch + log.err("output commit failed for {}", .{output.wlr_output.name}); } fn renderFilter(view: *View, filter_tags: u32) bool {