From e4a3698d86a4a32cc581b657ee9f1db57976ef9b Mon Sep 17 00:00:00 2001 From: Isaac Freund Date: Thu, 22 Oct 2020 19:24:01 +0200 Subject: [PATCH] view: update comments These should have been moved in the previous commit --- river/View.zig | 3 +++ river/XdgToplevel.zig | 3 --- river/XwaylandView.zig | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/river/View.zig b/river/View.zig index 7ba48f0..b96bc9d 100644 --- a/river/View.zig +++ b/river/View.zig @@ -242,6 +242,9 @@ pub fn saveBuffers(self: *Self) void { self.forEachSurface(saveBuffersIterator, &self.saved_buffers); } +/// If this commit is in response to our configure and the +/// transaction code is tracking this configure, notify it. +/// Otherwise, apply the pending state immediately. pub fn notifyConfiguredOrApplyPending(self: *Self) void { self.pending_serial = null; if (self.shouldTrackConfigure()) diff --git a/river/XdgToplevel.zig b/river/XdgToplevel.zig index 47fdd16..32e8079 100644 --- a/river/XdgToplevel.zig +++ b/river/XdgToplevel.zig @@ -257,9 +257,6 @@ fn handleCommit(listener: ?*c.wl_listener, data: ?*c_void) callconv(.C) void { view.surface_box = new_box; if (s == self.wlr_xdg_surface.configure_serial) { - // If this commit is in response to our configure and the - // transaction code is tracking this configure, notify it. - // Otherwise, apply the pending state immediately. view.notifyConfiguredOrApplyPending(); } else { // If the client has not yet acked our configure, we need to send a diff --git a/river/XwaylandView.zig b/river/XwaylandView.zig index 909cfe3..c64bd5e 100644 --- a/river/XwaylandView.zig +++ b/river/XwaylandView.zig @@ -215,8 +215,6 @@ fn handleCommit(listener: ?*c.wl_listener, data: ?*c_void) callconv(.C) void { // See comment in XwaylandView.configure() if (view.pending_serial != null) { - // If the view is part of the layout, notify the transaction code. If - // the view is floating or fullscreen apply the pending state immediately. view.notifyConfiguredOrApplyPending(); } }