Nulo/tar-stream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Removed logically dead code from parse256 (#109)

Browse source 
zero is always set to false -- why does the code have two conditionals that depend on it being true?

This dead code was in the original parse256 from node-tar as well... Perhaps it was being kept to keep the code as similar as possible?
This commit is contained in:
Adam Cohen-Rose 2020-01-08 12:20:50 +00:00 committed by Mathias Buus
parent 9f10b5fc26
commit b737a8d5d2
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
headers.js
View file

@ -112,16 +112,11 @@ function parse256 (buf) {
else return null else return null
// build up a base-256 tuple from the least sig to the highest // build up a base-256 tuple from the least sig to the highest
var zero = false
var tuple = [] var tuple = []
for (var i = buf.length - 1; i > 0; i--) { for (var i = buf.length - 1; i > 0; i--) {
var byte = buf[i] var byte = buf[i]
if (positive) tuple.push(byte) if (positive) tuple.push(byte)
else if (zero && byte === 0) tuple.push(0) else tuple.push(0xFF - byte)
else if (zero) {
zero = false
tuple.push(0x100 - byte)
} else tuple.push(0xFF - byte)
} }
var sum = 0 var sum = 0