opendkimd.sh

@@ -36,39 +36,24 @@ case $1 in
     dkey="$selc._domainkey.$SUTTY"
 
     # Do nothing if it already exists
-    if test ! -f "$pkey"; then
+    test -f "$pkey" && exit 0
+
     # Remove old keys later
     prev="`find $dir -name "*.private" -o -name "*.txt"`"
 
     ok "Generating new keys for selector ${selc}"
     opendkim-genkey --directory=$dir  --selector=$selc --subdomains --domain=$SUTTY
-      chown -R opendkim:opendkim /etc/opendkim
 
     # Discard previous keys
     echo "$dkey $SUTTY:$selc:$pkey" > $key
     echo "$SUTTY $dkey" > $sig
 
-      if test -n "$prev"; then
-        ok "Pruning old keypairs"
-        rm -f $prev
-      fi
-
-      if test -f $pid ; then
-        ok "Reloading"
-        cat $pid | xargs -r kill -USR1
-      fi
-    fi
-
     txt="`cat $tkey | tr -d "\n" | cut -d '"' -f 2,4 | tr -d '"' | tr -d " "`"
 
     # Register the TXT record on every nameserver. Log failures but
     # continue anyway.
     ok "Registering public key records"
     for node in `drill -Q ns $SUTTY`; do
-      if drill -Q @${node} txt ${dkey} | grep -q "${txt}" ; then
-        ok "Records already registered for selector ${selc}"
-        continue
-      fi
 
       # Craft record
       cat >/tmp/dns <<DNS
@@ -93,5 +78,15 @@ DNS
         not_ok "Couldn't query ${dkey} at ${node}!"
       fi
     done
+
+    if test -n "$prev"; then
+      ok "Pruning old keypairs"
+      rm -f $prev
+    fi
+
+    if test -f $pid ; then
+      ok "Reloading"
+      cat $pid | xargs -r kill -USR1
+    fi
     ;;
 esac