From 5a7331e00e44074bd9639d9023f707721665655b Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Thu, 7 Mar 2024 17:17:58 -0300
Subject: [PATCH] =?UTF-8?q?feat:=20cuando=20une=20actore=20es=20eliminade,?=
 =?UTF-8?q?=20hay=20que=20eliminar=20sus=20estados=20de=20moderaci=C3=B3n?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/models/activity_pub/activity/delete.rb        |  8 +++++++-
 app/models/activity_pub/object.rb                 |  7 ++++++-
 .../object/concerns/actor_type_concern.rb         |  7 +++++++
 app/models/actor_moderation.rb                    | 15 +++++++++++++--
 .../20240307201510_remove_actor_moderations.rb    | 13 +++++++++++++
 5 files changed, 46 insertions(+), 4 deletions(-)
 create mode 100644 db/migrate/20240307201510_remove_actor_moderations.rb

diff --git a/app/models/activity_pub/activity/delete.rb b/app/models/activity_pub/activity/delete.rb
index 5de20478..6a23a8b5 100644
--- a/app/models/activity_pub/activity/delete.rb
+++ b/app/models/activity_pub/activity/delete.rb
@@ -16,10 +16,16 @@ class ActivityPub
         ActivityPub.transaction do
           object = ActivityPub::Object.find_by(uri: ActivityPub.uri_from_object(content['object']))
 
-          if object
+          if object.present?
             object.activity_pubs.find_each do |activity_pub|
               activity_pub.remove! if activity_pub.may_remove?
             end
+
+            # Encontrar todas las acciones de moderación de le actore
+            # eliminade y moverlas a eliminar.
+            if object.actor_type? && object.actor.present?
+              ActorModeration.where(actor_id: object.actor.id).remove_all!
+            end
           end
 
           activity_pub.remove! if activity_pub.may_remove?
diff --git a/app/models/activity_pub/object.rb b/app/models/activity_pub/object.rb
index b33c1957..9061c4c5 100644
--- a/app/models/activity_pub/object.rb
+++ b/app/models/activity_pub/object.rb
@@ -14,7 +14,12 @@ class ActivityPub
     #
     # @return [ActivityPub::Actor,nil]
     def actor
-      ActivityPub::Actor.find_by(uri: content['actor'])
+      ActivityPub::Actor.find_by(uri: actor_uri)
+    end
+
+    # @return [String]
+    def actor_uri
+      content['attributedTo']
     end
 
     def actor_type?
diff --git a/app/models/activity_pub/object/concerns/actor_type_concern.rb b/app/models/activity_pub/object/concerns/actor_type_concern.rb
index bb840601..b2a643c7 100644
--- a/app/models/activity_pub/object/concerns/actor_type_concern.rb
+++ b/app/models/activity_pub/object/concerns/actor_type_concern.rb
@@ -7,6 +7,13 @@ class ActivityPub
         extend ActiveSupport::Concern
 
         included do
+          # La URI de le Actor en este caso es la misma id
+          #
+          # @return [String]
+          def actor_uri
+            uri
+          end
+
           # El objeto referencia a une Actor
           #
           # @see {https://www.w3.org/TR/activitystreams-vocabulary/#actor-types}
diff --git a/app/models/actor_moderation.rb b/app/models/actor_moderation.rb
index e06ffbb1..01613f72 100644
--- a/app/models/actor_moderation.rb
+++ b/app/models/actor_moderation.rb
@@ -5,8 +5,8 @@ class ActorModeration < ApplicationRecord
   include AASM
   include AasmEventsConcern
 
-  IGNORED_EVENTS = []
-  IGNORED_STATES = []
+  IGNORED_EVENTS = %i[remove]
+  IGNORED_STATES = %i[removed]
 
   belongs_to :site
   belongs_to :remote_flag, optional: true, class_name: 'ActivityPub::RemoteFlag'
@@ -23,11 +23,16 @@ class ActorModeration < ApplicationRecord
     self.update_all(aasm_state: 'paused', updated_at: Time.now)
   end
 
+  def self.remove_all!
+    self.update_all(aasm_state: 'removed', updated_at: Time.now)
+  end
+
   aasm do
     state :paused, initial: true
     state :allowed
     state :blocked
     state :reported
+    state :removed
 
     event :pause do
       transitions from: %i[allowed blocked reported], to: :paused
@@ -62,6 +67,12 @@ class ActorModeration < ApplicationRecord
         ActivityPub::RemoteFlagJob.perform_later(remote_flag: remote_flag) if remote_flag.waiting?
       end
     end
+
+    # Si un perfil es eliminado remotamente, tenemos que dejar de
+    # mostrarlo y todas sus actividades.
+    event :remove do
+      transitions to: :removed
+    end
   end
 
   def pause_remotely!
diff --git a/db/migrate/20240307201510_remove_actor_moderations.rb b/db/migrate/20240307201510_remove_actor_moderations.rb
new file mode 100644
index 00000000..92c6d23a
--- /dev/null
+++ b/db/migrate/20240307201510_remove_actor_moderations.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+# Mover todes les actores eliminades
+class RemoveActorModerations < ActiveRecord::Migration[6.1]
+  def up
+    actor_ids =
+      ActivityPub.where(aasm_state: 'removed', object_type: 'ActivityPub::Object::Person').distinct.pluck(:actor_id)
+
+    ActorModeration.where(id: actor_ids).remove_all!
+  end
+
+  def down; end
+end