From 434e1311f20633880b36ef41f2abaa79f433e0ef Mon Sep 17 00:00:00 2001 From: f Date: Thu, 4 Jul 2024 16:51:08 -0300 Subject: [PATCH 1/3] fix: htmx usa value para el evento #16714 --- app/javascript/controllers/form_validation_controller.js | 4 ++-- app/javascript/controllers/notification_controller.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/javascript/controllers/form_validation_controller.js b/app/javascript/controllers/form_validation_controller.js index dd1a98ed..b1c0a2f8 100644 --- a/app/javascript/controllers/form_validation_controller.js +++ b/app/javascript/controllers/form_validation_controller.js @@ -39,13 +39,13 @@ export default class extends Controller { if (!this.element.getAttributeNames().some(x => x.startsWith("hx-"))) this.element.submit(); - window.dispatchEvent(new CustomEvent("notification:show", { detail: { id: this.submittingIdValue } })); + window.dispatchEvent(new CustomEvent("notification:show", { detail: { value: this.submittingIdValue } })); } else { event?.stopPropagation(); this.element.classList.add("was-validated"); - window.dispatchEvent(new CustomEvent("notification:show", { detail: { id: this.invalidIdValue } })); + window.dispatchEvent(new CustomEvent("notification:show", { detail: { value: this.invalidIdValue } })); } this.submitting = false; diff --git a/app/javascript/controllers/notification_controller.js b/app/javascript/controllers/notification_controller.js index 7fbe3b5a..89ae085d 100644 --- a/app/javascript/controllers/notification_controller.js +++ b/app/javascript/controllers/notification_controller.js @@ -19,8 +19,8 @@ export default class extends Controller { * actual, se oculta. */ show(event = undefined) { - if (event?.detail?.id !== this.element.id) { - this.hide({ detail: { id: this.element.id } }); + if (event?.detail?.value !== this.element.id) { + this.hide({ detail: { value: this.element.id } }); return; } @@ -33,7 +33,7 @@ export default class extends Controller { } hide(event = undefined) { - if (event?.detail?.id !== this.element.id) return; + if (event?.detail?.value !== this.element.id) return; this.element.classList.remove(...this.showClasses); this.element.classList.add(...this.hideClasses); From 3efd3827a6fdb6f19e3cd5dd93ad3aff33ec21d0 Mon Sep 17 00:00:00 2001 From: f Date: Thu, 4 Jul 2024 16:51:40 -0300 Subject: [PATCH 2/3] =?UTF-8?q?fix:=20ser=20espec=C3=ADficxs=20con=20lo=20?= =?UTF-8?q?que=20va=20a=20pasar=20en=20el=20bot=C3=B3n=20#16712?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- config/locales/en.yml | 2 +- config/locales/es.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/locales/en.yml b/config/locales/en.yml index ce5a9e36..ee3a23e7 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -957,7 +957,7 @@ en: add: "Add %{layout}" add_new: "Add new option" cancel: "Cancel" - close: "Close" + close: "Close without saving" edit: "Edit" filter: "Start typing to filter..." save: "Save" diff --git a/config/locales/es.yml b/config/locales/es.yml index 416c3e1a..336dc503 100644 --- a/config/locales/es.yml +++ b/config/locales/es.yml @@ -967,7 +967,7 @@ es: add: "Agregar %{layout}" add_new: "Agregar nueva opción" cancel: "Cancelar" - close: "Cerrar" + close: "Cerrar sin guardar" edit: "Editar" filter: "Empezá a escribir para filtrar..." save: "Guardar" From d50cba9f39703c0e8ab4b8ee6a30866f08394c98 Mon Sep 17 00:00:00 2001 From: fauno Date: Thu, 4 Jul 2024 19:57:56 +0000 Subject: [PATCH 3/3] ci: assets [skip ci] --- .../.sprockets-manifest-a1cbb907961024fc033716a7d30668dd.json | 2 +- public/packs/js/application-8f69d0f11e0ca7be2504.js | 3 --- public/packs/js/application-8f69d0f11e0ca7be2504.js.br | 3 --- public/packs/js/application-8f69d0f11e0ca7be2504.js.gz | 3 --- public/packs/js/application-8f69d0f11e0ca7be2504.js.map | 3 --- public/packs/js/application-8f69d0f11e0ca7be2504.js.map.br | 3 --- public/packs/js/application-8f69d0f11e0ca7be2504.js.map.gz | 3 --- public/packs/js/application-b4baa487ab2bd8d1019a.js | 3 +++ ...NSE.txt => application-b4baa487ab2bd8d1019a.js.LICENSE.txt} | 0 public/packs/js/application-b4baa487ab2bd8d1019a.js.br | 3 +++ public/packs/js/application-b4baa487ab2bd8d1019a.js.gz | 3 +++ public/packs/js/application-b4baa487ab2bd8d1019a.js.map | 3 +++ public/packs/js/application-b4baa487ab2bd8d1019a.js.map.br | 3 +++ public/packs/js/application-b4baa487ab2bd8d1019a.js.map.gz | 3 +++ public/packs/manifest.json | 2 +- public/packs/manifest.json.br | 2 +- public/packs/manifest.json.gz | 2 +- 17 files changed, 22 insertions(+), 22 deletions(-) delete mode 100644 public/packs/js/application-8f69d0f11e0ca7be2504.js delete mode 100644 public/packs/js/application-8f69d0f11e0ca7be2504.js.br delete mode 100644 public/packs/js/application-8f69d0f11e0ca7be2504.js.gz delete mode 100644 public/packs/js/application-8f69d0f11e0ca7be2504.js.map delete mode 100644 public/packs/js/application-8f69d0f11e0ca7be2504.js.map.br delete mode 100644 public/packs/js/application-8f69d0f11e0ca7be2504.js.map.gz create mode 100644 public/packs/js/application-b4baa487ab2bd8d1019a.js rename public/packs/js/{application-8f69d0f11e0ca7be2504.js.LICENSE.txt => application-b4baa487ab2bd8d1019a.js.LICENSE.txt} (100%) create mode 100644 public/packs/js/application-b4baa487ab2bd8d1019a.js.br create mode 100644 public/packs/js/application-b4baa487ab2bd8d1019a.js.gz create mode 100644 public/packs/js/application-b4baa487ab2bd8d1019a.js.map create mode 100644 public/packs/js/application-b4baa487ab2bd8d1019a.js.map.br create mode 100644 public/packs/js/application-b4baa487ab2bd8d1019a.js.map.gz diff --git a/public/assets/.sprockets-manifest-a1cbb907961024fc033716a7d30668dd.json b/public/assets/.sprockets-manifest-a1cbb907961024fc033716a7d30668dd.json index 9b56abb9..6ac5a373 100644 --- a/public/assets/.sprockets-manifest-a1cbb907961024fc033716a7d30668dd.json +++ b/public/assets/.sprockets-manifest-a1cbb907961024fc033716a7d30668dd.json @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e0932b1a060d222c9cd5e311838663a15604c1eedb5b99463f71efc046325a7d +oid sha256:e468d2ddff834944bef81d2e5727c764cbd931293c7fe983d165c2ce831c0d49 size 11449 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js b/public/packs/js/application-8f69d0f11e0ca7be2504.js deleted file mode 100644 index 91367b53..00000000 --- a/public/packs/js/application-8f69d0f11e0ca7be2504.js +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:e6b235c4eb1139e1a4bdf9daaecd159f529b10f5514687573ba1ecc00bba1fb6 -size 1669121 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js.br b/public/packs/js/application-8f69d0f11e0ca7be2504.js.br deleted file mode 100644 index eff908dc..00000000 --- a/public/packs/js/application-8f69d0f11e0ca7be2504.js.br +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:767f755f8dda62aac2ded222ace1b32108d07a4583cb864e342bf5d35b3fef95 -size 368411 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js.gz b/public/packs/js/application-8f69d0f11e0ca7be2504.js.gz deleted file mode 100644 index 5d2fba2a..00000000 --- a/public/packs/js/application-8f69d0f11e0ca7be2504.js.gz +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:0f35c3299dd87f5309d3adf96570b80264f169d032c252b1f4da0d1296a98267 -size 485766 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js.map b/public/packs/js/application-8f69d0f11e0ca7be2504.js.map deleted file mode 100644 index 87e0cc84..00000000 --- a/public/packs/js/application-8f69d0f11e0ca7be2504.js.map +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:9732c120406374b709a194dbccff611bc43476c0d38621c45df981a31b220e7e -size 6438103 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js.map.br b/public/packs/js/application-8f69d0f11e0ca7be2504.js.map.br deleted file mode 100644 index d644a0dd..00000000 --- a/public/packs/js/application-8f69d0f11e0ca7be2504.js.map.br +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:10ce48f1afd5d1703f265109f5da46d241cc989699ada0a9113ca9de4746ca0b -size 1385749 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js.map.gz b/public/packs/js/application-8f69d0f11e0ca7be2504.js.map.gz deleted file mode 100644 index cdbd6562..00000000 --- a/public/packs/js/application-8f69d0f11e0ca7be2504.js.map.gz +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:51218081dca07043ac39ea4d95be8ff9d10cbb2e008de9316950e5b93b01cca8 -size 1714684 diff --git a/public/packs/js/application-b4baa487ab2bd8d1019a.js b/public/packs/js/application-b4baa487ab2bd8d1019a.js new file mode 100644 index 00000000..d23bcf7c --- /dev/null +++ b/public/packs/js/application-b4baa487ab2bd8d1019a.js @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:5570cf8d82b589e8dd4a77d7f20e74fbbcf7721d984acaaf9fa2b63c26a2def5 +size 1669136 diff --git a/public/packs/js/application-8f69d0f11e0ca7be2504.js.LICENSE.txt b/public/packs/js/application-b4baa487ab2bd8d1019a.js.LICENSE.txt similarity index 100% rename from public/packs/js/application-8f69d0f11e0ca7be2504.js.LICENSE.txt rename to public/packs/js/application-b4baa487ab2bd8d1019a.js.LICENSE.txt diff --git a/public/packs/js/application-b4baa487ab2bd8d1019a.js.br b/public/packs/js/application-b4baa487ab2bd8d1019a.js.br new file mode 100644 index 00000000..3416ea3f --- /dev/null +++ b/public/packs/js/application-b4baa487ab2bd8d1019a.js.br @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:a7fe6aaef8a5f46abf666a70308a564bbd873bd5637c6caf1908bb0b78eea32e +size 368588 diff --git a/public/packs/js/application-b4baa487ab2bd8d1019a.js.gz b/public/packs/js/application-b4baa487ab2bd8d1019a.js.gz new file mode 100644 index 00000000..5f810b02 --- /dev/null +++ b/public/packs/js/application-b4baa487ab2bd8d1019a.js.gz @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:69cc5ef71af5b657859e097b60a4a3fec58a0d5d6df411cdf8785c9bbeeb58ec +size 485768 diff --git a/public/packs/js/application-b4baa487ab2bd8d1019a.js.map b/public/packs/js/application-b4baa487ab2bd8d1019a.js.map new file mode 100644 index 00000000..f1a6d06f --- /dev/null +++ b/public/packs/js/application-b4baa487ab2bd8d1019a.js.map @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:931fd7332f4383a278c5d51784c983dd83ee6fc9153bffde7081cc9cabba9396 +size 6438113 diff --git a/public/packs/js/application-b4baa487ab2bd8d1019a.js.map.br b/public/packs/js/application-b4baa487ab2bd8d1019a.js.map.br new file mode 100644 index 00000000..a1fdf7f9 --- /dev/null +++ b/public/packs/js/application-b4baa487ab2bd8d1019a.js.map.br @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:e5c47cc4c56239e504c606f1a913c04450b3159fa9885d52f8b1068e3346569b +size 1386215 diff --git a/public/packs/js/application-b4baa487ab2bd8d1019a.js.map.gz b/public/packs/js/application-b4baa487ab2bd8d1019a.js.map.gz new file mode 100644 index 00000000..4a2eeeaf --- /dev/null +++ b/public/packs/js/application-b4baa487ab2bd8d1019a.js.map.gz @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:59c537e654bd9498c93d2552bdc25827cb91c1dacc42e0e9d92f7969a2d81db2 +size 1714692 diff --git a/public/packs/manifest.json b/public/packs/manifest.json index c2bc76a3..29ff8ea8 100644 --- a/public/packs/manifest.json +++ b/public/packs/manifest.json @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:414eb620095846df6f046f3f83cd9090c12589e3ebc9e4fcbceb482da98c84ff +oid sha256:9c286d8875d29377f49bddd9a02dcbf5ce276435a37d359f91c00c796215f2aa size 1426 diff --git a/public/packs/manifest.json.br b/public/packs/manifest.json.br index d7091ee2..7b07b0ca 100644 --- a/public/packs/manifest.json.br +++ b/public/packs/manifest.json.br @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:ea29a8d38a174a6b0932f2a932bf82a02f1fb84f9b6a1ecdcb84b3e9ee40d688 +oid sha256:cfd1a5608cedfc6bd75d4c582a8ac1597f4732a165dbc46d1fa05a0ff301aab5 size 320 diff --git a/public/packs/manifest.json.gz b/public/packs/manifest.json.gz index 79ffc690..a00ab9a8 100644 --- a/public/packs/manifest.json.gz +++ b/public/packs/manifest.json.gz @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:7e2259446551432aac80b002c692acc7583688ed82a3a2c081f3181c769acfb7 +oid sha256:dda7bd33835b05e7d478a0ec8c952eaf5b32d064f6c148d24ef8853aebaeacff size 365