From 9d09c3244f98ab1ab77bcf7aff4aa93957a1e18f Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Tue, 28 Mar 2023 16:21:29 -0300
Subject: [PATCH 1/3] =?UTF-8?q?feat:=20validar=20y=20agregar=20la=20direcc?=
 =?UTF-8?q?i=C3=B3n=20a=20la=20configuraci=C3=B3n=20del=20sitio?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/models/deploy_hidden_service.rb | 13 ++++++++++++-
 app/services/site_service.rb        |  7 ++-----
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/app/models/deploy_hidden_service.rb b/app/models/deploy_hidden_service.rb
index 6b84752f..ec6ed08c 100644
--- a/app/models/deploy_hidden_service.rb
+++ b/app/models/deploy_hidden_service.rb
@@ -6,6 +6,8 @@ class DeployHiddenService < DeployWww
 
   before_create :create_hidden_service!
 
+  ONION_RE = /\A[a-z0-9]{56}\.onion\z/.freeze
+
   def fqdn
     onion.tap do |onion|
       raise ArgumentError, 'Aun no se generó la dirección .onion' if onion.blank?
@@ -19,6 +21,15 @@ class DeployHiddenService < DeployWww
   private
 
   def create_hidden_service!
-    self.onion = HiddenServiceClient.new.create(site.name)
+    onion_address = HiddenServiceClient.new.create(site.name)
+
+    if onion_address =~ ONION_RE
+      self.onion = onion_address
+
+      usuarie = GitAuthor.new email: "tor@#{Site.domain}", name: 'Tor'
+      params = { onion: onion_address, deploy: self }
+
+      SiteService.new(site: site, usuarie: usuarie, params: params).add_onion
+    end
   end
 end
diff --git a/app/services/site_service.rb b/app/services/site_service.rb
index 0ecccba4..378bcec0 100644
--- a/app/services/site_service.rb
+++ b/app/services/site_service.rb
@@ -62,14 +62,11 @@ SiteService = Struct.new(:site, :usuarie, :params, keyword_init: true) do
   # Agregar una dirección oculta de Tor al DeployHiddenService y a la
   # configuración del Site.
   def add_onion
-    onion  = params[:onion].strip
-    deploy = DeployHiddenService.find_by(site: site)
+    onion  = params[:onion]
+    deploy = params[:deploy]
 
     return false unless !onion.blank? && deploy
 
-    deploy.values[:onion] = onion
-    deploy.save
-
     site.config['onion-location'] = onion
     site.config.write
 

From 9d1505d2631024875ca7a9d732b065798a6d6a99 Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Tue, 28 Mar 2023 16:22:02 -0300
Subject: [PATCH 2/3] BREAKING CHANGE: deprecar la api de onion

---
 app/controllers/api/v1/sites_controller.rb | 25 ----------------------
 config/routes.rb                           |  2 --
 2 files changed, 27 deletions(-)

diff --git a/app/controllers/api/v1/sites_controller.rb b/app/controllers/api/v1/sites_controller.rb
index 10a92907..ae64cf74 100644
--- a/app/controllers/api/v1/sites_controller.rb
+++ b/app/controllers/api/v1/sites_controller.rb
@@ -12,31 +12,6 @@ module Api
         render json: sites_names + alternative_names + api_names + www_names
       end
 
-      # Sitios con hidden service de Tor
-      #
-      # @return [Array] lista de nombres de sitios sin onion aun
-      def hidden_services
-        render json: DeployHiddenService.where(values: nil).includes(:site).pluck(:name)
-      end
-
-      # Tor va a enviar el onion junto con el nombre del sitio y tenemos
-      # que guardarlo en su deploy_hidden_service.
-      #
-      # @params [String] name
-      # @params [String] onion
-      def add_onion
-        site = Site.find_by(name: params[:name])
-
-        if site
-          usuarie = GitAuthor.new email: "tor@#{Site.domain}", name: 'Tor'
-          service = SiteService.new site: site, usuarie: usuarie,
-                                    params: params
-          service.add_onion
-        end
-
-        head :ok
-      end
-
       private
 
       def canonicalize(name)
diff --git a/config/routes.rb b/config/routes.rb
index a132135a..511ca654 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -11,8 +11,6 @@ Rails.application.routes.draw do
       namespace :v1 do
         resources :csp_reports, only: %i[create]
 
-        get :'sites/hidden_services', to: 'sites#hidden_services'
-        post :'sites/add_onion', to: 'sites#add_onion'
         resources :sites, only: %i[index], constraints: { site_id: /[a-z0-9\-.]+/, id: /[a-z0-9\-.]+/ } do
           get  :'invitades/cookie', to: 'invitades#cookie'
           post :'posts/:layout', to: 'posts#create', as: :posts

From 76c97372b9f5cc419f8a92b375bb29fcb23a110f Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Tue, 28 Mar 2023 16:22:58 -0300
Subject: [PATCH 3/3] =?UTF-8?q?fix:=20reintentar=20si=20fall=C3=B3=20la=20?=
 =?UTF-8?q?generaci=C3=B3n=20en=20el=20pasado?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/models/deploy_hidden_service.rb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/models/deploy_hidden_service.rb b/app/models/deploy_hidden_service.rb
index ec6ed08c..6e065102 100644
--- a/app/models/deploy_hidden_service.rb
+++ b/app/models/deploy_hidden_service.rb
@@ -9,6 +9,8 @@ class DeployHiddenService < DeployWww
   ONION_RE = /\A[a-z0-9]{56}\.onion\z/.freeze
 
   def fqdn
+    create_hidden_service! if onion.blank?
+
     onion.tap do |onion|
       raise ArgumentError, 'Aun no se generó la dirección .onion' if onion.blank?
     end