wip: pruebas de #1142

app/models/post.rb

@@ -23,7 +23,11 @@ class Post
     # TODO: Reemplazar cuando leamos el contenido del Document
     # a demanda?
     def find_layout(path)
-      IO.foreach(path).lazy.grep(/^layout: /).take(1).first&.split(' ')&.last&.tr('\'', '')&.tr('"', '')&.to_sym
+      IO.foreach(path).lazy.grep(/^layout: /).take(1).first&.split(' ')&.last&.tr('\'', '')&.tr('"', '')&.to_sym || :post
+    rescue Errno::ENOENT => e
+      ExceptionNotifier.notify(e)
+
+      :post
     end
   end
 
@@ -106,7 +110,7 @@ class Post
 
   # Devuelve una llave para poder guardar el post en una cache
   def cache_key
-    'posts/' + uuid.value
+    "posts/#{uuid.value}"
   end
 
   def cache_version
@@ -116,7 +120,7 @@ class Post
   # Agregar el timestamp para saber si cambió, siguiendo el módulo
   # ActiveRecord::Integration
   def cache_key_with_version
-    cache_key + '-' + cache_version
+    "#{cache_key}-#{cache_version}"
   end
 
   # TODO: Convertir a UUID?

app/views/posts/index.haml

@@ -83,46 +83,53 @@
 
                 TODO: Verificar qué pasa cuando se gestiona el sitio en
                 distintos idiomas a la vez
-              - cache_if @usuarie, post do
-                - checkbox_id = "checkbox-#{post.uuid.value}"
-                %tr{ id: post.uuid.value, data: { target: 'reorder.row' } }
-                  %td
-                    .custom-control.custom-checkbox
-                      %input.custom-control-input{ id: checkbox_id, type: 'checkbox', autocomplete: 'off', data: { action: 'reorder#select' } }
-                      %label.custom-control-label{ for: checkbox_id }
-                        %span.sr-only= t('posts.reorder.select')
-                    -# Orden más alto es mayor prioridad
-                    = hidden_field 'post[reorder]', post.uuid.value,
-                      value: @posts.length - i,
-                      data: { reorder: true }
-                  %td.w-100{ class: dir }
-                    = link_to site_post_path(@site, post.id) do
-                      %span{ lang: post.lang.value, dir: dir }= post.title.value
-                    - if post.attributes.include? :draft
-                      - if post.draft.value
-                        %span.badge.badge-primary
-                          = post_label_t(:draft, post: post)
-                    - if post.attributes.include? :categories
-                      - unless post.categories.value.empty?
-                        %br
-                        %small
-                          - (post.categories.respond_to?(:belongs_to) ? post.categories.belongs_to : post.categories.value).each do |c|
-                            = link_to site_posts_path(@site, category: (c.respond_to?(:uuid) ? c.uuid.value : c)) do
-                              %span{ lang: post.lang.value, dir: dir }= (c.respond_to?(:title) ? c.title.value : c)
+              - begin
+                - cache_if @usuarie, post do
+                  - checkbox_id = "checkbox-#{post.uuid.value}"
+                  %tr{ id: post.uuid.value, data: { target: 'reorder.row' } }
+                    %td
+                      .custom-control.custom-checkbox
+                        %input.custom-control-input{ id: checkbox_id, type: 'checkbox', autocomplete: 'off', data: { action: 'reorder#select' } }
+                        %label.custom-control-label{ for: checkbox_id }
+                          %span.sr-only= t('posts.reorder.select')
+                      -# Orden más alto es mayor prioridad
+                      = hidden_field 'post[reorder]', post.uuid.value,
+                        value: @posts.length - i,
+                        data: { reorder: true }
+                    %td.w-100{ class: dir }
+                      = link_to site_post_path(@site, post.id) do
+                        %span{ lang: post.lang.value, dir: dir }= post.title.value
+                      - if post.attributes.include? :draft
+                        - if post.draft.value
+                          %span.badge.badge-primary
+                            = post_label_t(:draft, post: post)
+                      - if post.attributes.include? :categories
+                        - unless post.categories.value.empty?
+                          %br
+                          %small
+                            - (post.categories.respond_to?(:belongs_to) ? post.categories.belongs_to : post.categories.value).each do |c|
+                              = link_to site_posts_path(@site, category: (c.respond_to?(:uuid) ? c.uuid.value : c)) do
+                                %span{ lang: post.lang.value, dir: dir }= (c.respond_to?(:title) ? c.title.value : c)
 
-                  %td
-                    = post.date.value.strftime('%F')
-                    %br/
-                    - if post.attribute? :order
-                      = post.order.value
-                  %td
-                    - if @usuarie || policy(post).edit?
-                      = link_to t('posts.edit'),
-                      edit_site_post_path(@site, post.id),
-                      class: 'btn btn-block'
-                    - if @usuarie || policy(post).destroy?
-                      = link_to t('posts.destroy'),
-                        site_post_path(@site, post.id),
-                        class: 'btn btn-block',
-                        method: :delete,
-                        data: { confirm: t('posts.confirm_destroy') }
+                    %td
+                      = post.date.value.strftime('%F')
+                      %br/
+                      - if post.attribute? :order
+                        = post.order.value
+                    %td
+                      - if @usuarie || policy(post).edit?
+                        = link_to t('posts.edit'),
+                        edit_site_post_path(@site, post.id),
+                        class: 'btn btn-block'
+                      - if @usuarie || policy(post).destroy?
+                        = link_to t('posts.destroy'),
+                          site_post_path(@site, post.id),
+                          class: 'btn btn-block',
+                          method: :delete,
+                          data: { confirm: t('posts.confirm_destroy') }
+              -# 
+                Rescatar cualquier error en un post, notificarlo e
+                ignorar su renderización.
+              - rescue ActionView::Template::Error => e
+                - binding.pry
+                - ExceptionNotifier.notify_exception(e.cause, data: { site: @site.name, post: @post.path.absolute, usuarie: current_usuarie.id })

config/environments/test.rb

@@ -50,6 +50,15 @@ Rails.application.configure do
   config.action_mailer.default_url_options = { host: 'localhost',
                                                port: 3000 }
 
+  config.middleware.use ExceptionNotification::Rack,
+                        error_grouping: true,
+                        email: {
+                          email_prefix: '',
+                          sender_address: ENV['DEFAULT_FROM'],
+                          exception_recipients: ENV['EXCEPTION_TO'],
+                          normalize_subject: true
+                        }
+
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 

test/controllers/posts_controller_test.rb

@@ -150,7 +150,7 @@ class PostsControllerTest < ActionDispatch::IntegrationTest
     end
 
     posts = @site.posts(**lang)
-    reorder = Hash[posts.map { |p| p.uuid.value }.shuffle.each_with_index.to_a]
+    reorder = posts.map { |p| p.uuid.value }.shuffle.each_with_index.to_a.to_h
 
     post site_posts_reorder_url(@site),
          headers: @authorization,
@@ -159,10 +159,18 @@ class PostsControllerTest < ActionDispatch::IntegrationTest
     @site = Site.find @site.id
 
     assert_equal reorder,
-                 Hash[@site.posts(**lang).map do |p|
+                 @site.posts(**lang).map do |p|
                    [p.uuid.value, p.order.value]
-                 end]
+                 end.to_h
     assert_equal I18n.t('post_service.reorder'),
                  @site.repository.rugged.head.target.message
   end
+
+  test 'si hay algún error se recupera' do
+    File.open(File.join(@site.path, '_es', "#{Date.today}-#{SecureRandom.hex}.markdown"), 'w') do |f|
+      f.write ''
+    end
+
+    get site_posts_url(@site), headers: @authorization
+  end
 end