From b8e7e53ebd651332cae10f0c23dfb8239a3d1089 Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Mon, 4 Mar 2024 13:09:36 -0300
Subject: [PATCH] feat: limpieza de texto

---
 app/helpers/application_helper.rb | 22 ++++++++++++++++++----
 app/models/metadata_template.rb   | 14 ++------------
 app/views/posts/show.haml         |  1 -
 config/application.rb             |  5 +++++
 4 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 9f7be213..146846f0 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -33,10 +33,24 @@ module ApplicationHelper
     end
   end
 
-  # Devuelve todas las etiquetas HTML que queremos mantener
-  def all_html_tags
-    %w[h1 h2 h3 h4 h5 h6 p a ul ol li table tr td th tbody thead
-       tfoot em strong sup blockquote cite pre section article]
+  # Sanitizador que elimina todo
+  #
+  # @param html [String]
+  # @return [String]
+  def text_plain(html)
+    sanitize(html, tags: [], attributes: [])
+  end
+
+  # Sanitizador con etiquetas y atributos por defecto
+  #
+  # @param html [String]
+  # @param options [Hash]
+  # @return [String]
+  def sanitize(html, options = {})
+    options[:tags] ||= Sutty::ALLOWED_TAGS
+    options[:attributes] ||= Sutty::ALLOWED_ATTRIBUTES
+
+    super(html, options)
   end
 
   # Genera HTML y limpia etiquetas innecesarias
diff --git a/app/models/metadata_template.rb b/app/models/metadata_template.rb
index 823443d2..a9765918 100644
--- a/app/models/metadata_template.rb
+++ b/app/models/metadata_template.rb
@@ -190,8 +190,8 @@ MetadataTemplate = Struct.new(:site, :document, :name, :label, :type,
 
     sanitizer
       .sanitize(string.tr("\r", '').unicode_normalize,
-                tags: allowed_tags,
-                attributes: allowed_attributes)
+                tags: Sutty::ALLOWED_TAGS,
+                attributes: Sutty::ALLOWED_ATTRIBUTES)
       .strip
       .html_safe
   end
@@ -200,16 +200,6 @@ MetadataTemplate = Struct.new(:site, :document, :name, :label, :type,
     @sanitizer ||= Rails::Html::Sanitizer.safe_list_sanitizer.new
   end
 
-  def allowed_attributes
-    @allowed_attributes ||= %w[style href src alt controls data-align data-multimedia data-multimedia-inner id
-                               name rel target referrerpolicy class colspan rowspan role data-turbo start type reversed].freeze
-  end
-
-  def allowed_tags
-    @allowed_tags ||= %w[strong em del u mark p h1 h2 h3 h4 h5 h6 ul ol li img iframe audio video div figure blockquote
-                         figcaption a sub sup small table thead tbody tfoot tr th td br code].freeze
-  end
-
   # Decifra el valor
   #
   # XXX: Otros tipos de valores necesitan implementar su propio método
diff --git a/app/views/posts/show.haml b/app/views/posts/show.haml
index ec191d87..10fe64e3 100644
--- a/app/views/posts/show.haml
+++ b/app/views/posts/show.haml
@@ -20,7 +20,6 @@
                        post: @post, attribute: attr,
                        metadata: metadata,
                        site: @site,
-                       tags: all_html_tags,
                        locale: @locale,
                        dir: dir)
 
diff --git a/config/application.rb b/config/application.rb
index 27a21cc6..ed7e5a78 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -37,6 +37,11 @@ if %w[development test].include? ENV['RAILS_ENV']
 end
 
 module Sutty
+  ALLOWED_ATTRIBUTES = %w[style href src alt controls data-align data-multimedia data-multimedia-inner id name rel
+                          target referrerpolicy class colspan rowspan role data-turbo start type reversed].freeze
+  ALLOWED_TAGS = %w[strong em del u mark p h1 h2 h3 h4 h5 h6 ul ol li img iframe audio video div figure blockquote
+                    figcaption a sub sup small table thead tbody tfoot tr th td br code].freeze
+
   # Sutty!
   class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails