From d25937f536ef072f2a9323b03e1bbaa4809fcd40 Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Mon, 20 Mar 2023 15:33:28 -0300
Subject: [PATCH 1/4] fix: no producir type error

---
 app/jobs/gitlab_notifier_job.rb | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/app/jobs/gitlab_notifier_job.rb b/app/jobs/gitlab_notifier_job.rb
index fb25be10..2f39caf9 100644
--- a/app/jobs/gitlab_notifier_job.rb
+++ b/app/jobs/gitlab_notifier_job.rb
@@ -16,7 +16,7 @@ class GitlabNotifierJob < ApplicationJob
   # @param [Hash] opciones de ExceptionNotifier
   def perform(exception, **options)
     @exception = exception
-    @options = options
+    @options = fix_options options
     @issue_data = { count: 1 }
     # Necesitamos saber si el issue ya existía
     @cached = false
@@ -88,10 +88,9 @@ class GitlabNotifierJob < ApplicationJob
     ].join('/')
   end
 
+  # @return [Array]
   def errors
-    return '' unless javascript?
-
-    options.dig(:data, :params, 'errors')
+    options.dig(:data, :params, 'errors') || []
   end
 
   # Define si es una excepción de javascript o local
@@ -288,4 +287,15 @@ class GitlabNotifierJob < ApplicationJob
   def url
     @url ||= request&.url || options.dig(:data, :params, 'context', 'url')
   end
+
+  # Define llaves necesarias
+  #
+  # @param :options [Hash]
+  # @return [Hash]
+  def fix_options(options)
+    options[:data] ||= {}
+    options[:data][:params] ||= {}
+
+    options
+  end
 end

From 706ff80b1864b791197741ff5afbd98ab808baae Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Tue, 21 Mar 2023 14:05:11 -0300
Subject: [PATCH 2/4] =?UTF-8?q?fix:=20algo=20est=C3=A1=20enviando=20las=20?=
 =?UTF-8?q?opciones=20como=20array?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/jobs/gitlab_notifier_job.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/jobs/gitlab_notifier_job.rb b/app/jobs/gitlab_notifier_job.rb
index 2f39caf9..4d57c744 100644
--- a/app/jobs/gitlab_notifier_job.rb
+++ b/app/jobs/gitlab_notifier_job.rb
@@ -293,6 +293,7 @@ class GitlabNotifierJob < ApplicationJob
   # @param :options [Hash]
   # @return [Hash]
   def fix_options(options)
+    options = { data: options } if options.is_a? Array
     options[:data] ||= {}
     options[:data][:params] ||= {}
 

From 1230dc2e96eb2bc117f1f92433e0d97748d4f2bf Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Wed, 22 Mar 2023 09:58:00 -0300
Subject: [PATCH 3/4] fix: solo permitimos un hash de opciones

---
 app/jobs/gitlab_notifier_job.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/jobs/gitlab_notifier_job.rb b/app/jobs/gitlab_notifier_job.rb
index 4d57c744..7b369fab 100644
--- a/app/jobs/gitlab_notifier_job.rb
+++ b/app/jobs/gitlab_notifier_job.rb
@@ -293,7 +293,7 @@ class GitlabNotifierJob < ApplicationJob
   # @param :options [Hash]
   # @return [Hash]
   def fix_options(options)
-    options = { data: options } if options.is_a? Array
+    options = { data: options } unless options.is_a? Hash
     options[:data] ||= {}
     options[:data][:params] ||= {}
 

From bbb951594b8594d6d71943b77c077573d813b8e1 Mon Sep 17 00:00:00 2001
From: f <f@sutty.nl>
Date: Wed, 22 Mar 2023 09:59:36 -0300
Subject: [PATCH 4/4] fix: enviar las opciones post limpieza

---
 app/jobs/gitlab_notifier_job.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/jobs/gitlab_notifier_job.rb b/app/jobs/gitlab_notifier_job.rb
index 7b369fab..575d57d8 100644
--- a/app/jobs/gitlab_notifier_job.rb
+++ b/app/jobs/gitlab_notifier_job.rb
@@ -63,7 +63,7 @@ class GitlabNotifierJob < ApplicationJob
   # la notificamos por correo
   rescue StandardError => e
     email_notification.call(e, data: @issue)
-    email_notification.call(exception, data: options)
+    email_notification.call(exception, data: @options)
   end
 
   private