2019-01-04 14:26:43 +00:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2019-02-13 09:09:20 +00:00
|
|
|
RSpec.describe 'Ticket Update', type: :system do
|
2019-01-04 14:26:43 +00:00
|
|
|
|
|
|
|
let(:group) { Group.find_by(name: 'Users') }
|
|
|
|
|
|
|
|
# Regression test for issue #2242 - mandatory fields can be empty (or "-") on ticket update
|
|
|
|
context 'when updating a ticket without its required select attributes' do
|
|
|
|
scenario 'frontend checks reject the update', db_strategy: :reset do
|
|
|
|
# setup and migrate a required select attribute
|
|
|
|
attribute = create_attribute :object_manager_attribute_select,
|
2019-02-27 13:02:16 +00:00
|
|
|
screens: attributes_for(:required_screen),
|
|
|
|
data_option: {
|
|
|
|
options: {
|
|
|
|
'name 1': 'name 1',
|
|
|
|
'name 2': 'name 2',
|
|
|
|
},
|
|
|
|
default: '',
|
|
|
|
null: false,
|
|
|
|
relation: '',
|
|
|
|
maxlength: 255,
|
|
|
|
nulloption: true,
|
|
|
|
}
|
2019-01-04 14:26:43 +00:00
|
|
|
|
|
|
|
# create a new ticket and attempt to update its state without the required select attribute
|
|
|
|
ticket = create :ticket, group: group
|
|
|
|
visit "#ticket/zoom/#{ticket.id}"
|
2019-02-27 13:02:16 +00:00
|
|
|
within(:active_content) do
|
|
|
|
expect(page).to have_css('.js-objectNumber', wait: 2)
|
|
|
|
|
|
|
|
select 'closed', from: 'state_id'
|
|
|
|
click('.js-attributeBar .js-submit')
|
|
|
|
expect(page).to have_no_css('.js-submitDropdown .js-submit[disabled]', wait: 2)
|
|
|
|
end
|
2019-01-04 14:26:43 +00:00
|
|
|
|
|
|
|
# the update should have failed and thus the ticket is still in the new state
|
|
|
|
expect(ticket.reload.state.name).to eq('new')
|
2019-02-27 13:02:16 +00:00
|
|
|
|
|
|
|
within(:active_content) do
|
|
|
|
# update should work now
|
|
|
|
find('.edit [name=internal_name1]').select('name 2')
|
|
|
|
click('.js-attributeBar .js-submit')
|
|
|
|
expect(page).to have_no_css('.js-submitDropdown .js-submit[disabled]', wait: 2)
|
|
|
|
end
|
|
|
|
|
|
|
|
ticket.reload
|
|
|
|
expect(ticket[attribute.name]).to eq('name 2')
|
|
|
|
expect(ticket.state.name).to eq('closed')
|
|
|
|
end
|
|
|
|
|
|
|
|
scenario 'with macro and required tree_select field', db_strategy: :reset do
|
|
|
|
# setup and migrate a required select attribute
|
|
|
|
attribute = create_attribute :object_manager_attribute_tree_select,
|
|
|
|
screens: attributes_for(:required_screen),
|
|
|
|
data_option: {
|
|
|
|
options: [
|
|
|
|
{
|
|
|
|
name: 'name 1',
|
|
|
|
value: 'name 1',
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'name 2',
|
|
|
|
value: 'name 2',
|
|
|
|
},
|
|
|
|
],
|
|
|
|
default: '',
|
|
|
|
null: false,
|
|
|
|
relation: '',
|
|
|
|
maxlength: 255,
|
|
|
|
nulloption: true,
|
|
|
|
}
|
|
|
|
|
|
|
|
attribute_value = 'name 2'
|
|
|
|
state = Ticket::State.by_category(:closed).first
|
|
|
|
macro = create(:macro,
|
|
|
|
perform: {
|
|
|
|
'ticket.state_id' => {
|
|
|
|
value: state.id,
|
|
|
|
},
|
|
|
|
"ticket.#{attribute.name}" => {
|
|
|
|
value: attribute_value,
|
|
|
|
},
|
|
|
|
})
|
|
|
|
|
|
|
|
# refresh browser to get macro accessable
|
|
|
|
page.driver.browser.navigate.refresh
|
|
|
|
|
|
|
|
# create a new ticket and attempt to update its state without the required select attribute
|
|
|
|
ticket = create(:ticket, group: group)
|
|
|
|
visit "#ticket/zoom/#{ticket.id}"
|
|
|
|
|
|
|
|
within(:active_content) do
|
|
|
|
expect(page).to have_css('.js-objectNumber', wait: 2)
|
|
|
|
|
|
|
|
click('.js-openDropdownMacro')
|
|
|
|
click(".js-dropdownActionMacro[data-id=\"#{macro.id}\"]")
|
|
|
|
expect(page).not_to have_css('.js-submitDropdown .js-submit[disabled]', wait: 2)
|
|
|
|
end
|
|
|
|
|
|
|
|
# the update should not have failed and thus the ticket is in closed state
|
|
|
|
ticket.reload
|
|
|
|
expect(ticket[attribute.name]).to eq(attribute_value)
|
|
|
|
expect(ticket.state.name).to eq(state.name)
|
2019-01-04 14:26:43 +00:00
|
|
|
end
|
|
|
|
end
|
2019-02-13 09:09:20 +00:00
|
|
|
|
|
|
|
# Issue #2469 - Add information "Ticket merged" to History
|
|
|
|
context 'when merging tickets' do
|
|
|
|
scenario 'tickets history of both tickets should show the merge event' do
|
|
|
|
user = create :user
|
|
|
|
origin_ticket = create :ticket, group: group
|
|
|
|
target_ticket = create :ticket, group: group
|
|
|
|
origin_ticket.merge_to(ticket_id: target_ticket.id, user_id: user.id)
|
|
|
|
|
|
|
|
visit "#ticket/zoom/#{origin_ticket.id}"
|
2019-02-27 13:02:16 +00:00
|
|
|
within(:active_content) do
|
|
|
|
expect(page).to have_css('.js-actions .dropdown-toggle', wait: 3)
|
|
|
|
click '.js-actions .dropdown-toggle'
|
|
|
|
click '.js-actions .dropdown-menu [data-type="ticket-history"]'
|
2019-02-13 09:09:20 +00:00
|
|
|
|
2019-02-27 13:02:16 +00:00
|
|
|
expect(page).to have_css('.modal', wait: 3)
|
|
|
|
modal = find('.modal')
|
|
|
|
expect(modal).to have_content "This ticket was merged into ticket ##{target_ticket.number}"
|
|
|
|
expect(modal).to have_link "##{target_ticket.number}", href: "#ticket/zoom/#{target_ticket.id}"
|
2019-02-13 09:09:20 +00:00
|
|
|
|
2019-02-27 13:02:16 +00:00
|
|
|
visit "#ticket/zoom/#{target_ticket.id}"
|
|
|
|
expect(page).to have_css('.js-actions .dropdown-toggle', wait: 3)
|
|
|
|
click '.js-actions .dropdown-toggle'
|
|
|
|
click '.js-actions .dropdown-menu [data-type="ticket-history"]'
|
2019-02-13 09:09:20 +00:00
|
|
|
|
2019-02-27 13:02:16 +00:00
|
|
|
expect(page).to have_css('.modal', wait: 3)
|
|
|
|
modal = find('.modal')
|
|
|
|
expect(modal).to have_content("Ticket ##{origin_ticket.number} was merged into this ticket")
|
|
|
|
expect(modal).to have_link "##{origin_ticket.number}", href: "#ticket/zoom/#{origin_ticket.id}"
|
|
|
|
end
|
2019-02-13 09:09:20 +00:00
|
|
|
end
|
|
|
|
end
|
2019-01-04 14:26:43 +00:00
|
|
|
end
|