Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
trabajo-afectivo/.rubocop_todo.rspec.yml

183 lines
6.4 KiB
YAML
Raw Normal View History

👮 Crack down on style violations with rubocop-rspec 🚓
2019-04-10 17:42:44 +00:00
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2019-04-12 17:16:30 +0800 using RuboCop version 0.67.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
# # Offense count: 17 (Competes with same override in .rubocop_todo.yml)
# Metrics/AbcSize:
# Max: 24
# Offense count: 664
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Fix auto-correctable rubocop offenses in test suite
2019-04-15 01:41:17 +00:00
Max: 1987
👮 Crack down on style violations with rubocop-rspec 🚓
2019-04-10 17:42:44 +00:00
# Offense count: 16
RSpec/AnyInstance:
Exclude:
- 'spec/lib/import/otrs/article_spec.rb'
- 'spec/lib/import/otrs/customer_spec.rb'
- 'spec/lib/import/otrs/customer_user_spec.rb'
- 'spec/lib/import/otrs/priority_spec.rb'
- 'spec/lib/import/otrs/queue_spec.rb'
- 'spec/lib/import/otrs/state_spec.rb'
- 'spec/lib/import/otrs/ticket_spec.rb'
- 'spec/lib/import/otrs/user_spec.rb'
- 'spec/models/import_job_spec.rb'
# Offense count: 3
RSpec/BeforeAfterAll:
Exclude:
- 'spec/spec_helper.rb'
- 'spec/rails_helper.rb'
- 'spec/support/**/*.rb'
- 'spec/lib/sequencer/unit/import/zendesk/ticket/comment/attachment/request_spec.rb'
- 'spec/lib/sequencer/unit/import/zendesk/ticket/comment/source_based_spec.rb'
- 'spec/models/translation_spec.rb'
# Offense count: 523
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
Enabled: false
# Offense count: 540
# Configuration parameters: Max.
RSpec/ExampleLength:
Enabled: false
# Offense count: 36
RSpec/ExpectActual:
Exclude:
- 'spec/routing/**/*'
- 'spec/requests/integration/monitoring_spec.rb'
- 'spec/requests/integration/object_manager_attributes_spec.rb'
- 'spec/requests/integration/twilio_sms_spec.rb'
- 'spec/requests/integration/user_device_spec.rb'
- 'spec/requests/organization_spec.rb'
- 'spec/requests/ticket/article_attachments_spec.rb'
- 'spec/requests/user/organization_spec.rb'
- 'spec/requests/user_spec.rb'
# Offense count: 3
RSpec/ExpectInHook:
Exclude:
- 'spec/models/calendar_spec.rb'
- 'spec/models/concerns/has_search_index_backend_examples.rb'
- 'spec/models/ticket/article_spec.rb'
# Offense count: 12
# Configuration parameters: CustomTransform, IgnoreMethods.
RSpec/FilePath:
Exclude:
- 'spec/db/migrate/20171023000001_fixed_store_upgrade_ror_45_spec.rb'
- 'spec/db/migrate/issue_1219_zhtw_locale_typo_spec.rb'
- 'spec/db/migrate/issue_1660_fix_tree_select_configurations_spec.rb'
- 'spec/db/migrate/issue_1905_exchange_login_from_remote_id_spec.rb'
- 'spec/db/migrate/issue_1977_remove_invalid_user_foreign_keys_spec.rb'
- 'spec/db/migrate/issue_2019_fix_double_domain_links_in_trigger_emails_spec.rb'
- 'spec/db/migrate/issue_2140_reset_ldap_config_spec.rb'
- 'spec/db/migrate/issue_2333_object_country_already_exists_spec.rb'
- 'spec/db/migrate/issue_2345_es_attachment_max_size_in_mb_setting_lower_default_spec.rb'
- 'spec/db/migrate/issue_2368_add_indices_to_histories_and_tickets_spec.rb'
- 'spec/db/migrate/issue_2541_fix_notification_email_without_body_spec.rb'
Fixes issue #2608 - missing default permission ("admin.trigger") Zammad's permission model supports fine-grained permissions so that, e.g, a user may be allowed to modify triggers but not channels. Permissions are assigned to roles, which are then assigned to users. A set of default permissions is provided in `db/seeds/permissions.rb`; these are the permissions that appear in the admin interface when creating a new role and selecting which permissions it grants. Somehow, we forgot to include the "admin.trigger" permission in this default set, and no one noticed until earlier this year. Zammad Community: https://community.zammad.org/t/2584
2019-10-29 10:41:12 +00:00
- 'spec/db/migrate/issue_2608_missing_trigger_permission_spec.rb'
Fix issue #2460 - corrupted IDs on Twitter channels break Direct Message functionality In some cases, editing a Twitter account via the admin panel would cause new DMs to stop coming in. Why? All Twitter usernames correspond to a numeric user ID (see https://tweeterid.com/). Zammad stores this ID on Twitter channels (under `channel.options['user']['id']`) and uses it to monitor incoming DMs. Zammad was storing these user IDs to the DB as integers, then passing those values to the frontend (JS) for account editing. Some user IDs are longer than JavaScript's `Number.MAX_SAFE_INTEGER`, and so got truncated on their way back to the update endpoint (e.g., 984608854112718800 instead of 984608854112718848). This commit enforces string storage of Twitter user IDs on new channels, and includes a migration to verify and stringify IDs on existing ones. Zammad Community: https://community.zammad.org/t/1799/34 GitHub: https://github.com/zammad/zammad/issues/2460
2019-11-07 06:21:46 +00:00
- 'spec/db/migrate/issue_2460_fix_corrupted_twitter_ids_spec.rb'
Fixes #2715 - Twitter DM URLs are broken When importing Twitter DMs (articles of type "twitter direct-message"), Zammad generates a source link URL of an incorrect format: https://twitter.com/statuses/:id This format is for statuses (or "tweets"). The appropriate URL scheme for direct messages is: https://twitter.com/messages/:recipient_id-:current_user_id This commit adds conditional logic for setting Twitter link URLs based on message type. It also provides a DB migration to rectify existing, broken DM URLs. For performance purposes, this migration is performed in the background and limited to the latest 10,000 DMs. GitHub: https://github.com/zammad/zammad/issues/2715
2019-11-07 10:01:58 +00:00
- 'spec/db/migrate/issue_2715_fix_broken_twitter_urls_spec.rb'
- 'spec/jobs/issue_2715_fix_broken_twitter_urls_job_spec.rb'
👮 Crack down on style violations with rubocop-rspec 🚓
2019-04-10 17:42:44 +00:00
- 'spec/lib/import/base_factory_spec.rb'
# Offense count: 60
# Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable:
Exclude:
- 'spec/lib/notification_factory/renderer_spec.rb'
- 'spec/models/import_job_spec.rb'
- 'spec/models/scheduler_spec.rb'
- 'spec/requests/api_auth_on_behalf_of_spec.rb'
- 'spec/requests/integration/monitoring_spec.rb'
- 'spec/requests/integration/sipgate_spec.rb'
- 'spec/requests/organization_spec.rb'
- 'spec/requests/report_spec.rb'
- 'spec/requests/text_module_spec.rb'
- 'spec/requests/ticket/article_attachments_spec.rb'
- 'spec/requests/user_spec.rb'
# Offense count: 34
RSpec/LetSetup:
Enabled: false
# Offense count: 242
# Configuration parameters: EnforcedStyle.
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
Enabled: false
# Offense count: 478
# Configuration parameters: AggregateFailuresByDefault.
RSpec/MultipleExpectations:
Max: 266
# Offense count: 83
# Configuration parameters: IgnoreSharedExamples.
RSpec/NamedSubject:
Exclude:
- 'spec/db/migrate/issue_2019_fix_double_domain_links_in_trigger_emails_spec.rb'
- 'spec/db/migrate/issue_2541_fix_notification_email_without_body_spec.rb'
- 'spec/lib/core_ext/string_spec.rb'
- 'spec/lib/import/exchange/folder_spec.rb'
- 'spec/lib/ldap/user_spec.rb'
- 'spec/lib/sequencer/unit/import/ldap/user/attributes/role_ids/unassigned_spec.rb'
- 'spec/lib/sessions/backend/activity_stream_spec.rb'
- 'spec/lib/upload_cache_spec.rb'
- 'spec/models/channel/filter/match/email_regex_spec.rb'
- 'spec/models/http_log_spec.rb'
- 'spec/models/object_manager/attribute/validation/backend_spec.rb'
- 'spec/models/object_manager/attribute/validation/future_past_spec.rb'
- 'spec/models/object_manager/attribute/validation/required_spec.rb'
- 'spec/models/object_manager/attribute/validation_spec.rb'
- 'spec/models/object_manager/attribute_spec.rb'
# Offense count: 545
RSpec/NestedGroups:
Refactoring: Migrate email_process_follow_up_test to RSpec
2019-05-13 09:29:49 +00:00
Max: 8
👮 Crack down on style violations with rubocop-rspec 🚓
2019-04-10 17:42:44 +00:00
# Offense count: 12
RSpec/RepeatedDescription:
Exclude:
- 'spec/models/translation_spec.rb'
- 'spec/requests/form_spec.rb'
- 'spec/requests/ticket_spec.rb'
# Offense count: 3
RSpec/ScatteredLet:
Exclude:
- 'spec/models/job_spec.rb'
- 'spec/models/ticket_spec.rb'
- 'spec/requests/integration/twitter_webhook_spec.rb'
# Offense count: 11
RSpec/ScatteredSetup:
Exclude:
- 'spec/models/ticket_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/requests/upload_cache_spec.rb'
# Offense count: 8
RSpec/SubjectStub:
Exclude:
- 'spec/models/concerns/has_groups_examples.rb'
- 'spec/models/concerns/has_roles_examples.rb'
- 'spec/models/job_spec.rb'
- 'spec/models/object_manager/attribute/validation/future_past_spec.rb'
- 'spec/models/object_manager/attribute/validation/required_spec.rb'
# Offense count: 25
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
RSpec/VerifiedDoubles:
Enabled: false
Reference in a new issue Copy permalink