trabajo-afectivo/spec/requests/calendar_subscriptions_spec.rb

# Copyright (C) 2012-2021 Zammad Foundation, http://zammad-foundation.org/

require 'rails_helper'

RSpec.describe 'iCal endpoints', type: :request do
  context 'with no existing session' do
    it 'gives HTTP Basic auth prompt (#3064)' do
      get '/ical/tickets'

      expect(response.body).to eq("HTTP Basic: Access denied.\n")
    end
  end
end
Maintenance: Update copyright information and add a new rubocop cop to watch over it. 2021-06-01 12:20:20 +00:00			`# Copyright (C) 2012-2021 Zammad Foundation, http://zammad-foundation.org/`

Fixes #3064: Double-render error on HTTP Basic auth This commit fixes a regression[0] introduced in becbdb1ba (the Pundit migration). Specifically, `CalendarSubscriptionsController` appears to be the only controller that supports HTTP Basic authentication (for calendar clients like Thunderbird Lightning or Calendar.app), and the migration changed the control flow for HTTP Basic authentication + authorization: # before authentication_check({ basic_auth_promt: true, permission: 'user_preferences.calendar' }) # after authentication_check(basic_auth_promt: true) && authorize! After this change, `#authentication_check` is expected to communicate success or failure through its return value, but prior to this bugfix, its return value was always truthy. This led to a double-render error, where a response code and message were set twice, upon the failures of both authentication and authorization. This fix adds a `return false` in the authorization failure case, short-circuiting the `#authorize!` call and eliminating the error. [0]: https://github.com/zammad/zammad/issues/3064 2020-05-25 16:26:06 +00:00			`require 'rails_helper'`

			`RSpec.describe 'iCal endpoints', type: :request do`
			`context 'with no existing session' do`
			`it 'gives HTTP Basic auth prompt (#3064)' do`
			`get '/ical/tickets'`

			`expect(response.body).to eq("HTTP Basic: Access denied.\n")`
			`end`
			`end`
			`end`