Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Added some syntactic suguar (used in rubocop cops).

Browse source
This commit is contained in:
Thorsten Eckel 2016-01-16 11:05:04 +01:00
parent b229d024f5
commit 00cffad79e
13 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/long_polling_controller.rb
View file

@ -89,7 +89,7 @@ class LongPollingController < ApplicationController
sleep 0.25
}
#sleep 2
if count == 0
if count.zero?
render json: { event: 'pong' }
return
end

6
app/models/application_model.rb
View file

@ -442,7 +442,7 @@ returns
# do lookup with == to handle case insensitive databases
records = where(login: data[:login])
records.each {|loop_record|
if loop_record.login.casecmp(data[:login]) == 0
if loop_record.login.casecmp(data[:login]).zero?
loop_record.update_attributes(data)
return loop_record
end
@ -455,7 +455,7 @@ returns
# do lookup with == to handle case insensitive databases
records = where(email: data[:email])
records.each {|loop_record|
if loop_record.email.casecmp(data[:email]) == 0
if loop_record.email.casecmp(data[:email]).zero?
loop_record.update_attributes(data)
return loop_record
end
@ -468,7 +468,7 @@ returns
# do lookup with == to handle case insensitive databases
records = where(locale: data[:locale])
records.each {|loop_record|
if loop_record.locale.casecmp(data[:locale]) == 0
if loop_record.locale.casecmp(data[:locale]).zero?
loop_record.update_attributes(data)
return loop_record
end

2
app/models/channel/driver/imap.rb
View file

@ -182,7 +182,7 @@ returns
end
@imap.expunge()
disconnect
if count == 0
if count.zero?
Rails.logger.info ' - no message'
end
Rails.logger.info 'done'

2
app/models/channel/driver/pop3.rb
View file

@ -151,7 +151,7 @@ returns
end
end
disconnect
if count == 0
if count.zero?
Rails.logger.info ' - no message'
end
Rails.logger.info 'done'

4
app/models/channel/email_parser.rb
View file

@ -193,7 +193,7 @@ class Channel::EmailParser
# not multipart email
# text part only
elsif !mail.mime_type || mail.mime_type.to_s == '' || mail.mime_type.to_s.casecmp('text/plain') == 0
elsif !mail.mime_type || mail.mime_type.to_s == '' || mail.mime_type.to_s.casecmp('text/plain').zero?
data[:body] = mail.body.decoded
data[:body] = Encode.conv(mail.charset, data[:body])
@ -204,7 +204,7 @@ class Channel::EmailParser
# html part only, convert to text and add it as attachment
else
filename = '-no name-'
if mail.mime_type.to_s.casecmp('text/html') == 0
if mail.mime_type.to_s.casecmp('text/html').zero?
filename = 'message.html'
data[:body] = mail.body.decoded
data[:body] = Encode.conv(mail.charset, data[:body])

2
app/models/chat.rb
View file

@ -46,7 +46,7 @@ class Chat < ApplicationModel
# check if agents are available
available_agents = Chat::Agent.where(active: true).where('updated_at > ?', Time.zone.now - 2.minutes).count
if available_agents == 0
if available_agents.zero?
return { state: 'offline' }
end

2
lib/encode.rb
View file

@ -11,7 +11,7 @@ module Encode
end
# validate already existing utf8 strings
if charset.casecmp('utf8') == 0 || charset.casecmp('utf-8') == 0
if charset.casecmp('utf8').zero? || charset.casecmp('utf-8').zero?
begin
# return if encoding is valid

2
lib/import/zendesk.rb
View file

@ -635,7 +635,7 @@ module Import::Zendesk
zendesk_attachments = zendesk_article.attachments
next if zendesk_attachments.size == 0
next if zendesk_attachments.size.zero?
local_attachments = local_article.attachments

6
lib/models.rb
View file

@ -124,7 +124,7 @@ returns
next if !model_attributes[:attributes].include?(item)
count = model_class.where("#{item} = ?", object_id).count
next if count == 0
next if count.zero?
if !references[model_class.to_s][item]
references[model_class.to_s][item] = 0
end
@ -144,7 +144,7 @@ returns
if reflection_value.options[:class_name] == object_name
count = model_class.where("#{col_name} = ?", object_id).count
next if count == 0
next if count.zero?
if !references[model_class.to_s][col_name]
references[model_class.to_s][col_name] = 0
end
@ -156,7 +156,7 @@ returns
next if reflection_value.name != object_name.downcase.to_sym
count = model_class.where("#{col_name} = ?", object_id).count
next if count == 0
next if count.zero?
if !references[model_class.to_s][col_name]
references[model_class.to_s][col_name] = 0
end

6
lib/report/base.rb
View file

@ -242,7 +242,7 @@ class Report::Base
time_total = time_total + diff
tickets += 1
}
if time_total == 0 || tickets == 0
if time_total.zero? || tickets.zero?
tickets = -0.001
else
tickets = time_total / tickets / 60
@ -279,7 +279,7 @@ class Report::Base
time_min = diff
end
}
tickets = if time_min == 0
tickets = if time_min.zero?
-0.001
else
(time_min / 60).to_i
@ -317,7 +317,7 @@ class Report::Base
time_max = diff
end
}
tickets = if time_max == 0
tickets = if time_max.zero?
-0.001
else
(time_max / 60).to_i

4
lib/stats/ticket_channel_distribution.rb
View file

@ -67,7 +67,7 @@ class Stats::TicketChannelDistribution
channels.each {|channel|
count = result[channel[:sender].to_sym][:inbound]
#puts "#{channel.inspect}:in/#{result.inspect}:#{count}"
in_process_precent = if count == 0
in_process_precent = if count.zero?
0
else
(count * 1000) / ((total_in * 1000) / 100)
@ -75,7 +75,7 @@ class Stats::TicketChannelDistribution
result[channel[:sender].to_sym][:inbound_in_percent] = in_process_precent
count = result[channel[:sender].to_sym][:outbound]
out_process_precent = if count == 0
out_process_precent = if count.zero?
0
else
(count * 1000) / ((total_out * 1000) / 100)

2
lib/stats/ticket_escalation.rb
View file

@ -21,7 +21,7 @@ class Stats::TicketEscalation
average = '-'
state = 'supergood'
state = if own_escalated == 0
state = if own_escalated.zero?
'supergood'
elsif own_escalated <= 1
'good'

2
script/websocket-server.rb
View file

@ -206,7 +206,7 @@ EventMachine.run {
}
EventMachine.add_periodic_timer(0.4) {
next if @clients.size == 0
next if @clients.size.zero?
#log 'debug', 'checking for data to send...'
@clients.each { |client_id, client|
next if client[:disconnect]