Fixes #3419 - Unable to close sidebar in ticket create screen after ticket split.

app/assets/javascripts/app/controllers/_application_controller/_base.coffee

@@ -82,9 +82,13 @@ class App.Controller extends Spine.Controller
       @el.empty()
 
     # release spine bindings (see release() of spine.coffee)
+    @off()
     @unbind()
     @stopListening()
 
+  release: ->
+    # nothing
+
   abortAjaxCalls: =>
     if !@ajaxCalls
       return
@@ -96,11 +100,6 @@ class App.Controller extends Spine.Controller
     for callId in idsToCancel
       App.Ajax.abort(callId)
 
-  # release Spine's event handling
-  release: ->
-    @off()
-    @stopListening()
-
   # add @title method to set title
   title: (name, translate = false) ->
 #    $('html head title').html(@Config.get(product_name) + ' - ' + App.i18n.translateInline(name))

app/assets/javascripts/app/controllers/_application_controller/generic_index.coffee

@@ -47,7 +47,7 @@ class App.ControllerGenericIndex extends App.Controller
 
   release: =>
     if @subscribeId
-      App[ @genericObject ].unsubscribe(@subscribeId)
+      App[@genericObject].unsubscribe(@subscribeId)
 
   paginate: (page) =>
     return if page is @pageData.pagerSelected

app/assets/javascripts/app/controllers/_manage/knowledge_base.coffee

@@ -50,7 +50,6 @@ class App.ManageKnowledgeBase extends App.ControllerTabs
     @fetchAndRender()
 
   release: ->
-    super
     @modal?.el.remove()
 
   processLoaded: ->

app/assets/javascripts/app/controllers/agent_ticket_create/sidebar.coffee

@@ -1,6 +1,8 @@
-class App.TicketCreateSidebar extends App.Controller
-  constructor: ->
-    super
+class App.TicketCreateSidebar
+  constructor: (options) ->
+    for key, value of options
+      @[key] = value
+
     @render()
 
   reload: (args) =>
@@ -40,7 +42,10 @@ class App.TicketCreateSidebar extends App.Controller
         )
       @sidebarItems.push @sidebarBackends[key]
 
-    new App.Sidebar(
+    if @sidebar
+      @sidebar.releaseController()
+
+    @sidebar = new App.Sidebar(
       el:           @el
       sidebarState: @sidebarState
       items:        @sidebarItems

app/assets/javascripts/app/controllers/api.coffee

@@ -79,7 +79,6 @@ class Api extends App.ControllerSubContent
 
 
   release: =>
-    super
     if @subscribeApplicationId
       App.Application.unsubscribe(@subscribeApplicationId)
 

app/assets/javascripts/app/controllers/chat.coffee

@@ -603,7 +603,6 @@ class ChatWindow extends App.Controller
   release: =>
     @trigger('closed')
     @el.remove()
-    super
 
   clearUnread: =>
     @$('.chat-message--new').removeClass('chat-message--new')

app/assets/javascripts/app/controllers/dashboard.coffee

@@ -89,9 +89,6 @@ class App.Dashboard extends App.Controller
   changed: ->
     false
 
-  release: ->
-    # no
-
   toggle: (e) =>
     @$('.tabs .tab').removeClass('active')
     $(e.target).addClass('active')

app/assets/javascripts/app/controllers/ticket_zoom/sidebar.coffee

@@ -47,8 +47,11 @@ class App.TicketZoomSidebar extends App.ControllerObserver
         )
       @sidebarItems.push @sidebarBackends[key]
 
-    new App.Sidebar(
-      el:           @el.find('.tabsSidebar')
+    if @sidebar
+      @sidebar.releaseController()
+
+    @sidebar = new App.Sidebar(
+      el:           @$('.tabsSidebar')
       sidebarState: @sidebarState
       items:        @sidebarItems
     )

app/assets/javascripts/app/controllers/ticket_zoom/taskbar_watcher.coffee

@@ -5,7 +5,7 @@ class App.TaskbarWatcher extends App.Controller
     App.TaskManager.preferencesTrigger(@taskKey)
 
   release: =>
-    return if !@subscribeId
+    if @subscribeId
       App.TaskManager.preferencesUnsubscribe(@subscribeId)
 
   render: (preferences) =>

app/assets/javascripts/app/controllers/widget/online_notification.coffee

@@ -63,7 +63,6 @@ class App.OnlineNotificationWidget extends App.Controller
   release: ->
     $(window).off 'click.notifications'
     $(window).off 'keydown.notifications'
-    super
 
   access: ->
     return false if !@Session.get()

app/assets/javascripts/app/controllers/widget/sidebar.coffee

@@ -10,6 +10,7 @@ class App.Sidebar extends App.Controller
 
   constructor: ->
     super
+
     @render()
 
     # get active tab by name
@@ -61,7 +62,7 @@ class App.Sidebar extends App.Controller
             type:  'small'
           )
 
-    @html localEl
+    @html(localEl)
 
   badgeRender: (el, item) =>
     @badgeEl = el
@@ -76,19 +77,18 @@ class App.Sidebar extends App.Controller
 
   toggleSidebar: =>
     @el.parent().find('.tabsSidebar-sidebarSpacer').toggleClass('is-closed')
-    @el.parent().find('.tabsSidebar').toggleClass('is-closed')
+    @el.filter('.tabsSidebar').toggleClass('is-closed')
     #@el.parent().next('.attributeBar').toggleClass('is-closed')
 
-  showSidebar: ->
+  showSidebar: =>
     @el.parent().find('.tabsSidebar-sidebarSpacer').removeClass('is-closed')
-    @el.parent().find('.tabsSidebar').removeClass('is-closed')
+    @el.filter('.tabsSidebar').removeClass('is-closed')
     #@el.parent().next('.attributeBar').addClass('is-closed')
 
   toggleTab: (e) =>
 
     # get selected tab
     name = $(e.target).closest('.tabsSidebar-tab').data('tab')
-
     if name
 
       # if current tab is selected again, toggle side bar
@@ -99,7 +99,7 @@ class App.Sidebar extends App.Controller
       else
         @toggleTabAction(name)
 
-  toggleTabAction: (name) ->
+  toggleTabAction: (name) =>
     return if !name
 
     # remember sidebarState for outsite

app/assets/javascripts/app/controllers/widget/update_taskbar.coffee

@@ -6,7 +6,7 @@ class App.UpdateTastbar extends App.Controller
     @subscribeId = @genericObject.subscribe(@update)
 
   release: =>
-    App[ @genericObject.constructor.className ].unsubscribe(@subscribeId)
+    App[@genericObject.constructor.className].unsubscribe(@subscribeId)
 
   update: (genericObject) =>