From 06be90f038052d937c129ceab57d4c4a5cd9132a Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Mon, 1 Mar 2021 14:23:03 +0000 Subject: [PATCH] Fixes #3435 - Broken counter check for attributes examples causes exchange integration wizard to check all entries instead of 50. --- lib/import/exchange/folder.rb | 4 +++- lib/import/helper/attributes_examples.rb | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/import/exchange/folder.rb b/lib/import/exchange/folder.rb index d3bb540db..0a785c6ef 100644 --- a/lib/import/exchange/folder.rb +++ b/lib/import/exchange/folder.rb @@ -56,7 +56,9 @@ module Import parent = parent.id if parent.respond_to?(:id) # type coercion @connection.folders(root: parent) rescue Viewpoint::EWS::EwsFolderNotFound => e - logger.warn(e) && return + logger.warn("Try to get children folders of: #{parent.inspect}") + logger.warn(e) + nil end end end diff --git a/lib/import/helper/attributes_examples.rb b/lib/import/helper/attributes_examples.rb index 587ea1bff..d362d1709 100644 --- a/lib/import/helper/attributes_examples.rb +++ b/lib/import/helper/attributes_examples.rb @@ -48,7 +48,7 @@ module Import @no_new_counter += 1 # check max 50 entries with no or no new attributes in a row - @enough_examples = @no_new_counter != 50 + @enough = @no_new_counter != 50 false end