Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Refactoring: Check error handling for Agent and Admin user accounts.

Browse source
This commit is contained in:
Thorsten Eckel 2021-02-10 09:11:02 +01:00
parent 0160e20427
commit 1e9cec8827
2 changed files with 30 additions and 56 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/tests_controller.rb
View file

@ -2,6 +2,8 @@
class TestsController < ApplicationController class TestsController < ApplicationController
prepend_before_action -> { authentication_check_only }
# GET /test/wait # GET /test/wait
def wait def wait
sleep params[:sec].to_i sleep params[:sec].to_i

70
spec/requests/error_spec.rb
View file

@ -3,6 +3,7 @@ require 'rails_helper'
RSpec.describe 'Error handling', type: :request do RSpec.describe 'Error handling', type: :request do
shared_examples 'JSON response format' do shared_examples 'JSON response format' do
let(:as) { :json } let(:as) { :json }
it { expect(response).to have_http_status(http_status) } it { expect(response).to have_http_status(http_status) }
@ -31,55 +32,6 @@ RSpec.describe 'Error handling', type: :request do
it { expect(response.body).to include(message) } it { expect(response.body).to include(message) }
end end
context 'error with confidential message is raised' do
let!(:ticket) { create(:ticket) }
let(:invalid_group_id) { 99_999 }
let(:http_status) { :unprocessable_entity }
before do
authenticated_as(requesting_user)
put "/api/v1/tickets/#{ticket.id}?all=true", params: { group_id: invalid_group_id }, as: as
end
context 'agent user' do
let(:requesting_user) { create(:agent, groups: Group.all) }
let(:message) { 'Please contact your administrator' }
context 'requesting JSON' do
include_examples 'JSON response format'
end
context 'requesting HTML' do
let(:title) { '422: Unprocessable Entity' }
let(:headline) { '422: The change you wanted was rejected.' }
include_examples 'HTML response format'
end
end
context 'admin user' do
let(:requesting_user) { create(:admin, groups: Group.all) }
if ActiveRecord::Base.connection_config[:adapter] == 'mysql2'
let(:message) { 'Mysql2::Error' }
else
let(:message) { 'PG::ForeignKeyViolation' }
end
context 'requesting JSON' do
include_examples 'JSON response format'
end
context 'requesting HTML' do
let(:title) { '422: Unprocessable Entity' }
let(:headline) { '422: The change you wanted was rejected.' }
include_examples 'HTML response format'
end
end
end
context 'URL route does not exist' do context 'URL route does not exist' do
before do before do
@ -147,12 +99,14 @@ RSpec.describe 'Error handling', type: :request do
context 'exception is raised' do context 'exception is raised' do
before do before do
authenticated_as(create(user))
get '/tests/raised_exception', params: { exception: exception.name, message: message }, as: as get '/tests/raised_exception', params: { exception: exception.name, message: message }, as: as
end end
shared_examples 'exception check' do |message, exception, http_status, title, headline| shared_examples 'exception check' do |message, exception, http_status, title, headline|
context "#{exception} is raised" do context "#{exception} is raised" do
let(:exception) { exception } let(:exception) { exception }
let(:http_status) { http_status } let(:http_status) { http_status }
let(:message) { message } let(:message) { message }
@ -178,6 +132,10 @@ RSpec.describe 'Error handling', type: :request do
include_examples 'exception check', 'Please contact your administrator', exception, http_status, title, headline include_examples 'exception check', 'Please contact your administrator', exception, http_status, title, headline
end end
context 'with agent user' do
let(:user) { :agent }
include_examples 'handles exception', Exceptions::NotAuthorized, :unauthorized, '401: Unauthorized', '401: Unauthorized' include_examples 'handles exception', Exceptions::NotAuthorized, :unauthorized, '401: Unauthorized', '401: Unauthorized'
include_examples 'handles exception', Exceptions::Forbidden, :forbidden, '403: Forbidden', '403: Forbidden' include_examples 'handles exception', Exceptions::Forbidden, :forbidden, '403: Forbidden', '403: Forbidden'
include_examples 'handles exception', Pundit::NotAuthorizedError, :forbidden, '403: Forbidden', '403: Forbidden', 'Not authorized' include_examples 'handles exception', Pundit::NotAuthorizedError, :forbidden, '403: Forbidden', '403: Forbidden', 'Not authorized'
@ -186,4 +144,18 @@ RSpec.describe 'Error handling', type: :request do
include_examples 'masks exception', ArgumentError, :unprocessable_entity, '422: Unprocessable Entity', '422: The change you wanted was rejected.' include_examples 'masks exception', ArgumentError, :unprocessable_entity, '422: Unprocessable Entity', '422: The change you wanted was rejected.'
include_examples 'masks exception', StandardError, :internal_server_error, '500: Something went wrong', "500: We're sorry, but something went wrong." include_examples 'masks exception', StandardError, :internal_server_error, '500: Something went wrong', "500: We're sorry, but something went wrong."
end end
context 'with admin user' do
let(:user) { :admin }
include_examples 'handles exception', Exceptions::NotAuthorized, :unauthorized, '401: Unauthorized', '401: Unauthorized'
include_examples 'handles exception', Exceptions::Forbidden, :forbidden, '403: Forbidden', '403: Forbidden'
include_examples 'handles exception', Pundit::NotAuthorizedError, :forbidden, '403: Forbidden', '403: Forbidden', 'Not authorized'
include_examples 'handles exception', ActiveRecord::RecordNotFound, :not_found, '404: Not Found', '404: Requested resource was not found'
include_examples 'handles exception', Exceptions::UnprocessableEntity, :unprocessable_entity, '422: Unprocessable Entity', '422: The change you wanted was rejected.'
include_examples 'handles exception', ArgumentError, :unprocessable_entity, '422: Unprocessable Entity', '422: The change you wanted was rejected.'
include_examples 'handles exception', StandardError, :internal_server_error, '500: Something went wrong', "500: We're sorry, but something went wrong."
end
end
end end