From 232c7b9bb481b8a6861f750ea6c3a65a83a34d4d Mon Sep 17 00:00:00 2001
From: Martin Edenhofer <me@zammad.com>
Date: Tue, 5 Nov 2019 15:32:49 +0100
Subject: [PATCH] Fixed issue #2797 - Allow direct or extention numbers in
 answeringNumber of CTI API.

---
 app/models/cti/driver/base.rb       |   7 ++
 spec/models/cti/driver/base_spec.rb | 134 ++++++++++++++++++++++++++++
 2 files changed, 141 insertions(+)
 create mode 100644 spec/models/cti/driver/base_spec.rb

diff --git a/app/models/cti/driver/base.rb b/app/models/cti/driver/base.rb
index 9b602b060..1249f5b84 100644
--- a/app/models/cti/driver/base.rb
+++ b/app/models/cti/driver/base.rb
@@ -9,6 +9,10 @@ class Cti::Driver::Base
     params
   end
 
+  def config
+    {}
+  end
+
   def process
 
     # validate directions
@@ -151,6 +155,9 @@ class Cti::Driver::Base
     # based on answeringNumber
     if @params[:answeringNumber].present?
       user = Cti::CallerId.known_agents_by_number(@params[:answeringNumber]).first
+      if !user
+        user = User.find_by(phone: @params[:answeringNumber], active: true)
+      end
     end
 
     # based on user param
diff --git a/spec/models/cti/driver/base_spec.rb b/spec/models/cti/driver/base_spec.rb
new file mode 100644
index 000000000..df3a4c5b8
--- /dev/null
+++ b/spec/models/cti/driver/base_spec.rb
@@ -0,0 +1,134 @@
+require 'rails_helper'
+
+RSpec.describe Cti::Driver::Base do
+  subject!(:driver) { described_class.new(mapping: {}, params: params, config: config ) }
+
+  let(:direction) { 'in' }
+  let(:event) { 'newCall' }
+  let(:config) { {} }
+  let(:params) { { 'direction' => direction, 'event' => event } }
+
+  describe '.direction_check' do
+    context 'for in direction' do
+      subject!(:direction) { 'in' }
+
+      it 'returns nil' do
+        expect(driver.direction_check).to be(nil)
+      end
+    end
+
+    context 'for out direction' do
+      subject!(:direction) { 'out' }
+
+      it 'returns nil' do
+        expect(driver.direction_check).to be(nil)
+      end
+    end
+
+    context 'for not existing direction' do
+      subject!(:direction) { 'not existing' }
+
+      it 'returns invalid_direction action' do
+        expect(driver.direction_check).to eq({ action: 'invalid_direction', params: { 'direction' => 'not existing', 'event' => 'newCall' } })
+      end
+    end
+  end
+
+  describe '.reject_check' do
+    context 'with reject number in from param and matching caller_id' do
+      let(:params) { { 'direction' => direction, 'event' => event, 'from' => '1234' } }
+      let(:config) do
+        {
+          inbound: {
+            block_caller_ids: [ { caller_id: '1234' } ],
+          },
+        }
+      end
+
+      it 'returns reject action' do
+        expect(driver.reject_check).to eq(action: 'reject')
+      end
+    end
+
+    context 'with reject number in from param and matching caller_id but wrong direction' do
+      let(:params) { { 'direction' => direction, 'event' => event, 'from' => '1234' } }
+      let(:direction) { 'out' }
+      let(:config) do
+        {
+          inbound: {
+            block_caller_ids: [ { caller_id: '1234' } ],
+          },
+        }
+      end
+
+      it 'returns nil' do
+        expect(driver.reject_check).to be(nil)
+      end
+    end
+
+    context 'with reject number in from param but not matching caller_id' do
+      let(:params) { { 'direction' => direction, 'event' => event, 'from' => '12345' } }
+      let(:direction) { 'in' }
+      let(:config) do
+        {
+          inbound: {
+            block_caller_ids: [ { caller_id: '1234' } ],
+          },
+        }
+      end
+
+      it 'returns nil' do
+        expect(driver.reject_check).to be(nil)
+      end
+    end
+  end
+
+  describe '.push_open_ticket_screen_recipient' do
+    context 'with direct number in answeringNumber params' do
+      let(:params) { { 'direction' => direction, 'event' => event, answeringNumber: user.phone } }
+      let!(:user) { create(:agent_user, phone: '1234567') }
+
+      it 'returns related user' do
+        expect(driver.push_open_ticket_screen_recipient).to eq(user)
+      end
+    end
+
+    context 'with not existing direct number in answeringNumber params' do
+      let(:params) { { 'direction' => direction, 'event' => event, answeringNumber: '98765421' } }
+      let!(:user) { create(:agent_user, phone: '1234567') }
+
+      it 'returns nil' do
+        expect(driver.push_open_ticket_screen_recipient).to be(nil)
+      end
+    end
+
+    context 'with real phone number in answeringNumber params' do
+      let(:params) { { 'direction' => direction, 'event' => event, answeringNumber: '491711000001' } }
+      let!(:user) { create(:agent_user, phone: '0171 1000001') }
+
+      it 'returns related user' do
+        expect(driver.push_open_ticket_screen_recipient).to eq(user)
+      end
+    end
+
+    context 'with user in upcase in params' do
+      let(:params) { { 'direction' => direction, 'event' => event, user: user.login.upcase } }
+      let!(:user) { create(:agent_user) }
+
+      it 'returns related user' do
+        expect(driver.push_open_ticket_screen_recipient).to eq(user)
+      end
+    end
+
+    context 'with user_id in params' do
+      let(:params) { { 'direction' => direction, 'event' => event, user_id: user.id } }
+      let!(:user) { create(:agent_user) }
+
+      it 'returns related user' do
+        expect(driver.push_open_ticket_screen_recipient).to eq(user)
+      end
+    end
+
+  end
+
+end