Updated rubocop to latest version (0.62.0) and applied required changes.

2019-01-01 17:54:13 +01:00 · 2019-01-01 17:54:13 +01:00 · 27b9bbd401
commit 27b9bbd401
parent 1e08fd7350
13 changed files with 4 additions and 20 deletions
--- a/.rubocop.yml
+++ b/.rubocop.yml
@ -10,6 +10,7 @@ AllCops:
    - 'bin/rake'
    - 'bin/spring'
    - 'db/schema.rb'
+    - 'vendor/**/*'

 Rails:
  Enabled: true
--- a/Gemfile.lock
+++ b/Gemfile.lock
@ -409,7 +409,7 @@ GEM
      rspec-mocks (~> 3.8.0)
      rspec-support (~> 3.8.0)
    rspec-support (3.8.0)
-    rubocop (0.61.1)
+    rubocop (0.62.0)
      jaro_winkler (~> 1.5.1)
      parallel (~> 1.10)
      parser (>= 2.5, != 2.5.1.1)
@ -486,7 +486,7 @@ GEM
    unf (0.1.4)
      unf_ext
    unf_ext (0.0.7.5)
-    unicode-display_width (1.4.0)
+    unicode-display_width (1.4.1)
    unicorn (5.3.1)
      kgio (~> 2.6)
      raindrops (~> 0.7)
--- a/lib/import/base_factory.rb
+++ b/lib/import/base_factory.rb
@ -1,7 +1,5 @@
 module Import
  module BaseFactory
-
-    # rubocop:disable Style/ModuleFunction
    extend self

    def import_action(records, *args)
--- a/lib/import/otrs.rb
+++ b/lib/import/otrs.rb
@ -27,8 +27,6 @@ module Import
    extend Import::OTRS::ImportStats
    extend Import::OTRS::Async
    extend Import::OTRS::Diff
-
-    # rubocop:disable Style/ModuleFunction
    extend self

    def start
--- a/lib/import/otrs/article/attachment_factory.rb
+++ b/lib/import/otrs/article/attachment_factory.rb
@ -3,8 +3,6 @@ module Import
    class Article
      module AttachmentFactory
        extend Import::Helper
-
-        # rubocop:disable Style/ModuleFunction
        extend self

        def import(args)
--- a/lib/import/otrs/diff.rb
+++ b/lib/import/otrs/diff.rb
@ -1,7 +1,6 @@
 module Import
  module OTRS
    module Diff
-      # rubocop:disable Style/ModuleFunction
      extend self

      def diff_worker
--- a/lib/import/otrs/dynamic_field_factory.rb
+++ b/lib/import/otrs/dynamic_field_factory.rb
@ -3,8 +3,6 @@ module Import
    module DynamicFieldFactory
      extend Import::Factory
      extend Import::Helper
-
-      # rubocop:disable Style/ModuleFunction
      extend self

      def skip?(record, *_args)
--- a/lib/import/otrs/helper.rb
+++ b/lib/import/otrs/helper.rb
@ -1,7 +1,6 @@
 module Import
  module OTRS
    module Helper
-      # rubocop:disable Style/ModuleFunction
      extend self

      private
--- a/lib/import/otrs/history_factory.rb
+++ b/lib/import/otrs/history_factory.rb
@ -2,8 +2,6 @@ module Import
  module OTRS
    module HistoryFactory
      extend Import::Factory
-
-      # rubocop:disable Style/ModuleFunction
      extend self

      def skip?(record, *_args)
--- a/lib/import/otrs/import_stats.rb
+++ b/lib/import/otrs/import_stats.rb
@ -1,7 +1,6 @@
 module Import
  module OTRS
    module ImportStats
-      # rubocop:disable Style/ModuleFunction
      extend self

      def current_state
--- a/lib/import/otrs/requester.rb
+++ b/lib/import/otrs/requester.rb
@ -5,8 +5,6 @@ module Import
    #   @return [Number] the sleep time between the request retries
    module Requester
      extend Import::Helper
-
-      # rubocop:disable Style/ModuleFunction
      extend self

      attr_accessor :retry_sleep
--- a/lib/import/otrs/sys_config_factory.rb
+++ b/lib/import/otrs/sys_config_factory.rb
@ -1,8 +1,6 @@
 module Import
  module OTRS
    module SysConfigFactory
-
-      # rubocop:disable Style/ModuleFunction
      extend self

      def import(settings, *_args)
--- a/lib/password_hash.rb
+++ b/lib/password_hash.rb
@ -3,7 +3,7 @@
 module PasswordHash
  include ApplicationLib

-  extend self # rubocop:disable Style/ModuleFunction
+  extend self

  def crypt(password)
    argon2.create(password)