Migrate email_process_identify_sender_max_test to RSpec
This commit is contained in:
parent
80c7dec624
commit
2af6392172
5 changed files with 119 additions and 97 deletions
3
Gemfile
3
Gemfile
|
@ -164,8 +164,9 @@ group :development, :test do
|
||||||
# changelog generation
|
# changelog generation
|
||||||
gem 'github_changelog_generator'
|
gem 'github_changelog_generator'
|
||||||
|
|
||||||
# Use Factory Bot for generating random test data
|
# generate random test data
|
||||||
gem 'factory_bot_rails'
|
gem 'factory_bot_rails'
|
||||||
|
gem 'faker'
|
||||||
|
|
||||||
# mock http calls
|
# mock http calls
|
||||||
gem 'webmock'
|
gem 'webmock'
|
||||||
|
|
|
@ -165,6 +165,8 @@ GEM
|
||||||
factory_bot_rails (4.8.2)
|
factory_bot_rails (4.8.2)
|
||||||
factory_bot (~> 4.8.2)
|
factory_bot (~> 4.8.2)
|
||||||
railties (>= 3.0.0)
|
railties (>= 3.0.0)
|
||||||
|
faker (1.9.1)
|
||||||
|
i18n (>= 0.7)
|
||||||
faraday (0.12.2)
|
faraday (0.12.2)
|
||||||
multipart-post (>= 1.2, < 3)
|
multipart-post (>= 1.2, < 3)
|
||||||
faraday-http-cache (2.0.0)
|
faraday-http-cache (2.0.0)
|
||||||
|
@ -533,6 +535,7 @@ DEPENDENCIES
|
||||||
eventmachine
|
eventmachine
|
||||||
execjs
|
execjs
|
||||||
factory_bot_rails
|
factory_bot_rails
|
||||||
|
faker
|
||||||
github_changelog_generator
|
github_changelog_generator
|
||||||
guard
|
guard
|
||||||
guard-livereload
|
guard-livereload
|
||||||
|
|
|
@ -1,16 +1,49 @@
|
||||||
require 'rails_helper'
|
require 'rails_helper'
|
||||||
|
|
||||||
RSpec.describe Channel::EmailParser, type: :model do
|
RSpec.describe Channel::EmailParser, type: :model do
|
||||||
|
let(:subject) { described_class.new }
|
||||||
let(:mail_file) { Rails.root.join('test', 'data', 'mail', 'mail001.box') }
|
let(:mail_file) { Rails.root.join('test', 'data', 'mail', 'mail001.box') }
|
||||||
let(:raw_mail) { File.read(mail_file) }
|
let(:raw_mail) { File.read(mail_file) }
|
||||||
|
|
||||||
describe '#process' do
|
describe '#process' do
|
||||||
let(:raw_mail) { File.read(mail_file).sub(/(?<=^Subject: ).*$/, test_string) }
|
let(:raw_mail) { File.read(mail_file).sub(/(?<=^Subject: ).*$/, test_string) }
|
||||||
let(:test_string) do
|
let(:test_string) { Setting.get('ticket_hook') + Setting.get('ticket_hook_divider') + ticket.number }
|
||||||
Setting.get('ticket_hook') + Setting.get('ticket_hook_divider') + ticket.number
|
|
||||||
end
|
|
||||||
let(:ticket) { create(:ticket) }
|
let(:ticket) { create(:ticket) }
|
||||||
|
|
||||||
|
context 'for creating new users' do
|
||||||
|
context 'with one unrecognized email address' do
|
||||||
|
let(:raw_mail) { <<~RAW }
|
||||||
|
From: #{Faker::Internet.unique.email}
|
||||||
|
To: #{User.pluck(:email).reject(&:blank?).sample}
|
||||||
|
Subject: Foo bar
|
||||||
|
|
||||||
|
Lorem ipsum dolor
|
||||||
|
RAW
|
||||||
|
|
||||||
|
it 'creates one new user' do
|
||||||
|
expect { Channel::EmailParser.new.process({}, raw_mail) }
|
||||||
|
.to change { User.count }.by(1)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'with a large number (42+) of unrecognized email addresses' do
|
||||||
|
let(:raw_mail) { <<~RAW }
|
||||||
|
From: #{Faker::Internet.unique.email}
|
||||||
|
To: #{Array.new(22) { Faker::Internet.unique.email }.join(', ')}
|
||||||
|
Cc: #{Array.new(22) { Faker::Internet.unique.email }.join(', ')}
|
||||||
|
Subject: test max sender identify
|
||||||
|
|
||||||
|
Some Text
|
||||||
|
RAW
|
||||||
|
|
||||||
|
it 'never creates more than 41 users per email' do
|
||||||
|
expect { Channel::EmailParser.new.process({}, raw_mail) }
|
||||||
|
.to change { User.count }.by(41)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'for associating emails to tickets' do
|
||||||
context 'when email subject contains ticket reference' do
|
context 'when email subject contains ticket reference' do
|
||||||
it 'adds message to ticket' do
|
it 'adds message to ticket' do
|
||||||
expect { described_class.new.process({}, raw_mail) }
|
expect { described_class.new.process({}, raw_mail) }
|
||||||
|
@ -50,7 +83,9 @@ RSpec.describe Channel::EmailParser, type: :model do
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'for sender/recipient address formatting' do
|
||||||
# see https://github.com/zammad/zammad/issues/2198
|
# see https://github.com/zammad/zammad/issues/2198
|
||||||
context 'when sender address contains spaces (#2198)' do
|
context 'when sender address contains spaces (#2198)' do
|
||||||
let(:mail_file) { Rails.root.join('test', 'data', 'mail', 'mail071.box') }
|
let(:mail_file) { Rails.root.join('test', 'data', 'mail', 'mail071.box') }
|
||||||
|
@ -90,7 +125,9 @@ RSpec.describe Channel::EmailParser, type: :model do
|
||||||
.and include('mail_delivery_failed_data' => a_kind_of(ActiveSupport::TimeWithZone))
|
.and include('mail_delivery_failed_data' => a_kind_of(ActiveSupport::TimeWithZone))
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'for charset handling' do
|
||||||
# see https://github.com/zammad/zammad/issues/2224
|
# see https://github.com/zammad/zammad/issues/2224
|
||||||
context 'when header specifies Windows-1258 charset (#2224)' do
|
context 'when header specifies Windows-1258 charset (#2224)' do
|
||||||
let(:mail_file) { Rails.root.join('test', 'data', 'mail', 'mail072.box') }
|
let(:mail_file) { Rails.root.join('test', 'data', 'mail', 'mail072.box') }
|
||||||
|
@ -101,4 +138,5 @@ RSpec.describe Channel::EmailParser, type: :model do
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
5
spec/support/faker.rb
Normal file
5
spec/support/faker.rb
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
RSpec.configure do |config|
|
||||||
|
config.after(:each) do
|
||||||
|
Faker::UniqueGenerator.clear
|
||||||
|
end
|
||||||
|
end
|
|
@ -1,25 +0,0 @@
|
||||||
require 'test_helper'
|
|
||||||
|
|
||||||
class EmailProcessIdentifySenderMax < ActiveSupport::TestCase
|
|
||||||
|
|
||||||
test 'text max created recipients per email' do
|
|
||||||
current_users = User.count
|
|
||||||
email_raw_string = "From: #{generate_recipient}
|
|
||||||
To: #{generate_recipient(22)}
|
|
||||||
Cc: #{generate_recipient(22)}
|
|
||||||
Subject: test max sender identify
|
|
||||||
|
|
||||||
Some Text"
|
|
||||||
|
|
||||||
ticket_p, article_p, user_p, mail = Channel::EmailParser.new.process({}, email_raw_string)
|
|
||||||
ticket = Ticket.find(ticket_p.id)
|
|
||||||
assert_equal('test max sender identify', ticket.title)
|
|
||||||
assert_equal(current_users + 41, User.count)
|
|
||||||
end
|
|
||||||
|
|
||||||
def generate_recipient(count = 1)
|
|
||||||
uid = -> { rand(999_999_999_999_999) }
|
|
||||||
Array.new(count) { "#{uid.call}@#{uid.call}.example.com" }.join(', ')
|
|
||||||
end
|
|
||||||
|
|
||||||
end
|
|
Loading…
Reference in a new issue