From 2e51c25b1a30395283ae636f4dccf76f75850135 Mon Sep 17 00:00:00 2001
From: Felix Niklas <mrflix@gmail.com>
Date: Mon, 19 Oct 2015 16:05:33 +0200
Subject: [PATCH] refactor avatars

---
 .../app/controllers/widget/avatar.coffee      |  7 +-
 app/assets/javascripts/app/models/user.coffee | 74 ++++++++++---------
 .../javascripts/app/views/avatar.jst.eco      |  4 +-
 .../app/views/avatar_system.jst.eco           |  3 +
 .../app/views/avatar_unique.jst.eco           |  4 +
 5 files changed, 49 insertions(+), 43 deletions(-)
 create mode 100644 app/assets/javascripts/app/views/avatar_system.jst.eco
 create mode 100644 app/assets/javascripts/app/views/avatar_unique.jst.eco

diff --git a/app/assets/javascripts/app/controllers/widget/avatar.coffee b/app/assets/javascripts/app/controllers/widget/avatar.coffee
index 331ba8bc7..73991604f 100644
--- a/app/assets/javascripts/app/controllers/widget/avatar.coffee
+++ b/app/assets/javascripts/app/controllers/widget/avatar.coffee
@@ -9,12 +9,7 @@ class App.WidgetAvatar extends App.Controller
     App.User.unsubscribe(@subscribeId)
 
   render: (user) =>
-    @html App.view('avatar')(
-      user:     user
-      size:     @size
-      position: @position
-      type:     @type
-    )
+    @html user.avatar @size, @position, undefined, false, false, @type
 
     # start user popups
     @userPopups(@position)
diff --git a/app/assets/javascripts/app/models/user.coffee b/app/assets/javascripts/app/models/user.coffee
index 61d90a8e1..6edb71b68 100644
--- a/app/assets/javascripts/app/models/user.coffee
+++ b/app/assets/javascripts/app/models/user.coffee
@@ -46,55 +46,57 @@ class App.User extends App.Model
       return '??'
 
   avatar: (size = 40, placement = '', cssClass = '', unique = false, avatar, type = undefined) ->
-    cssClass += " size-#{size}"
+    size   = parseInt(size, 10)
+
+    cssClass += " " if cssClass
+    cssClass += "size-#{ size }"
 
     if placement
-      placement = "data-placement=\"#{placement}\""
+      placement = " data-placement='#{ placement }'"
 
-    # use system avatar for system actions
-    if @id is 1
-      return "<span class='avatar' style='background: white'>#{App.Utils.icon('logo')}</span>"
+    if !avatar
+      if type is 'personal'
+        vip = false
+        data = " data-id=\"#{@id}\""
+      else
+        cssClass += ' user-popover'
+        data      = " data-id=\"#{@id}\""
+    else
+      vip = false
+      data = " data-avatar-id=\"#{avatar.id}\""
 
-    # use generated avatar
-    if !@image || @image is 'none' || unique
-      return @uniqueAvatar(size, placement, cssClass, avatar, type)
-
-    # use image as avatar
-    image = @imageUrl()
     vip = @vip
     if type is 'personal'
       vip = false
     else
       cssClass += ' user-popover'
 
-    if vip
-      return "<span class=\"avatar #{cssClass}\" data-id=\"#{@id}\" style=\"background-image: url(#{image})\" #{placement}><svg class='icon icon-crown'><use xlink:href='#icon-crown'></svg></span>"
-    "<span class=\"avatar #{cssClass}\" data-id=\"#{@id}\" style=\"background-image: url(#{image})\" #{placement}></span>"
+    # use system avatar for system actions
+    if @id is 1
+      return App.view('avatar_system')()
+    else if !@image || @image is 'none' || unique
+      width  = 300
+      height = 226
 
-  uniqueAvatar: (size, placement = '', cssClass = '', avatar, type) ->
-    width  = 300
-    height = 226
-    size   = parseInt(size, 10)
-    vip    = @vip
+      rng = new Math.seedrandom(@id)
+      x   = rng() * (width - size)
+      y   = rng() * (height - size)
 
-    rng = new Math.seedrandom(@id)
-    x   = rng() * (width - size)
-    y   = rng() * (height - size)
-
-    if !avatar
-      if type is 'personal'
-        vip = false
-        data = "data-id=\"#{@id}\""
-      else
-        cssClass += ' user-popover'
-        data      = "data-id=\"#{@id}\""
+      return App.view('avatar_unique')
+        data: data
+        cssClass: cssClass
+        placement: placement
+        vip: vip
+        x: x
+        y: y
+        initials: @initials()
     else
-      vip = false
-      data = "data-avatar-id=\"#{avatar.id}\""
-
-    if vip
-      return "<span class=\"avatar unique #{cssClass}\" #{data} style=\"background-position: -#{ x }px -#{ y }px;\" #{placement}><svg class='icon icon-crown'><use xlink:href='#icon-crown'></svg>#{ @initials() }</span>"
-    "<span class=\"avatar unique #{cssClass}\" #{data} style=\"background-position: -#{ x }px -#{ y }px;\" #{placement}>#{ @initials() }</span>"
+      return App.view('avatar')
+        data: data
+        cssClass: cssClass
+        placement: placement
+        vip: vip
+        url: @imageUrl()
 
   imageUrl: ->
     return if !@image
diff --git a/app/assets/javascripts/app/views/avatar.jst.eco b/app/assets/javascripts/app/views/avatar.jst.eco
index 3beb48952..423634fb4 100644
--- a/app/assets/javascripts/app/views/avatar.jst.eco
+++ b/app/assets/javascripts/app/views/avatar.jst.eco
@@ -1 +1,3 @@
-<%- @user.avatar(@size, @position, @class, false, false, @type) %>
\ No newline at end of file
+<span class="avatar <%- @cssClass %>" style="background-image: url(<%- @url %>)"<%- @placement %><%- @data %>>
+  <%- @Icon('crown') if @vip %>
+</span>
\ No newline at end of file
diff --git a/app/assets/javascripts/app/views/avatar_system.jst.eco b/app/assets/javascripts/app/views/avatar_system.jst.eco
new file mode 100644
index 000000000..726316e5b
--- /dev/null
+++ b/app/assets/javascripts/app/views/avatar_system.jst.eco
@@ -0,0 +1,3 @@
+<span class="avatar <%- @cssClass %>" style="background: white">
+  <%- @Icon('logo') %>
+</span>
\ No newline at end of file
diff --git a/app/assets/javascripts/app/views/avatar_unique.jst.eco b/app/assets/javascripts/app/views/avatar_unique.jst.eco
new file mode 100644
index 000000000..c384ef7f9
--- /dev/null
+++ b/app/assets/javascripts/app/views/avatar_unique.jst.eco
@@ -0,0 +1,4 @@
+<span class="avatar <%- @cssClass %> unique" style="background-position: -<%- @x %>px -<%- @y %>px;"<%- @placement %><%- @data %>>
+  <%- @Icon('crown') if @vip %>
+  <%= @initials %>
+</span>
\ No newline at end of file