From 326c0903f1f44427d21a1f371a92907dda4d23fb Mon Sep 17 00:00:00 2001
From: Martin Edenhofer <me@edenhofer.de>
Date: Mon, 14 Jul 2014 09:39:09 +0200
Subject: [PATCH] Improved error handling.

---
 app/models/observer/ticket/notification.rb | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/app/models/observer/ticket/notification.rb b/app/models/observer/ticket/notification.rb
index 1418032b2..f80218257 100644
--- a/app/models/observer/ticket/notification.rb
+++ b/app/models/observer/ticket/notification.rb
@@ -34,6 +34,7 @@ class Observer::Ticket::Notification < ActiveRecord::Observer
         next if !ticket
 
         article = ticket.articles[-1]
+        next if !article
       else
         raise "unknown object for notification #{event[:name]}"
       end
@@ -237,17 +238,13 @@ class Observer::Ticket::Notification < ActiveRecord::Observer
 
     # add history record
     if recipient_list != ''
-      created_by_id = 1
-      if article && article.created_by_id
-        created_by_id = article.created_by_id
-      end
       History.add(
         :o_id                   => ticket.id,
         :history_type           => 'notification',
         :history_object         => 'Ticket',
         :value_from             => notification_subject,
         :value_to               => recipient_list,
-        :created_by_id          => created_by_id
+        :created_by_id          => article.created_by_id || 1
       )
     end
   end