Maintenance: Added ShellCheck for linting of shell scripts.

.gitlab/ci/pre.yml

@@ -13,6 +13,14 @@ rubocop:
     - bundle install -j $(nproc) --path vendor
     - bundle exec rubocop --parallel
 
+shellcheck:
+  <<: *template_pre
+  image: koalaman/shellcheck-alpine:stable
+  before_script:
+    - echo "Disable default before_script."
+  script:
+    - shellcheck -S error $(find . -name "*.sh" | grep -v "/vendor/")
+
 coffeelint:
   <<: *template_pre
   script:

script/install.sh

@@ -97,10 +97,9 @@ sudo -u "${USER}" -H bash -l -c 'cd ~/zammad && RAILS_ENV=production rake db:mig
 sudo -u "${USER}" -H bash -l -c 'cd ~/zammad && RAILS_ENV=production rake db:seed'
 sudo -u "${USER}" -H bash -l -c 'cd ~/zammad && RAILS_ENV=production rake assets:precompile'
 
-cp "${HOMEDIR}/zammad/script/init.d/zammad /etc/init.d/zammad"
+cp "${HOMEDIR}/zammad/script/init.d/zammad" /etc/init.d/zammad
 chmod +x /etc/init.d/zammad
 
 if [ "$OS" = "Debian" ]; then
   update-rc.d zammad defaults
 fi
-