From 364f74f558fa42e9050d5c081ea3dc097c2208af Mon Sep 17 00:00:00 2001
From: Thorsten Eckel <te@znuny.com>
Date: Tue, 24 Jul 2018 17:32:32 +0200
Subject: [PATCH] Test stabilization: Updated overview push via the Scheduler
 to the frontend might take a bit longer.

---
 test/browser/admin_overview_test.rb | 45 ++++++++++-------------------
 1 file changed, 15 insertions(+), 30 deletions(-)

diff --git a/test/browser/admin_overview_test.rb b/test/browser/admin_overview_test.rb
index e9cfe0b9c..a6bbae3f0 100644
--- a/test/browser/admin_overview_test.rb
+++ b/test/browser/admin_overview_test.rb
@@ -94,24 +94,11 @@ class AdminOverviewTest < TestCase
       }
     )
 
-    click(
-      browser: instance,
-      css:  'a[href="#ticket/view"]',
-      mute_log: true,
-    )
-    click(
-      browser: instance,
-      css:  "div.overview-header a[href='#ticket/view/#{name}']",
-      mute_log: true,
+    overview_open(
+      name: name
     )
 
-    # Sort the tickets according to their onscreen Y location
-    tickets_low_to_high = ticket_titles.map do |title|
-      [title,
-       get_location( css: "td[title='#{title}']").y]
-    end
-    tickets_low_to_high = tickets_low_to_high.sort_by { |x| -x[1] }.map { |x| x[0] }
-    assert_equal(ticket_titles, tickets_low_to_high)
+    assert_equal(ticket_titles.reverse, ordered_ticket_titles(ticket_titles))
 
     # Update overview to sort groups from low to high
     overview_update(
@@ -121,23 +108,21 @@ class AdminOverviewTest < TestCase
       }
     )
 
-    click(
-      browser: instance,
-      css:  'a[href="#ticket/view"]',
-      mute_log: true,
-    )
-    click(
-      browser: instance,
-      css:  "div.overview-header a[href='#ticket/view/#{name}']",
-      mute_log: true,
+    overview_open(
+      name: name
     )
 
-    # Sort the tickets according to their onscreen Y location
-    tickets_high_to_low = ticket_titles.map do |title|
+    # wait till the scheduler pushed
+    # the changes to the FE
+    sleep 5
+
+    assert_equal(ticket_titles, ordered_ticket_titles(ticket_titles))
+  end
+
+  def ordered_ticket_titles(ticket_titles)
+    ticket_titles.map do |title|
       [title,
        get_location( css: "td[title='#{title}']").y]
-    end
-    tickets_high_to_low = tickets_high_to_low.sort_by { |x| x[1] }.map { |x| x[0] }
-    assert_equal(ticket_titles, tickets_high_to_low)
+    end.sort_by { |x| x[1] }.map { |x| x[0] }
   end
 end