From 3b0a373de0f0fc5da8a1226a559a00129c4cff82 Mon Sep 17 00:00:00 2001
From: Romit Choudhary <rc@zammad.com>
Date: Thu, 9 Sep 2021 14:40:53 +0200
Subject: [PATCH] Fixes #3271 - AttributeManager doesn't display boolean
 default values within the UI

---
 .../object_manager/attribute/boolean.jst.eco   |  4 ++--
 spec/system/system/object_manager_spec.rb      | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/app/assets/javascripts/app/views/object_manager/attribute/boolean.jst.eco b/app/assets/javascripts/app/views/object_manager/attribute/boolean.jst.eco
index 9b9bcef84..51408ec45 100644
--- a/app/assets/javascripts/app/views/object_manager/attribute/boolean.jst.eco
+++ b/app/assets/javascripts/app/views/object_manager/attribute/boolean.jst.eco
@@ -13,14 +13,14 @@
         <td class="settings-list-control-cell">
           <input class="form-control form-control--small js-valueTrue" type="text" value="<% if @params.data_option && @params.data_option.options: %><%= @params.data_option.options[true] %><% end %>" name="data_option::options::true" placeholder="<%- @T('yes') %>" required/>
         <td class="settings-list-row-control">
-          <input class="js-selected js-boolean" type="radio" name="data_option::default" value="true" <% if @params.data_option && @params.data_option.default is 'true': %>checked<% end %>/>
+          <input class="js-selected js-boolean" type="radio" name="data_option::default" value="true" <% if @params.data_option && @params.data_option.default is true: %>checked<% end %>/>
       <tr>
         <td class="settings-list-control-cell">
           false
         <td class="settings-list-control-cell">
           <input class="form-control form-control--small js-valueFalse" type="text" value="<% if @params.data_option && @params.data_option.options: %><%= @params.data_option.options[false] %><% end %>" name="data_option::options::false" placeholder="<%- @T('no') %>" required/>
         <td class="settings-list-row-control">
-          <input class="js-selected js-boolean" type="radio" name="data_option::default" value="false" <% if @params.data_option && @params.data_option.default is 'false': %>checked<% end %>/>
+          <input class="js-selected js-boolean" type="radio" name="data_option::default" value="false" <% if @params.data_option && @params.data_option.default is false: %>checked<% end %>/>
     </tbody>
   </table>
 </div>
diff --git a/spec/system/system/object_manager_spec.rb b/spec/system/system/object_manager_spec.rb
index 4d973aed7..3bd5c1fa8 100644
--- a/spec/system/system/object_manager_spec.rb
+++ b/spec/system/system/object_manager_spec.rb
@@ -114,6 +114,24 @@ RSpec.describe 'Admin Panel > Objects', type: :system do
     expect(ObjectManager::Attribute.last.data_option['options']).to eq(expected_data_options)
   end
 
+  it 'checks default boolean value visibility' do
+    page.find('.js-new').click
+
+    fill_in 'Name', with: 'bool1'
+    find('input[name=display]').set('Bool 1')
+
+    page.find('select[name=data_type]').select('Boolean')
+    choose('data_option::default', option: 'true')
+    page.find('.js-submit').click
+
+    td = page.find(:css, 'td', text: 'bool1')
+    tr = td.find(:xpath, './parent::tr')
+
+    tr.click
+
+    expect(page).to have_checked_field('data_option::default', with: 'true')
+  end
+
   # https://github.com/zammad/zammad/issues/3647
   context 'when setting Min/Max values for integer' do
     before do