Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Refactoring: Improve test to prefer helper macro over CSS selector and 'let' helper method over hardcoded string

Browse source
This commit is contained in:
Bola Ahmed Buari 2021-03-04 11:12:35 +01:00
parent e716a555d9
commit 3efacf186c
No known key found for this signature in database
GPG key ID: 69F689AC67133AFC
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
spec/system/ticket/zoom_spec.rb
View file

@ -1428,7 +1428,8 @@ RSpec.describe 'Ticket zoom', type: :system do
end
describe 'Macros', authenticated_as: :authenticate do
let(:macro) { create :macro, perform: { 'article.note'=>{ 'body' => 'macro <b>body</b>', 'internal' => 'true', 'subject' => 'macro note' } } }
let(:macro_body) { 'macro <b>body</b>' }
let(:macro) { create :macro, perform: { 'article.note' => { 'body' => macro_body, 'internal' => 'true', 'subject' => 'macro note' } } }
let!(:ticket) { create(:ticket, group: Group.find_by(name: 'Users')) }
def authenticate
@ -1439,10 +1440,10 @@ RSpec.describe 'Ticket zoom', type: :system do
it 'does html macro by default' do
visit "ticket/zoom/#{ticket.id}"
find('.js-openDropdownMacro').click
all('.js-dropdownActionMacro').last.click
find(:macro, macro.id).click
await_empty_ajax_queue
expect(ticket.reload.articles.last.body).to eq('macro <b>body</b>')
expect(ticket.reload.articles.last.body).to eq(macro_body)
expect(ticket.reload.articles.last.content_type).to eq('text/html')
end
end