Fixes #3415: Unable to process ticket bulk action from overview.

This commit is contained in:
Bola Ahmed Buari 2021-02-26 13:46:47 +00:00 committed by Thorsten Eckel
parent 2db2f3407d
commit 3fecb53915
2 changed files with 59 additions and 1 deletions

View file

@ -243,7 +243,7 @@ class TicketsController < ApplicationController
ticket.with_lock do ticket.with_lock do
ticket.update!(clean_params) ticket.update!(clean_params)
if params[:article] if params[:article].present?
article_create(ticket, params[:article]) article_create(ticket, params[:article])
end end
end end

View file

@ -149,6 +149,30 @@ RSpec.describe 'Ticket', type: :request do
expect(json_response['created_by_id']).to eq(agent.id) expect(json_response['created_by_id']).to eq(agent.id)
end end
it 'does ticket create with empty article body' do
params = {
title: 'a new ticket with empty article body',
group: ticket_group.name,
priority: '2 normal',
state: 'new',
customer: customer.email,
article: { body: '' }
}
authenticated_as(agent)
post '/api/v1/tickets', params: params, as: :json
expect(response).to have_http_status(:created)
expect(json_response).to be_a_kind_of(Hash)
expect(json_response['state_id']).to eq(Ticket::State.lookup(name: 'new').id)
expect(json_response['title']).to eq('a new ticket with empty article body')
expect(json_response['customer_id']).to eq(customer.id)
expect(json_response['updated_by_id']).to eq(agent.id)
expect(json_response['created_by_id']).to eq(agent.id)
ticket = Ticket.find(json_response['id'])
expect(ticket.articles.count).to eq(1)
article = ticket.articles.first
expect(article.body).to eq('')
end
it 'does ticket create with agent - wrong owner_id - 0 (01.05)' do it 'does ticket create with agent - wrong owner_id - 0 (01.05)' do
params = { params = {
title: 'a new ticket #4', title: 'a new ticket #4',
@ -1742,6 +1766,40 @@ RSpec.describe 'Ticket', type: :request do
expect(json_response['assets']['Ticket'][ticket.id.to_s]['number']).to eq(expected_ticket_number) expect(json_response['assets']['Ticket'][ticket.id.to_s]['number']).to eq(expected_ticket_number)
end end
it 'does ticket update with empty article param' do
title = 'a new ticket'
ticket = create(
:ticket,
title: title,
group: ticket_group,
customer_id: customer.id,
updated_by_id: agent.id,
created_by_id: agent.id,
)
params = {
state: Ticket::State.lookup(name: 'close'),
article: {}
}
authenticated_as(agent)
put "/api/v1/tickets/#{ticket.id}", params: params, as: :json
expect(response).to have_http_status(:ok)
expect(json_response).to be_a_kind_of(Hash)
expect(json_response['state_id']).to eq(ticket.state_id)
expect(json_response['state']).to be_falsey
expect(json_response['priority_id']).to eq(ticket.priority_id)
expect(json_response['priority']).to be_falsey
expect(json_response['group_id']).to eq(ticket.group_id)
expect(json_response['group']).to be_falsey
expect(json_response['customer_id']).to eq(customer.id)
expect(json_response['updated_by_id']).to eq(agent.id)
expect(json_response['created_by_id']).to eq(agent.id)
expect(json_response['state_id']).to eq(Ticket::State.lookup(name: 'new').id)
expect(json_response['title']).to eq(ticket.title)
expect(ticket.articles.count).to eq(0)
end
it 'does ticket split with html - check attachments (05.01)' do it 'does ticket split with html - check attachments (05.01)' do
ticket = create( ticket = create(
:ticket, :ticket,