Fixed issue #1381: Exchange folder with unsupported entries fails configuration. Also improved error handling of empty folders or not selected folders.

app/assets/javascripts/app/controllers/_integration/exchange.coffee

@@ -187,6 +187,7 @@ class ConnectionWizard extends App.WizardModal
   elements:
     '.modal-body': 'body'
     '.js-foldersSelect': 'foldersSelect'
+    '.js-folders .js-submitTry': 'foldersSelectSubmit'
     '.js-userMappingForm': 'userMappingForm'
     '.js-expertForm': 'expertForm'
 
@@ -321,6 +322,11 @@ class ConnectionWizard extends App.WizardModal
       nulloption: false
       options: options
       value: selected
+      onChange: (val) =>
+        if val && val.length > 0
+          @foldersSelectSubmit.removeClass('is-disabled')
+        else
+          @foldersSelectSubmit.addClass('is-disabled')
     )
 
   mapping: (e) =>

app/assets/javascripts/app/lib/app_post/column_select.coffee

@@ -33,6 +33,11 @@ class App.ColumnSelect extends Spine.Controller
       @select @pickedValue
     , 300, {trailing: false}
 
+    if @attribute.onChange
+      @shadow.on('change', =>
+        @attribute.onChange(@shadow.val())
+      )
+
   render: ->
     @values = []
     _.each @options.attribute.options, (option) =>

app/assets/javascripts/app/views/integration/exchange_wizard.jst.eco

@@ -115,7 +115,7 @@
         <a class="btn btn--text btn--secondary js-goToSlide align-left" data-slide="js-bind"><%- @T('Go Back') %></a>
       </div>
       <div class="modal-rightFooter">
-        <button class="btn btn--primary align-right js-submitTry"><%- @T('Continue') %></button>
+        <button class="btn btn--primary align-right js-submitTry is-disabled"><%- @T('Continue') %></button>
       </div>
     </div>
   </form>

app/controllers/integration/exchange_controller.rb

@@ -33,15 +33,20 @@ class Integration::ExchangeController < ApplicationController
 
   def mapping
     answer_with do
-      Sequencer.process('Import::Exchange::AttributesExamples',
+      raise 'Please select at least one folder.' if params[:folders].blank?
-                        parameters: {
+
-                          ews_folder_ids: params[:folders],
+      examples = Sequencer.process('Import::Exchange::AttributesExamples',
-                          ews_config:     {
+                                   parameters: {
-                            endpoint: params[:endpoint],
+                                     ews_folder_ids: params[:folders],
-                            user:     params[:user],
+                                     ews_config:     {
-                            password: params[:password],
+                                       endpoint: params[:endpoint],
-                          }
+                                       user:     params[:user],
-                        })
+                                       password: params[:password],
+                                     }
+                                   })
+      examples.tap do |result|
+        raise 'No entries found in selected folder(s).' if result[:attributes].blank?
+      end
     end
   end
 

lib/sequencer/unit/import/exchange/attribute_examples.rb

@@ -16,10 +16,17 @@ class Sequencer
 
                 ews_folder_ids.collect do |folder_id|
 
-                  ews_folder.find(folder_id).items.each do |resource|
+                  begin
-                    attributes = ::Import::Exchange::ItemAttributes.extract(resource)
+                    ews_folder.find(folder_id).items.each do |resource|
-                    extractor.extract(attributes)
+                      attributes = ::Import::Exchange::ItemAttributes.extract(resource)
-                    break if extractor.enough
+                      extractor.extract(attributes)
+                      break if extractor.enough
+                    end
+                  rescue NoMethodError => e
+                    raise if e.message !~ /Viewpoint::EWS::/
+
+                    logger.error e
+                    logger.error "Skipping folder_id '#{folder_id}' due to unsupported entries."
                   end
                 end
               end.examples