diff --git a/app/assets/javascripts/app/lib/app_post/utils.coffee b/app/assets/javascripts/app/lib/app_post/utils.coffee index 266e7d3e1..70eef244e 100644 --- a/app/assets/javascripts/app/lib/app_post/utils.coffee +++ b/app/assets/javascripts/app/lib/app_post/utils.coffee @@ -1344,7 +1344,9 @@ class App.Utils ctx = canvas.getContext('2d') ctx.drawImage(img, 0, 0, img.width, img.height) try - data = canvas.toDataURL('image/png') + # img alt attribute is used to get file type + # if not present, then it will default to image/png + data = canvas.toDataURL(App.Utils.getMimeTypeFromFilename(img.alt)) params.success(img, data) if params.success return data catch e @@ -1406,6 +1408,7 @@ class App.Utils imageCache.onerror = -> App.Log.notice('Utils', "Unable to load image from #{originalImage.src}") params.fail(originalImage) if params.fail + imageCache.alt = originalImage.alt imageCache.src = originalImage.src @baseUrl: -> @@ -1470,3 +1473,13 @@ class App.Utils @safeParseHtml: (input) -> try $.parseHTML(input) catch e then $.parseHTML('
' + input + '
')[0].childNodes + + + # Gets file Mime Type from file name + # For e.g. oscar-menu.jpg returns image/jpeg + # For other file types it return image/png as default mimeType + @getMimeTypeFromFilename: (filename) -> + if filename?.match(/\.(jpe?g)$/i) + return 'image/jpeg' + + return 'image/png' diff --git a/app/views/tests/html_utils.html.erb b/app/views/tests/html_utils.html.erb index 0bb0c9792..652eb5973 100644 --- a/app/views/tests/html_utils.html.erb +++ b/app/views/tests/html_utils.html.erb @@ -16,3 +16,9 @@ body {
+ +
+ +
+ +
diff --git a/public/assets/tests/html_utils.js b/public/assets/tests/html_utils.js index 62c4b339d..b35771815 100644 --- a/public/assets/tests/html_utils.js +++ b/public/assets/tests/html_utils.js @@ -3304,6 +3304,44 @@ var htmlImage2DataUrlTest2Fail = function() { ok(false, 'fail callback is exectuted!') }); } + +// Gitlab Issue #3538 +// Jpeg images should convert to jpegs +// This functionality uses alt attribute present in img tag to get file type +// if alt attribute is missing then it will default to image/png +var jpegImageSource = 'test.jpegjpeg image' +$('#jpegImage').html(jpegImageSource) +var htmlImage2DataUrlTest3 = function() { + test("htmlImage2DataUrl3 async", function() { + var result = App.Utils.htmlImage2DataUrl(jpegImageSource) + ok(result.match(/jpeg image/), jpegImageSource) + ok(result.match(/^\