From 4cfede572ea960f79d8f910b7429915f0e25ec3b Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Tue, 21 Jun 2016 20:42:55 +0200 Subject: [PATCH] Improved stability of tests. --- test/browser/agent_ticket_actions_level8_test.rb | 8 ++++---- test/browser_test_helper.rb | 16 ++++++++++++---- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/test/browser/agent_ticket_actions_level8_test.rb b/test/browser/agent_ticket_actions_level8_test.rb index 72c2ef94b..ada964fe9 100644 --- a/test/browser/agent_ticket_actions_level8_test.rb +++ b/test/browser/agent_ticket_actions_level8_test.rb @@ -118,7 +118,7 @@ class AgentTicketActionLevel8Test < TestCase sendkey( value: :enter, ) - sleep 3 + sleep 10 # set tag #2 click( @@ -131,7 +131,7 @@ class AgentTicketActionLevel8Test < TestCase sendkey( value: :enter, ) - sleep 3 + sleep 10 # set tag #3 + #4 click( @@ -144,7 +144,7 @@ class AgentTicketActionLevel8Test < TestCase sendkey( value: :enter, ) - sleep 3 + sleep 10 # set tag #5 click( @@ -157,7 +157,7 @@ class AgentTicketActionLevel8Test < TestCase click( css: '#global-search', ) - sleep 3 + sleep 10 # verify tags tags_verify( diff --git a/test/browser_test_helper.rb b/test/browser_test_helper.rb index 3aed3233b..55f12e848 100644 --- a/test/browser_test_helper.rb +++ b/test/browser_test_helper.rb @@ -1467,7 +1467,6 @@ wait untill text in selector disabppears element.click element.clear - # workaround, sometimes focus is not triggered element.send_keys(params[:customer]) sleep 2.5 @@ -1830,13 +1829,23 @@ wait untill text in selector disabppears element.click element.clear - # workaround, sometimes focus is not triggered + # ff issue, sometimes focus event gets dropped + # if drowdown is not open, try it again + if !instance.find_elements(css: '.active .newTicket .js-recipientDropdown.open')[0] + instance.execute_script('$(".active .newTicket .js-recipientDropdown").addClass("open")') + end + element.send_keys(data[:customer]) sleep 2.5 element.send_keys(:enter) - #instance.find_elements(css: '.active .newTicket .recipientList-entry.js-user.is-active')[0].click sleep 0.4 + # ff issue, sometimes enter event gets dropped + # take user manually + if instance.find_elements(css: '.active .newTicket .js-recipientDropdown.open')[0] + instance.find_elements(css: '.active .newTicket .recipientList-entry.js-user.is-active')[0].click + sleep 0.4 + end end if params[:custom_data_select] @@ -1993,7 +2002,6 @@ wait untill text in selector disabppears element.click element.clear - # workaround, sometimes focus is not triggered element.send_keys(data[:customer]) sleep 2.5