Maintenance: Prevent back porting of new __() methods from develop.
This commit is contained in:
parent
a9b57e5719
commit
4d90a7b240
5 changed files with 42 additions and 1 deletions
20
.coffeelint/rules/prevent_underscore_backport.coffee
Normal file
20
.coffeelint/rules/prevent_underscore_backport.coffee
Normal file
|
@ -0,0 +1,20 @@
|
||||||
|
module.exports = class PreventUnderscoreBackport
|
||||||
|
|
||||||
|
rule:
|
||||||
|
name: 'prevent_underscore_backport'
|
||||||
|
level: 'error'
|
||||||
|
message: 'The method __(...) is not available in current stable'
|
||||||
|
description: '''
|
||||||
|
'''
|
||||||
|
|
||||||
|
constructor: ->
|
||||||
|
@callTokens = []
|
||||||
|
|
||||||
|
tokens: ['CALL_START']
|
||||||
|
|
||||||
|
lintToken: (token, tokenApi) ->
|
||||||
|
[type, tokenValue] = token
|
||||||
|
|
||||||
|
p = tokenApi.peek(-1)
|
||||||
|
if p[1] == '__'
|
||||||
|
return { }
|
|
@ -48,7 +48,7 @@ brakeman:
|
||||||
coffeelint:
|
coffeelint:
|
||||||
<<: *template_pre
|
<<: *template_pre
|
||||||
script:
|
script:
|
||||||
- coffeelint app/
|
- coffeelint --rules ./.coffeelint/rules/* app/
|
||||||
|
|
||||||
bundle-audit:
|
bundle-audit:
|
||||||
<<: *template_pre
|
<<: *template_pre
|
||||||
|
|
17
.rubocop/cop/zammad/prevent_underscore_backport.rb
Normal file
17
.rubocop/cop/zammad/prevent_underscore_backport.rb
Normal file
|
@ -0,0 +1,17 @@
|
||||||
|
# Copyright (C) 2012-2021 Zammad Foundation, http://zammad-foundation.org/
|
||||||
|
|
||||||
|
module RuboCop
|
||||||
|
module Cop
|
||||||
|
module Zammad
|
||||||
|
class PreventUnderscroreBackport < Base
|
||||||
|
MSG = <<~ERROR_MESSAGE.freeze
|
||||||
|
The method __(...) is not available in current stable.
|
||||||
|
ERROR_MESSAGE
|
||||||
|
|
||||||
|
def on_send(node)
|
||||||
|
add_offense(node) if node.method_name.eql? :__
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
|
@ -10,3 +10,4 @@ require_relative 'cop/zammad/no_to_sym_on_string'
|
||||||
require_relative 'cop/zammad/prefer_negated_if_over_unless'
|
require_relative 'cop/zammad/prefer_negated_if_over_unless'
|
||||||
require_relative 'cop/zammad/update_copyright'
|
require_relative 'cop/zammad/update_copyright'
|
||||||
require_relative 'cop/zammad/forbid_rand'
|
require_relative 'cop/zammad/forbid_rand'
|
||||||
|
require_relative 'cop/zammad/prevent_underscore_backport'
|
||||||
|
|
|
@ -131,5 +131,8 @@
|
||||||
},
|
},
|
||||||
"transform_messes_up_line_numbers": {
|
"transform_messes_up_line_numbers": {
|
||||||
"level": "error"
|
"level": "error"
|
||||||
|
},
|
||||||
|
"prevent_underscore_backport": {
|
||||||
|
"level": "error"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue