From 691f2006b23949f65fa5f9613615c8dd179ab4b5 Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Tue, 5 Apr 2016 23:49:45 +0200 Subject: [PATCH] Added shortcuts to electron events. --- .../controllers/widget/electron_events.coffee | 24 ++--- .../widget/keyboard_shortcuts.coffee | 88 ++++++++++++------- 2 files changed, 70 insertions(+), 42 deletions(-) diff --git a/app/assets/javascripts/app/controllers/widget/electron_events.coffee b/app/assets/javascripts/app/controllers/widget/electron_events.coffee index 2d49e4602..920f4f658 100644 --- a/app/assets/javascripts/app/controllers/widget/electron_events.coffee +++ b/app/assets/javascripts/app/controllers/widget/electron_events.coffee @@ -4,31 +4,35 @@ class Widget electron = window.require('electron') return if !electron remote = electron.remote + ipc = electron.ipcRenderer App.Event.bind('online_notification_counter', (e) -> setBadge(e) ) + ipc.on('global-shortcut', (e, arg) -> + App.Event.trigger('global-shortcut', arg) + ) Menu = remote.Menu MenuItem = remote.MenuItem createDefault = -> menu = new Menu() - menu.append(new MenuItem({ + menu.append(new MenuItem( label: 'Cut', role: 'cut' - })) - menu.append(new MenuItem({ + )) + menu.append(new MenuItem( label: 'Copy', role: 'copy' - })) - menu.append(new MenuItem({ + )) + menu.append(new MenuItem( label: 'Paste', role: 'paste' - })) - menu.append(new MenuItem({ + )) + menu.append(new MenuItem( label: 'Select All', role: 'selectall' - })) + )) menu menu = createDefault() @@ -55,7 +59,7 @@ class Widget ctx.fillStyle = '#ffffff' ctx.textAlign = 'center' ctx.textBaseline = 'middle' - ctx.font = (11 * scale) + 'px sans-serif' + ctx.font = (10 * scale) + 'px sans-serif' ctx.fillText(text, size / 2, size / 2, size) canvas.toDataURL() @@ -69,7 +73,7 @@ class Widget }) if content isnt '' - dataURL = badgeDataURL.createDataURL(content.toString()) + dataURL = badgeDataURL(content.toString()) sendBadge(dataURL, 'You have unread messages (' + content + ')') else sendBadge(null, 'You have no unread messages') diff --git a/app/assets/javascripts/app/controllers/widget/keyboard_shortcuts.coffee b/app/assets/javascripts/app/controllers/widget/keyboard_shortcuts.coffee index 64e82fe1f..f381ed0c6 100644 --- a/app/assets/javascripts/app/controllers/widget/keyboard_shortcuts.coffee +++ b/app/assets/javascripts/app/controllers/widget/keyboard_shortcuts.coffee @@ -40,7 +40,18 @@ class App.KeyboardShortcutWidget extends Spine.Module modifier += shortcut.key if shortcut.callback @log 'debug', 'bind for', modifier - $(document).bind('keydown', modifier, shortcut.callback) + $(document).bind('keydown', modifier, (e) -> + e.preventDefault() + shortcut.callback() + ) + + App.Event.bind('global-shortcut', (e) -> + for area in areas + for item in area.content + for shortcut in item.shortcuts + if shortcut.globalEvent is e + shortcut.callback() + ) App.Config.set('keyboard_shortcuts', App.KeyboardShortcutWidget, 'Widgets') App.Config.set( @@ -57,8 +68,8 @@ App.Config.set( key: 'd' hotkeys: true description: 'Dashboard' - callback: (e) -> - e.preventDefault() + globalEvent: 'dashboard' + callback: -> $('#global-search').blur() App.Event.trigger('keyboard_shortcuts_close') window.location.hash = '#dashboard' @@ -67,8 +78,8 @@ App.Config.set( key: 'o' hotkeys: true description: 'Overviews' - callback: (e) -> - e.preventDefault() + globalEvent: 'overview' + callback: -> $('#global-search').blur() App.Event.trigger('keyboard_shortcuts_close') window.location.hash = '#ticket/view' @@ -77,8 +88,8 @@ App.Config.set( key: 's' hotkeys: true description: 'Search' - callback: (e) -> - e.preventDefault() + globalEvent: 'search' + callback: -> App.Event.trigger('keyboard_shortcuts_close') $('#global-search').focus() } @@ -86,8 +97,8 @@ App.Config.set( key: 'a' hotkeys: true description: 'Notifications' - callback: (e) -> - e.preventDefault() + globalEvent: 'notification' + callback: -> $('#global-search').blur() App.Event.trigger('keyboard_shortcuts_close') $('#navigation .js-toggleNotifications').click() @@ -96,8 +107,8 @@ App.Config.set( key: 'n' hotkeys: true description: 'New Ticket' - callback: (e) -> - e.preventDefault() + globalEvent: 'new-ticket' + callback: -> $('#global-search').blur() App.Event.trigger('keyboard_shortcuts_close') window.location.hash = '#ticket/create' @@ -106,8 +117,8 @@ App.Config.set( key: 'e' hotkeys: true description: 'Logout' - callback: (e) -> - e.preventDefault() + globalEvent: 'logout' + callback: -> App.Event.trigger('keyboard_shortcuts_close') window.location.hash = '#logout' } @@ -115,8 +126,8 @@ App.Config.set( key: 'h' hotkeys: true description: 'List of shortcuts' + globalEvent: 'list-of-shortcuts' callback: (e) => - e.preventDefault() if @dialog && @dialog.exists() @dialog.close() @dialog = false @@ -127,8 +138,8 @@ App.Config.set( key: 'x' hotkeys: true description: 'Close current tab' - callback: (e) -> - e.preventDefault() + globalEvent: 'close-current-tab' + callback: -> App.Event.trigger('keyboard_shortcuts_close') $('#navigation .tasks .is-active .js-close').click() } @@ -136,8 +147,8 @@ App.Config.set( key: 'tab' hotkeys: true description: 'Next in tab' - callback: (e) -> - e.preventDefault() + globalEvent: 'next-in-tab' + callback: -> App.Event.trigger('keyboard_shortcuts_close') scollIfNeeded = (element) -> return if !element @@ -159,8 +170,8 @@ App.Config.set( key: 'shift+tab' hotkeys: true description: 'Previous tab' - callback: (e) -> - e.preventDefault() + globalEvent: 'previous-in-tab' + callback: -> App.Event.trigger('keyboard_shortcuts_close') scollIfNeeded = (element) -> return if !element @@ -182,8 +193,8 @@ App.Config.set( key: 'return' hotkeys: true description: 'Confirm/submit dialog' - callback: (e) -> - e.preventDefault() + globalEvent: 'submit' + callback: -> App.Event.trigger('keyboard_shortcuts_close') # check of primary modal exists @@ -242,6 +253,7 @@ App.Config.set( key: 't' hotkeys: true description: 'Enable/disable inline translations' + globalEvent: 'translation-mode' } ] } @@ -258,8 +270,8 @@ App.Config.set( key: 'm' hotkeys: true description: 'Open note box' - callback: (e) -> - e.preventDefault() + globalEvent: 'article-note-open' + callback: -> App.Event.trigger('keyboard_shortcuts_close') $('.active.content .editControls .js-articleTypes [data-value="note"]').click() $('.active.content .article-new .articleNewEdit-body').first().focus() @@ -268,8 +280,8 @@ App.Config.set( key: 'g' hotkeys: true description: 'Reply to last article' - callback: (e) -> - e.preventDefault() + globalEvent: 'article-reply' + callback: -> App.Event.trigger('keyboard_shortcuts_close') lastArticleWithReply = $('.active.content .ticket-article .icon-reply').last() lastArticleWithReplyAll = lastArticleWithReply.parent().find('.icon-reply-all') @@ -282,8 +294,8 @@ App.Config.set( key: 'j' hotkeys: true description: 'Set article to internal/public' - callback: (e) -> - e.preventDefault() + globalEvent: 'article-internal-public' + callback: -> App.Event.trigger('keyboard_shortcuts_close') $('.active.content .editControls .js-selectInternalPublic').click() } @@ -291,16 +303,16 @@ App.Config.set( # key: 'm' # hotkeys: true # description: 'Open macro selection' - # callback: (e) -> - # e.preventDefault() + # globalEvent: 'macro-open' + # callback: -> # window.location.hash = '#ticket/create' #} { key: 'c' hotkeys: true description: 'Update as closed' - callback: (e) -> - e.preventDefault() + globalEvent: 'task-update-close' + callback: -> App.Event.trigger('keyboard_shortcuts_close') return if !$('.active.content .edit').get(0) $('.active.content .edit [name="state_id"]').val(4) @@ -322,61 +334,73 @@ App.Config.set( key: 'u' hotkeys: true description: 'Format as _underlined_' + globalEvent: 'richtext-underline' } { key: 'b' hotkeys: true description: 'Format as |bold|' + globalEvent: 'richtext-bold' } { key: 'i' hotkeys: true description: 'Format as ||italic||' + globalEvent: 'richtext-italic' } { key: 'v' hotkeys: true description: 'Format as //strikethrough//' + globalEvent: 'richtext-strikethrough' } { key: 'f' hotkeys: true description: 'Removes the formatting' + globalEvent: 'richtext-remove-formating' } { key: 'z' hotkeys: true, description: 'Inserts a horizontal rule' + globalEvent: 'richtext-hr' } { key: 'l' hotkeys: true, description: 'Format as unordered list' + globalEvent: 'richtext-ul' } { key: 'k' hotkeys: true, description: 'Format as ordered list' + globalEvent: 'richtext-ol' } { key: '1' hotkeys: true, description: 'Format as h1 heading' + globalEvent: 'richtext-h1' } { key: '2' hotkeys: true, description: 'Format as h2 heading' + globalEvent: 'richtext-h2' } { key: '3' hotkeys: true, description: 'Format as h3 heading' + globalEvent: 'richtext-h3' } { key: 'w' hotkeys: true, description: 'Removes any hyperlink' + globalEvent: 'richtext-remove-hyperlink' } ] }