Test stabilization: The combination of sleep and exists_not is slow and prone to timing issues.

2018-07-23 19:35:44 +02:00 · 2018-07-23 19:35:44 +02:00 · 6998eb9be2
commit 6998eb9be2
parent 5e4958e7ac
1 changed files with 4 additions and 2 deletions
--- a/test/browser/signup_password_change_and_reset_test.rb
+++ b/test/browser/signup_password_change_and_reset_test.rb
@ -31,9 +31,11 @@ class SignupPasswordChangeAndResetTest < TestCase
      value: 'some-pass',
    )
    click(css: 'button.js-submit')
-    sleep 5

-    exists_not(css: '.signup')
+    watch_for_disappear(
+      css: '.signup',
+      timeout: 10,
+    )

    match(
      css: '.user-menu .user a',