From efea3648fcc3b618315f626459fa131687ab3e47 Mon Sep 17 00:00:00 2001 From: Felix Niklas Date: Wed, 10 Feb 2016 11:42:35 +0100 Subject: [PATCH 1/2] columnSelect: trigger change on the select on change --- app/assets/javascripts/app/lib/app_post/column_select.coffee | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/assets/javascripts/app/lib/app_post/column_select.coffee b/app/assets/javascripts/app/lib/app_post/column_select.coffee index 8ce6a520c..d710ec2db 100644 --- a/app/assets/javascripts/app/lib/app_post/column_select.coffee +++ b/app/assets/javascripts/app/lib/app_post/column_select.coffee @@ -50,6 +50,7 @@ class App.ColumnSelect extends Spine.Controller @pool.find("[data-value='#{value}']").addClass 'is-hidden' @values.push(value) @shadow.val(@values) + @shadow.trigger('change') @placeholder.addClass 'is-hidden' @@ -64,6 +65,7 @@ class App.ColumnSelect extends Spine.Controller @selected.find("[data-value='#{value}']").addClass 'is-hidden' @values.splice(@values.indexOf(value), 1) @shadow.val(@values) + @shadow.trigger('change') if !@values.length @placeholder.removeClass 'is-hidden' From ab0f41c043d8750f3fb1b21fc8712db38c8a8280 Mon Sep 17 00:00:00 2001 From: Felix Niklas Date: Wed, 10 Feb 2016 12:03:55 +0100 Subject: [PATCH 2/2] columnSelect: fix overflow in FF in modals --- app/assets/stylesheets/zammad.scss | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/app/assets/stylesheets/zammad.scss b/app/assets/stylesheets/zammad.scss index 40b5d14eb..eac093397 100644 --- a/app/assets/stylesheets/zammad.scss +++ b/app/assets/stylesheets/zammad.scss @@ -1195,6 +1195,17 @@ fieldset { } } +/* + +Firefox Specific Hack +to fix the overflow of column select with long names +https://stackoverflow.com/questions/17408815/fieldset-resizes-wrong-appears-to-have-unremovable-min-width-min-content/17863685#17863685 + +*/ +@-moz-document url-prefix() { + fieldset { display: table-cell; } +} + fieldset > .form-group { padding: 0 4px;