From 7efe34e53bac67c143841f6fa5cf1353b844e5a7 Mon Sep 17 00:00:00 2001 From: Thorsten Eckel Date: Thu, 7 May 2015 10:01:35 +0200 Subject: [PATCH] Corrected with rubocop cop 'Lint/UnusedMethodArgument'. --- .rubocop.yml | 5 ----- app/controllers/application_controller.rb | 2 +- app/controllers/sessions/collection_network.rb | 2 +- app/models/channel/filter/database.rb | 2 +- app/models/channel/sendmail.rb | 2 +- app/models/channel/twitter2.rb | 8 ++++---- app/models/observer/ticket/notification.rb | 2 +- app/models/observer/ticket/notification/background_job.rb | 6 +++--- app/models/package.rb | 2 +- lib/auth/developer.rb | 2 +- lib/auth/internal.rb | 2 +- lib/import/otrs2.rb | 6 +++--- lib/search_index_backend.rb | 2 +- lib/sso/env.rb | 2 +- lib/sso/otrs.rb | 2 +- test/browser_test_helper.rb | 2 +- 16 files changed, 22 insertions(+), 27 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 3b8d266ea..54fa633a2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -205,11 +205,6 @@ Lint/UnusedBlockArgument: StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars' Enabled: false -Lint/UnusedMethodArgument: - Description: 'Checks for unused method arguments.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars' - Enabled: false - Style/SignalException: Description: 'Checks for proper usage of fail and raise.' StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#fail-method' diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 8e1692fe8..2f057ac77 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -363,7 +363,7 @@ class ApplicationController < ActionController::Base render json: generic_object.attributes_with_associations, status: :ok end - def model_index_render (object, params) + def model_index_render (object, _params) begin generic_objects = object.all model_index_render_result( generic_objects ) diff --git a/app/controllers/sessions/collection_network.rb b/app/controllers/sessions/collection_network.rb index 4a6d8d579..d50c98fdc 100644 --- a/app/controllers/sessions/collection_network.rb +++ b/app/controllers/sessions/collection_network.rb @@ -1,7 +1,7 @@ # Copyright (C) 2012-2014 Zammad Foundation, http://zammad-foundation.org/ module ExtraCollection - def session( collections, assets, user ) + def session( collections, assets, _user ) collections[ Network.to_app_model ] = Network.all collections[ Network::Category.to_app_model ] = Network::Category.all diff --git a/app/models/channel/filter/database.rb b/app/models/channel/filter/database.rb index 980cc1b6b..2945c8b3b 100644 --- a/app/models/channel/filter/database.rb +++ b/app/models/channel/filter/database.rb @@ -3,7 +3,7 @@ # process all database filter module Channel::Filter::Database - def self.run( channel, mail ) + def self.run( _channel, mail ) # process postmaster filter filters = PostmasterFilter.where( active: true, channel: 'email' ) diff --git a/app/models/channel/sendmail.rb b/app/models/channel/sendmail.rb index 21b81426a..e0ce4cc93 100644 --- a/app/models/channel/sendmail.rb +++ b/app/models/channel/sendmail.rb @@ -1,7 +1,7 @@ # Copyright (C) 2012-2014 Zammad Foundation, http://zammad-foundation.org/ class Channel::Sendmail - def send(attr, channel, notification = false) + def send(attr, _channel, notification = false) # return if we run import mode return if Setting.get('import_mode') diff --git a/app/models/channel/twitter2.rb b/app/models/channel/twitter2.rb index 82b800e81..ca4c62860 100644 --- a/app/models/channel/twitter2.rb +++ b/app/models/channel/twitter2.rb @@ -137,7 +137,7 @@ class Channel::TWITTER2 [user, ticket, article] end - def fetch_user_create(tweet, sender) + def fetch_user_create(_tweet, sender) # create sender in db # puts tweet.inspect # user = User.where( :login => tweet.sender.screen_name ).first @@ -180,7 +180,7 @@ class Channel::TWITTER2 user end - def fetch_ticket_create(user, tweet, sender, channel, group) + def fetch_ticket_create(user, tweet, _sender, _channel, group) #Rails.logger.info '+++++++++++++++++++++++++++' + tweet.inspect # check if ticket exists @@ -237,7 +237,7 @@ class Channel::TWITTER2 ticket end - def fetch_article_create( user, ticket, tweet, sender ) + def fetch_article_create( _user, ticket, tweet, sender ) # find if record already exists article = Ticket::Article.where( message_id: tweet.id.to_s ).first @@ -268,7 +268,7 @@ class Channel::TWITTER2 end - def send(attr, notification = false) + def send(attr, _notification = false) # Rails.logger.debug('tweeeeettttt!!!!!!') channel = Channel.where( area: 'Twitter::Inbound', active: true ).first diff --git a/app/models/observer/ticket/notification.rb b/app/models/observer/ticket/notification.rb index 62fd1343a..29092b912 100644 --- a/app/models/observer/ticket/notification.rb +++ b/app/models/observer/ticket/notification.rb @@ -158,7 +158,7 @@ class Observer::Ticket::Notification < ActiveRecord::Observer EventBuffer.add(e) end - def after_update(record) + def after_update(_record) # return if we run import mode return if Setting.get('import_mode') diff --git a/app/models/observer/ticket/notification/background_job.rb b/app/models/observer/ticket/notification/background_job.rb index 3c68b4947..77af28320 100644 --- a/app/models/observer/ticket/notification/background_job.rb +++ b/app/models/observer/ticket/notification/background_job.rb @@ -225,7 +225,7 @@ class Observer::Ticket::Notification::BackgroundJob changes end - def template_create(user, ticket, article, ticket_changes) + def template_create(user, ticket, article, _ticket_changes) article_content = '' if article article_content = '<snip> @@ -348,7 +348,7 @@ Changes:
template end - def template_header(user) + def template_header(_user) '