From 8117cfb3aa207798c07df9ffc2fc2ce900f7f874 Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Tue, 18 Apr 2017 20:04:40 +0200 Subject: [PATCH] =?UTF-8?q?Replaced=20autocomplete=3D=E2=80=9Coff=E2=80=9D?= =?UTF-8?q?=20with=20autocomplete=3D"new-password=E2=80=9D.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../_application_controller_form.coffee | 5 +++- .../app/controllers/_channel/email.coffee | 10 +++---- .../app/controllers/getting_started.coffee | 6 ++--- app/assets/javascripts/app/models/user.coffee | 2 +- .../views/agent_ticket_view/content.jst.eco | 2 +- .../channel/email_account_wizard.jst.eco | 26 +++++-------------- .../channel/email_notification_wizard.jst.eco | 7 +---- .../app/views/facebook/app_config.jst.eco | 4 +-- .../app/views/generic/admin/index.jst.eco | 4 +-- .../app/views/generic/autocompletion.jst.eco | 2 +- .../views/generic/object_search/input.jst.eco | 2 +- .../views/generic/searchable_select.jst.eco | 4 +-- .../app/views/getting_started/admin.jst.eco | 2 +- .../app/views/getting_started/agent.jst.eco | 6 ++--- .../app/views/getting_started/email.jst.eco | 26 +++++-------------- .../email_notification.jst.eco | 8 ++---- .../app/views/telegram/bot_add.jst.eco | 4 +-- .../app/views/telegram/bot_edit.jst.eco | 4 +-- .../app/views/twitter/app_config.jst.eco | 4 +-- .../app/views/widget/invite_user.jst.eco | 6 +---- .../app/views/widget/text_module.jst.eco | 2 +- 21 files changed, 51 insertions(+), 85 deletions(-) diff --git a/app/assets/javascripts/app/controllers/_application_controller_form.coffee b/app/assets/javascripts/app/controllers/_application_controller_form.coffee index a8511625d..8115dcd24 100644 --- a/app/assets/javascripts/app/controllers/_application_controller_form.coffee +++ b/app/assets/javascripts/app/controllers/_application_controller_form.coffee @@ -226,7 +226,10 @@ class App.ControllerForm extends App.Controller # set autocomplete option if attribute.autocomplete is undefined - attribute.autocomplete = '' + if attribute.type is 'hidden' + attribute.autocomplete = '' + else + attribute.autocomplete = 'autocomplete="new-password"' else attribute.autocomplete = 'autocomplete="' + attribute.autocomplete + '"' diff --git a/app/assets/javascripts/app/controllers/_channel/email.coffee b/app/assets/javascripts/app/controllers/_channel/email.coffee index f37c3e2fa..5eb14a75f 100644 --- a/app/assets/javascripts/app/controllers/_channel/email.coffee +++ b/app/assets/javascripts/app/controllers/_channel/email.coffee @@ -533,8 +533,8 @@ class App.ChannelEmailAccountWizard extends App.WizardModal # base configureAttributesBase = [ - { name: 'realname', display: 'Organization & Department Name', tag: 'input', type: 'text', limit: 160, null: false, placeholder: 'Organization Support', autocomplete: 'off' }, - { name: 'email', display: 'Email', tag: 'input', type: 'email', limit: 120, null: false, placeholder: 'support@example.com', autocapitalize: false, autocomplete: 'off' }, + { name: 'realname', display: 'Organization & Department Name', tag: 'input', type: 'text', limit: 160, null: false, placeholder: 'Organization Support', autocomplete: 'new-password' }, + { name: 'email', display: 'Email', tag: 'input', type: 'email', limit: 120, null: false, placeholder: 'support@example.com', autocapitalize: false, autocomplete: 'new-password' }, { name: 'password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: false, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'group_id', display: 'Destination Group', tag: 'select', null: false, relation: 'Group', nulloption: true }, ] @@ -564,7 +564,7 @@ class App.ChannelEmailAccountWizard extends App.WizardModal configureAttributesInbound = [ { name: 'adapter', display: 'Type', tag: 'select', multiple: false, null: false, options: @channelDriver.email.inbound }, { name: 'options::host', display: 'Host', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false }, - { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autocomplete: 'off', }, + { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autocomplete: 'new-password', }, { name: 'options::password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: false, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'options::ssl', display: 'SSL', tag: 'boolean', null: true, options: { true: 'yes', false: 'no' }, default: true, translate: true, item_class: 'formGroup--halfSize' }, { name: 'options::port', display: 'Port', tag: 'input', type: 'text', limit: 6, null: true, autocapitalize: false, default: '993', item_class: 'formGroup--halfSize' }, @@ -618,7 +618,7 @@ class App.ChannelEmailAccountWizard extends App.WizardModal if adapter is 'smtp' configureAttributesOutbound = [ { name: 'options::host', display: 'Host', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autofocus: true }, - { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'off', }, + { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password', }, { name: 'options::password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'options::port', display: 'Port', tag: 'input', type: 'text', limit: 6, null: true, autocapitalize: false }, ] @@ -932,7 +932,7 @@ class App.ChannelEmailNotificationWizard extends App.WizardModal if adapter is 'smtp' configureAttributesOutbound = [ { name: 'options::host', display: 'Host', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autofocus: true }, - { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'off' }, + { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password' }, { name: 'options::password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'options::port', display: 'Port', tag: 'input', type: 'text', limit: 6, null: true, autocapitalize: false }, ] diff --git a/app/assets/javascripts/app/controllers/getting_started.coffee b/app/assets/javascripts/app/controllers/getting_started.coffee index c574e0e4e..c7d236267 100644 --- a/app/assets/javascripts/app/controllers/getting_started.coffee +++ b/app/assets/javascripts/app/controllers/getting_started.coffee @@ -450,7 +450,7 @@ class EmailNotification extends App.WizardFullScreen if adapter is 'smtp' configureAttributesOutbound = [ { name: 'options::host', display: 'Host', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autofocus: true }, - { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'off' }, + { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password' }, { name: 'options::password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'options::port', display: 'Port', tag: 'input', type: 'text', limit: 6, null: true, autocapitalize: false }, ] @@ -673,7 +673,7 @@ class ChannelEmail extends App.WizardFullScreen configureAttributesInbound = [ { name: 'adapter', display: 'Type', tag: 'select', multiple: false, null: false, options: @channelDriver.email.inbound }, { name: 'options::host', display: 'Host', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false }, - { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autocomplete: 'off', }, + { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autocomplete: 'new-password', }, { name: 'options::password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: false, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'options::ssl', display: 'SSL', tag: 'boolean', null: true, options: { true: 'yes', false: 'no' }, default: true, translate: true, item_class: 'formGroup--halfSize' }, { name: 'options::port', display: 'Port', tag: 'input', type: 'text', limit: 6, null: true, autocapitalize: false, default: '993', item_class: 'formGroup--halfSize' }, @@ -725,7 +725,7 @@ class ChannelEmail extends App.WizardFullScreen if adapter is 'smtp' configureAttributesOutbound = [ { name: 'options::host', display: 'Host', tag: 'input', type: 'text', limit: 120, null: false, autocapitalize: false, autofocus: true }, - { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'off', }, + { name: 'options::user', display: 'User', tag: 'input', type: 'text', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password', }, { name: 'options::password', display: 'Password', tag: 'input', type: 'password', limit: 120, null: true, autocapitalize: false, autocomplete: 'new-password', single: true }, { name: 'options::port', display: 'Port', tag: 'input', type: 'text', limit: 6, null: true, autocapitalize: false }, ] diff --git a/app/assets/javascripts/app/models/user.coffee b/app/assets/javascripts/app/models/user.coffee index 57f6c69f3..ae3641619 100644 --- a/app/assets/javascripts/app/models/user.coffee +++ b/app/assets/javascripts/app/models/user.coffee @@ -10,7 +10,7 @@ class App.User extends App.Model { name: 'lastname', display: 'Lastname', tag: 'input', type: 'text', limit: 100, null: false, signup: true, info: true, invite_agent: true, invite_customer: true }, { name: 'email', display: 'Email', tag: 'input', type: 'email', limit: 100, null: false, signup: true, info: true, invite_agent: true, invite_customer: true }, { name: 'organization_id', display: 'Organization', tag: 'select', multiple: false, nulloption: true, null: true, relation: 'Organization', signup: false, info: true, invite_customer: true }, - { name: 'password', display: 'Password', tag: 'input', type: 'password', limit: 50, null: true, autocomplete: 'off', signup: true, }, + { name: 'password', display: 'Password', tag: 'input', type: 'password', limit: 50, null: true, autocomplete: 'new-password', signup: true, }, { name: 'note', display: 'Note', tag: 'textarea', note: 'Notes are visible to agents only, never to customers.', limit: 250, null: true, info: true, invite_customer: true }, { name: 'role_ids', display: 'Permissions', tag: 'user_permission', null: false, invite_agent: true, invite_customer: true, item_class: 'checkbox' }, { name: 'active', display: 'Active', tag: 'active', default: true }, diff --git a/app/assets/javascripts/app/views/agent_ticket_view/content.jst.eco b/app/assets/javascripts/app/views/agent_ticket_view/content.jst.eco index 23fdcbf1c..6fe1c1c7e 100644 --- a/app/assets/javascripts/app/views/agent_ticket_view/content.jst.eco +++ b/app/assets/javascripts/app/views/agent_ticket_view/content.jst.eco @@ -1,6 +1,6 @@
-

<%- @T( @overview.name ) %>

+

<%- @T(@overview.name) %>

<% if @edit: %> diff --git a/app/assets/javascripts/app/views/channel/email_account_wizard.jst.eco b/app/assets/javascripts/app/views/channel/email_account_wizard.jst.eco index 2a6ef017d..d14be080c 100644 --- a/app/assets/javascripts/app/views/channel/email_account_wizard.jst.eco +++ b/app/assets/javascripts/app/views/channel/email_account_wizard.jst.eco @@ -1,10 +1,6 @@
-
- - - - +
<%- @Icon('diagonal-cross') %> @@ -27,7 +23,7 @@
-
+
<%- @Icon('diagonal-cross') %> @@ -44,7 +40,7 @@
-
+
<%- @Icon('diagonal-cross') %> @@ -61,7 +57,7 @@
-
+
<%- @Icon('diagonal-cross') %> @@ -79,11 +75,7 @@
-
- - - - +
<%- @Icon('diagonal-cross') %> @@ -106,7 +98,7 @@
-
+
<%- @Icon('diagonal-cross') %> @@ -129,11 +121,7 @@
-
- - - - +
<%- @Icon('diagonal-cross') %> diff --git a/app/assets/javascripts/app/views/channel/email_notification_wizard.jst.eco b/app/assets/javascripts/app/views/channel/email_notification_wizard.jst.eco index 400d954e6..130b3674f 100644 --- a/app/assets/javascripts/app/views/channel/email_notification_wizard.jst.eco +++ b/app/assets/javascripts/app/views/channel/email_notification_wizard.jst.eco @@ -34,12 +34,7 @@
-
- - - - -
+
<%- @Icon('diagonal-cross') %>
diff --git a/app/assets/javascripts/app/views/facebook/app_config.jst.eco b/app/assets/javascripts/app/views/facebook/app_config.jst.eco index 625d9bd8c..92009d7ba 100644 --- a/app/assets/javascripts/app/views/facebook/app_config.jst.eco +++ b/app/assets/javascripts/app/views/facebook/app_config.jst.eco @@ -9,7 +9,7 @@
- +
@@ -17,7 +17,7 @@
- +

<%- @T('Your callback URL') %>

diff --git a/app/assets/javascripts/app/views/generic/admin/index.jst.eco b/app/assets/javascripts/app/views/generic/admin/index.jst.eco index 25b61658b..19012867a 100644 --- a/app/assets/javascripts/app/views/generic/admin/index.jst.eco +++ b/app/assets/javascripts/app/views/generic/admin/index.jst.eco @@ -1,6 +1,6 @@
-

<%- @T( @head ) %> <%- @T( 'Management' ) %>

+

<%- @T(@head) %> <%- @T('Management') %>

<% if @showDescription: %> @@ -8,7 +8,7 @@ <% end %> <% if @buttons: %> <% for button in @buttons: %> - <%- @T( button.name ) %> + <%- @T(button.name) %> <% end %> <% end %>
diff --git a/app/assets/javascripts/app/views/generic/autocompletion.jst.eco b/app/assets/javascripts/app/views/generic/autocompletion.jst.eco index a63f5e90e..574b091a7 100644 --- a/app/assets/javascripts/app/views/generic/autocompletion.jst.eco +++ b/app/assets/javascripts/app/views/generic/autocompletion.jst.eco @@ -1,3 +1,3 @@ /> - <%= @attribute.autofocus %> <%- @attribute.autocapitalize %> <% if @attribute.placeholder: %>placeholder="<%- @Ti(@attribute.placeholder) %>"<% end %>/> + <%= @attribute.autofocus %> <%- @attribute.autocapitalize %> <% if @attribute.placeholder: %>placeholder="<%- @Ti(@attribute.placeholder) %>"<% end %> autocomplete="new-password"/> diff --git a/app/assets/javascripts/app/views/generic/object_search/input.jst.eco b/app/assets/javascripts/app/views/generic/object_search/input.jst.eco index c3a41cf7c..3021dc709 100644 --- a/app/assets/javascripts/app/views/generic/object_search/input.jst.eco +++ b/app/assets/javascripts/app/views/generic/object_search/input.jst.eco @@ -3,7 +3,7 @@ <% if @attribute.multiple: %> <%- @tokens %> <% end %> - + role="textbox" aria-autocomplete="list" value="<%= @name %>" aria-haspopup="true"> <% if @attribute.disableCreateObject isnt true: %><%- @Icon('arrow-down', 'dropdown-arrow') %><% end %>
diff --git a/app/assets/javascripts/app/views/generic/searchable_select.jst.eco b/app/assets/javascripts/app/views/generic/searchable_select.jst.eco index 4ed94fe1a..2cdbba9a5 100644 --- a/app/assets/javascripts/app/views/generic/searchable_select.jst.eco +++ b/app/assets/javascripts/app/views/generic/searchable_select.jst.eco @@ -11,8 +11,8 @@ class="searchableSelect-main form-control js-input<%= " #{ @class }" if @class %>" placeholder="<%= @placeholder %>" value="<%= @valueName %>" - autocomplete="off" - > + autocomplete="new-password" + >
diff --git a/app/assets/javascripts/app/views/getting_started/admin.jst.eco b/app/assets/javascripts/app/views/getting_started/admin.jst.eco index d00f44ad6..e11a56bad 100644 --- a/app/assets/javascripts/app/views/getting_started/admin.jst.eco +++ b/app/assets/javascripts/app/views/getting_started/admin.jst.eco @@ -1,6 +1,6 @@
<%- @Icon('full-logo', 'wizard-logo') %> - +

<%- @T('Administrator Account') %>

diff --git a/app/assets/javascripts/app/views/getting_started/agent.jst.eco b/app/assets/javascripts/app/views/getting_started/agent.jst.eco index 220782847..5bf64c9cb 100644 --- a/app/assets/javascripts/app/views/getting_started/agent.jst.eco +++ b/app/assets/javascripts/app/views/getting_started/agent.jst.eco @@ -1,12 +1,12 @@
<%- @Icon('full-logo', 'wizard-logo') %> - +

<%- @T('Invite Colleagues') %>

- <%- @T( 'Continue' ) %> - + <%- @T('Continue') %> +
diff --git a/app/assets/javascripts/app/views/getting_started/email.jst.eco b/app/assets/javascripts/app/views/getting_started/email.jst.eco index 4dd12b351..b82d01e8a 100644 --- a/app/assets/javascripts/app/views/getting_started/email.jst.eco +++ b/app/assets/javascripts/app/views/getting_started/email.jst.eco @@ -1,11 +1,7 @@
<%- @Icon('full-logo', 'wizard-logo') %> -
- - - - +

<%- @T('Email Account') %>

@@ -13,11 +9,11 @@
- +
- +
@@ -66,11 +62,7 @@
-
- - - - +

<%- @T('Email Inbound') %>

@@ -79,7 +71,7 @@
<%- @T('Go Back') %> - +
@@ -98,11 +90,7 @@
-
- - - - +

<%- @T('Email Outbound') %>

@@ -112,7 +100,7 @@
<%- @T('Go Back') %> - +
diff --git a/app/assets/javascripts/app/views/getting_started/email_notification.jst.eco b/app/assets/javascripts/app/views/getting_started/email_notification.jst.eco index 4dba5dbb9..383299bc0 100644 --- a/app/assets/javascripts/app/views/getting_started/email_notification.jst.eco +++ b/app/assets/javascripts/app/views/getting_started/email_notification.jst.eco @@ -1,11 +1,7 @@
<%- @Icon('full-logo', 'wizard-logo') %> -
- - - - +

<%- @T('Email Notification') %>

@@ -15,7 +11,7 @@
<%- @T('Go Back') %> - +
diff --git a/app/assets/javascripts/app/views/telegram/bot_add.jst.eco b/app/assets/javascripts/app/views/telegram/bot_add.jst.eco index 4626b023f..7d47c4335 100644 --- a/app/assets/javascripts/app/views/telegram/bot_add.jst.eco +++ b/app/assets/javascripts/app/views/telegram/bot_add.jst.eco @@ -9,7 +9,7 @@
- +

<%- @T('Settings') %>

@@ -18,7 +18,7 @@
- +
diff --git a/app/assets/javascripts/app/views/telegram/bot_edit.jst.eco b/app/assets/javascripts/app/views/telegram/bot_edit.jst.eco index 07b6de1c2..39b9b61a0 100644 --- a/app/assets/javascripts/app/views/telegram/bot_edit.jst.eco +++ b/app/assets/javascripts/app/views/telegram/bot_edit.jst.eco @@ -6,7 +6,7 @@
- +

<%- @T('Settings') %>

@@ -15,7 +15,7 @@
- +
diff --git a/app/assets/javascripts/app/views/twitter/app_config.jst.eco b/app/assets/javascripts/app/views/twitter/app_config.jst.eco index 92f322b9c..d7b8a1e25 100644 --- a/app/assets/javascripts/app/views/twitter/app_config.jst.eco +++ b/app/assets/javascripts/app/views/twitter/app_config.jst.eco @@ -9,7 +9,7 @@
- +
@@ -17,7 +17,7 @@
- +

<%- @T('Your callback URL') %>

diff --git a/app/assets/javascripts/app/views/widget/invite_user.jst.eco b/app/assets/javascripts/app/views/widget/invite_user.jst.eco index a1f487c24..4c2aa9c70 100644 --- a/app/assets/javascripts/app/views/widget/invite_user.jst.eco +++ b/app/assets/javascripts/app/views/widget/invite_user.jst.eco @@ -1,10 +1,6 @@
-
- - - - +
<%- @Icon('diagonal-cross') %> diff --git a/app/assets/javascripts/app/views/widget/text_module.jst.eco b/app/assets/javascripts/app/views/widget/text_module.jst.eco index ecd943f64..5c3f4d4af 100644 --- a/app/assets/javascripts/app/views/widget/text_module.jst.eco +++ b/app/assets/javascripts/app/views/widget/text_module.jst.eco @@ -4,7 +4,7 @@ <%- @T( 'Search' ) %>
--> - + ×