Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Follow up c5659600f3 - Fixes #3726 - It should be possible to show attributes which are configured shown false.

Browse source
This commit is contained in:
Rolf Schmidt 2021-09-10 10:16:30 +01:00 committed by Thorsten Eckel
parent f1cbb9a0c7
commit 854b936f0d
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/app/views/generic/attribute.jst.eco
View file

@ -1,4 +1,4 @@
<div data-attribute-name="<%= @attribute.name %>" class="<%= @attribute.tag %> form-group<%= " form-group--block" if @attribute.style == 'block' %><%= " #{ @attribute.item_class }" if @attribute.item_class %><%= " is-required" if !@attribute.null %><%= " is-hidden is-removed hide" if @attribute.shown == false %>"<%= " data-width=#{ @attribute.grid_width }" if @attribute.grid_width %>> <div data-attribute-name="<%= @attribute.name %>" class="<%= @attribute.tag %> form-group<%= " form-group--block" if @attribute.style == 'block' %><%= " #{ @attribute.item_class }" if @attribute.item_class %><%= " is-required" if !@attribute.null %><%= " is-hidden hide" if @attribute.shown == false %>"<%= " data-width=#{ @attribute.grid_width }" if @attribute.grid_width %>>
<% if @attribute.style == 'block': %> <% if @attribute.style == 'block': %>
<h2> <h2>
<% end %> <% end %>

2
app/models/core_workflow/attributes.rb
View file

@ -77,7 +77,7 @@ class CoreWorkflow::Attributes
result[ attribute[:name] ] = if @payload['request_id'] == 'ChecksCoreWorkflow.validate_workflows' result[ attribute[:name] ] = if @payload['request_id'] == 'ChecksCoreWorkflow.validate_workflows'
'show' 'show'
else else
screen_value(attribute, 'shown') == false ? 'remove' : 'show' screen_value(attribute, 'shown') == false ? 'hide' : 'show'
end end
end end
end end

2
spec/system/ticket/create_spec.rb
View file

@ -531,7 +531,7 @@ RSpec.describe 'Ticket Create', type: :system do
end end
it 'does not show the field' do it 'does not show the field' do
expect(page).to have_css("div[data-attribute-name='#{field_name}'].is-hidden.is-removed", visible: :hidden) expect(page).to have_css("div[data-attribute-name='#{field_name}'].is-hidden", visible: :hidden)
end end
end end
end end