From 661c83d574063033ce097c09db5e615a82d8af75 Mon Sep 17 00:00:00 2001
From: Felix Niklas <mrflix@gmail.com>
Date: Mon, 14 Mar 2016 16:01:04 +0100
Subject: [PATCH 1/4] fix coffee lint

---
 .../app/controllers/_application_controller_table.coffee        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/app/controllers/_application_controller_table.coffee b/app/assets/javascripts/app/controllers/_application_controller_table.coffee
index a9656dcaa..a297a0424 100644
--- a/app/assets/javascripts/app/controllers/_application_controller_table.coffee
+++ b/app/assets/javascripts/app/controllers/_application_controller_table.coffee
@@ -45,7 +45,7 @@ class App.ControllerTable extends App.Controller
           helper = tr.clone()
           helper.children().each (index) ->
             # Set helper cell sizes to match the original sizes
-            $(this).width( originals.eq(index).outerWidth() )
+            $(@).width( originals.eq(index).outerWidth() )
           return helper
         update:               @dndCallback
       @el.find('table > tbody').sortable(dndOptions)

From b0ac1ddc1e8e47a5e0af756b90093b4a3b29fe12 Mon Sep 17 00:00:00 2001
From: Felix Niklas <mrflix@gmail.com>
Date: Mon, 14 Mar 2016 16:44:28 +0100
Subject: [PATCH 2/4] load application.css for all media

---
 .../app/views/generic/table.jst.eco           | 12 +++----
 app/assets/stylesheets/print.scss             | 34 ++++++-------------
 app/assets/stylesheets/zammad.scss            |  5 +++
 app/views/layouts/application.html.erb        |  4 +--
 4 files changed, 23 insertions(+), 32 deletions(-)

diff --git a/app/assets/javascripts/app/views/generic/table.jst.eco b/app/assets/javascripts/app/views/generic/table.jst.eco
index 6bbf33c01..6b52e354d 100644
--- a/app/assets/javascripts/app/views/generic/table.jst.eco
+++ b/app/assets/javascripts/app/views/generic/table.jst.eco
@@ -2,10 +2,10 @@
   <thead>
     <tr>
     <% if @sortable: %>
-      <th style="width: 36px"></th>
+      <th style="width: 36px" class="table-draggable"></th>
     <% end %>
     <% if @checkbox: %>
-      <th style="width: 40px" class="no-padding">
+      <th style="width: 40px" class="table-checkbox">
         <label class="checkbox-replacement">
           <input type="checkbox" value="" name="bulk_all">
           <%- @Icon('checkbox', 'icon-unchecked') %>
@@ -14,7 +14,7 @@
       </th>
     <% end %>
     <% if @radio: %>
-      <th style="width: 40px" class="no-padding"></th>
+      <th style="width: 40px" class="table-radio"></th>
     <% end %>
     <% for item, i in @header: %>
       <th class="js-tableHead<%= " #{ item.className }" if item.className %><%= " align-#{ item.align }" if item.align %>" style="width:<%= item.displayWidth %>px" data-column-key="<%= item.name %>">
@@ -53,10 +53,10 @@
   <% position++ %>
   <tr class="item<%= ' is-inactive' if object.active is false %>" data-id="<%= object.id %>" data-position="<%= position %>" >
     <% if @sortable: %>
-      <td><%- @Icon('draggable') %></td>
+      <td class="table-draggable"><%- @Icon('draggable') %></td>
     <% end %>
     <% if @checkbox: %>
-      <td class="no-padding">
+      <td class="table-checkbox">
         <label class="checkbox-replacement">
           <input type="checkbox" value="<%= object.id %>" name="bulk">
           <%- @Icon('checkbox', 'icon-unchecked') %>
@@ -65,7 +65,7 @@
       </td>
     <% end %>
     <% if @radio: %>
-      <td class="no-padding">
+      <td class="table-radio">
         <label class="radio-replacement">
           <input type="radio" value="<%= object.id %>" name="radio">
           <%- @Icon('radio', 'icon-unchecked') %>
diff --git a/app/assets/stylesheets/print.scss b/app/assets/stylesheets/print.scss
index e9ff01dc1..9bb773c0a 100644
--- a/app/assets/stylesheets/print.scss
+++ b/app/assets/stylesheets/print.scss
@@ -1,15 +1,14 @@
 #app > *:not(.content):not(.active),
-#app > .hide,
-.icon,
-.btn,
-.avatar {
+#app > .hide {
   display: none;
 }
 
 .table {
-  margin: 1em 0;
-  border: 1px solid;
-  padding: 1em;
+  border: 1px solid hsl(0,0%,90%);
+}
+
+.table thead tr {
+  border-bottom: 1px solid hsl(0,0%,90%);
 }
 
 /*
@@ -32,7 +31,8 @@
 
 .bulkAction,
 .overviews .checkbox-replacement,
-.overviews .overview-header {
+.overviews .overview-header,
+.table-checkbox {
   display: none;
 }
 
@@ -53,22 +53,8 @@
   display: none;
 }
 
-.ticket-title {
-  font-size: 2em;
-}
-
-.ticket-article-item {
-  margin: 1em 0;
-  border: 1px solid;
-  padding: 1em;
-}
-
-.article-meta-value {
-  font-weight: bold;
-}
-
-.article-content {
-  margin: 0.5em 0;
+.tabsSidebar-sidebarSpacer {
+  margin-right: 0;
 }
 
 .article-meta .article-meta-key {
diff --git a/app/assets/stylesheets/zammad.scss b/app/assets/stylesheets/zammad.scss
index d39064c56..b86377e42 100644
--- a/app/assets/stylesheets/zammad.scss
+++ b/app/assets/stylesheets/zammad.scss
@@ -930,6 +930,11 @@ th.align-right {
   fill: hsl(240,1%,77%);
 }
 
+.table-checkbox,
+.table-radio {
+  padding: 0 !important;
+}
+
 .table .table-sort-arrow {
   opacity: 1;
   fill: hsl(206,7%,33%);
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
index 880ec7899..61f9dbbea 100644
--- a/app/views/layouts/application.html.erb
+++ b/app/views/layouts/application.html.erb
@@ -3,8 +3,8 @@
 <head>
   <meta charset="utf-8">
   <title><%= Setting.get('product_name') %></title>
-  <%= stylesheet_link_tag    "application" %>
-  <%= stylesheet_link_tag    "application-print", :media => 'print' %>
+  <%= stylesheet_link_tag "application", :media => 'all' %>
+  <%= stylesheet_link_tag "application-print", :media => 'print' %>
   <% if Rails.configuration.assets.debug %>
   <%= javascript_include_tag "application" %>
   <% else %>

From 087e83940ff379f7a96024efc7efbe4a44bfa48c Mon Sep 17 00:00:00 2001
From: Felix Niklas <mrflix@gmail.com>
Date: Mon, 14 Mar 2016 16:46:43 +0100
Subject: [PATCH 3/4] fix notification remove overflow bug

---
 .../controllers/widget/online_notification.coffee  | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/app/assets/javascripts/app/controllers/widget/online_notification.coffee b/app/assets/javascripts/app/controllers/widget/online_notification.coffee
index 5fdb749f3..dba5a50a7 100644
--- a/app/assets/javascripts/app/controllers/widget/online_notification.coffee
+++ b/app/assets/javascripts/app/controllers/widget/online_notification.coffee
@@ -113,9 +113,7 @@ class App.OnlineNotificationWidget extends App.Controller
       processData: true
     )
 
-  onShow: =>
-    @updateContent()
-
+  updateHeight: =>
     # set height of notification popover
     notificationsContainer  = $('.js-notificationsContainer')
     heightApp               = $('#app').height()
@@ -131,6 +129,10 @@ class App.OnlineNotificationWidget extends App.Controller
 
     notificationsContainer.find('.popover-content').css('height', "#{heightPopoverContentNew}px")
 
+  onShow: =>
+    @updateContent()
+    @updateHeight()
+
     # mark all notifications as read
     notificationsContainer.find('.js-markAllAsRead').on('click', (e) =>
       e.preventDefault()
@@ -221,7 +223,7 @@ class App.OnlineNotificationWidget extends App.Controller
       row = $(e.target).closest('.activity-entry')
       id = row.data('id')
       App.OnlineNotification.destroy(id)
-      @resetHeight()
+      @updateHeight()
     )
 
   createContainer: =>
@@ -254,7 +256,3 @@ class App.OnlineNotificationWidget extends App.Controller
     @counterUpdate(0)
     @toggle.popover('destroy')
 
-  resetHeight: ->
-    notificationsContainer = $('.js-notificationsContainer')
-    notificationsContainer.find('.popover-content').css('height', 'auto')
-

From b8bf9da248714906cf28dde5ca04244e9ac649aa Mon Sep 17 00:00:00 2001
From: Felix Niklas <mrflix@gmail.com>
Date: Mon, 14 Mar 2016 16:53:59 +0100
Subject: [PATCH 4/4] coffelint fix

---
 .../app/controllers/widget/online_notification.coffee           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/app/controllers/widget/online_notification.coffee b/app/assets/javascripts/app/controllers/widget/online_notification.coffee
index dba5a50a7..386a13c45 100644
--- a/app/assets/javascripts/app/controllers/widget/online_notification.coffee
+++ b/app/assets/javascripts/app/controllers/widget/online_notification.coffee
@@ -113,7 +113,7 @@ class App.OnlineNotificationWidget extends App.Controller
       processData: true
     )
 
-  updateHeight: =>
+  updateHeight: ->
     # set height of notification popover
     notificationsContainer  = $('.js-notificationsContainer')
     heightApp               = $('#app').height()