diff --git a/app/models/application_model/assets.rb b/app/models/application_model/assets.rb index 2fed16cbc..1ce5cfd3d 100644 --- a/app/models/application_model/assets.rb +++ b/app/models/application_model/assets.rb @@ -6,7 +6,7 @@ module ApplicationModel::Assets get all assets / related models for this user user = User.find(123) - result = user.assets( assets_if_exists ) + result = user.assets(assets_if_exists) returns @@ -19,13 +19,15 @@ returns =end - def assets (data = {}) + def assets(data = {}) - if !data[ self.class.to_app_model ] - data[ self.class.to_app_model ] = {} + app_model = self.class.to_app_model + + if !data[ app_model ] + data[ app_model ] = {} end - if !data[ self.class.to_app_model ][ id ] - data[ self.class.to_app_model ][ id ] = attributes_with_associations + if !data[ app_model ][ id ] + data[ app_model ][ id ] = attributes_with_associations end return data if !self['created_by_id'] && !self['updated_by_id'] diff --git a/app/models/channel/assets.rb b/app/models/channel/assets.rb index 951770e70..be20de0a7 100644 --- a/app/models/channel/assets.rb +++ b/app/models/channel/assets.rb @@ -8,7 +8,7 @@ class Channel get all assets / related models for this channel channel = Channel.find(123) - result = channel.assets( assets_if_exists ) + result = channel.assets(assets_if_exists) returns @@ -21,12 +21,14 @@ returns =end - def assets (data = {}) + def assets(data = {}) - if !data[ self.class.to_app_model ] - data[ self.class.to_app_model ] = {} + app_model = self.class.to_app_model + + if !data[ app_model ] + data[ app_model ] = {} end - if !data[ self.class.to_app_model ][ id ] + if !data[ app_model ][ id ] attributes = attributes_with_associations # remove passwords if use is no admin diff --git a/app/models/history/assets.rb b/app/models/history/assets.rb index fbbdda635..379943414 100644 --- a/app/models/history/assets.rb +++ b/app/models/history/assets.rb @@ -8,7 +8,7 @@ class History get all assets / related models for this history entry history = History.find(123) - result = history.assets( assets_if_exists ) + result = history.assets(assets_if_exists) returns @@ -21,9 +21,11 @@ returns =end - def assets (data) + def assets(data) - if !data[ User.to_app_model ] || !data[ User.to_app_model ][ self['created_by_id'] ] + app_model = User.to_app_model + + if !data[ app_model ] || !data[ app_model ][ self['created_by_id'] ] user = User.lookup(id: self['created_by_id']) if user data = user.assets(data) diff --git a/app/models/job/assets.rb b/app/models/job/assets.rb index 3719b6211..d13fa1278 100644 --- a/app/models/job/assets.rb +++ b/app/models/job/assets.rb @@ -21,16 +21,18 @@ returns =end - def assets (data) + def assets(data) - if !data[ Job.to_app_model ] - data[ Job.to_app_model ] = {} + app_model = Job.to_app_model + + if !data[ app_model ] + data[ app_model ] = {} end if !data[ User.to_app_model ] data[ User.to_app_model ] = {} end - if !data[ Job.to_app_model ][ id ] - data[ Job.to_app_model ][ id ] = attributes_with_associations + if !data[ app_model ][ id ] + data[ app_model ][ id ] = attributes_with_associations data = assets_of_selector('condition', data) data = assets_of_selector('perform', data) end diff --git a/app/models/organization/assets.rb b/app/models/organization/assets.rb index 79f600c2f..6aa8172ce 100644 --- a/app/models/organization/assets.rb +++ b/app/models/organization/assets.rb @@ -21,20 +21,23 @@ returns =end - def assets (data) + def assets(data) - if !data[ Organization.to_app_model ] - data[ Organization.to_app_model ] = {} + app_model_organization = Organization.to_app_model + app_model_user = User.to_app_model + + if !data[ app_model_organization ] + data[ app_model_organization ] = {} end - if !data[ User.to_app_model ] - data[ User.to_app_model ] = {} + if !data[ app_model_user ] + data[ app_model_user ] = {} end - if !data[ Organization.to_app_model ][ id ] + if !data[ app_model_organization ][ id ] local_attributes = attributes # set temp. current attributes to assets pool to prevent # loops, will be updated with lookup attributes later - data[ Organization.to_app_model ][ id ] = local_attributes + data[ app_model_organization ][ id ] = local_attributes # get organizations key = "Organization::member_ids::#{id}" @@ -46,18 +49,18 @@ returns local_attributes['member_ids'] = local_member_ids if local_member_ids local_member_ids.each { |local_user_id| - next if data[ User.to_app_model ][ local_user_id ] + next if data[ app_model_user ][ local_user_id ] user = User.lookup(id: local_user_id) next if !user data = user.assets(data) } end - data[ Organization.to_app_model ][ id ] = local_attributes + data[ app_model_organization ][ id ] = local_attributes end %w(created_by_id updated_by_id).each { |local_user_id| next if !self[ local_user_id ] - next if data[ User.to_app_model ][ self[ local_user_id ] ] + next if data[ app_model_user ][ self[ local_user_id ] ] user = User.lookup(id: self[ local_user_id ]) next if !user data = user.assets(data) diff --git a/app/models/overview/assets.rb b/app/models/overview/assets.rb index d29e8718f..72927b0c2 100644 --- a/app/models/overview/assets.rb +++ b/app/models/overview/assets.rb @@ -21,19 +21,22 @@ returns =end - def assets (data) + def assets(data) - if !data[ Overview.to_app_model ] - data[ Overview.to_app_model ] = {} + app_model_overview = Overview.to_app_model + app_model_user = User.to_app_model + + if !data[ app_model_overview ] + data[ app_model_overview ] = {} end - if !data[ User.to_app_model ] - data[ User.to_app_model ] = {} + if !data[ app_model_user ] + data[ app_model_user ] = {} end - if !data[ Overview.to_app_model ][ id ] - data[ Overview.to_app_model ][ id ] = attributes_with_associations + if !data[ app_model_overview ][ id ] + data[ app_model_overview ][ id ] = attributes_with_associations if user_ids user_ids.each { |local_user_id| - next if data[ User.to_app_model ][ local_user_id ] + next if data[ app_model_user ][ local_user_id ] user = User.lookup(id: local_user_id) next if !user data = user.assets(data) @@ -45,7 +48,7 @@ returns end %w(created_by_id updated_by_id).each { |local_user_id| next if !self[ local_user_id ] - next if data[ User.to_app_model ][ self[ local_user_id ] ] + next if data[ app_model_user ][ self[ local_user_id ] ] user = User.lookup(id: self[ local_user_id ]) next if !user data = user.assets(data) diff --git a/app/models/sla/assets.rb b/app/models/sla/assets.rb index 64fd2d7ba..bfb9521a4 100644 --- a/app/models/sla/assets.rb +++ b/app/models/sla/assets.rb @@ -23,14 +23,17 @@ returns def assets (data) - if !data[ Sla.to_app_model ] - data[ Sla.to_app_model ] = {} + app_model_sla = Sla.to_app_model + app_model_user = User.to_app_model + + if !data[ app_model_sla ] + data[ app_model_sla ] = {} end - if !data[ User.to_app_model ] - data[ User.to_app_model ] = {} + if !data[ app_model_user ] + data[ app_model_user ] = {} end - if !data[ Sla.to_app_model ][ id ] - data[ Sla.to_app_model ][ id ] = attributes_with_associations + if !data[ app_model_sla ][ id ] + data[ app_model_sla ][ id ] = attributes_with_associations data = assets_of_selector('condition', data) if calendar_id calendar = Calendar.lookup(id: calendar_id) @@ -41,7 +44,7 @@ returns end %w(created_by_id updated_by_id).each { |local_user_id| next if !self[ local_user_id ] - next if data[ User.to_app_model ][ self[ local_user_id ] ] + next if data[ app_model_user ][ self[ local_user_id ] ] user = User.lookup(id: self[ local_user_id ]) next if !user data = user.assets(data) diff --git a/app/models/ticket/article/assets.rb b/app/models/ticket/article/assets.rb index 169de83a1..e545ea4fa 100644 --- a/app/models/ticket/article/assets.rb +++ b/app/models/ticket/article/assets.rb @@ -7,7 +7,7 @@ module Ticket::Article::Assets get all assets / related models for this article article = Ticket::Article.find(123) - result = article.assets( assets_if_exists ) + result = article.assets(assets_if_exists) returns @@ -21,35 +21,39 @@ returns =end - def assets (data) + def assets(data) - if !data[ Ticket.to_app_model ] - data[ Ticket.to_app_model ] = {} + app_model_ticket = Ticket.to_app_model + app_model_article = Ticket::Article.to_app_model + app_model_user = User.to_app_model + + if !data[ app_model_ticket ] + data[ app_model_ticket ] = {} end - if !data[ Ticket.to_app_model ][ ticket_id ] - ticket = Ticket.find( ticket_id ) + if !data[ app_model_ticket ][ ticket_id ] + ticket = Ticket.lookup(id: ticket_id) data = ticket.assets(data) end - if !data[ Ticket::Article.to_app_model ] - data[ Ticket::Article.to_app_model ] = {} + if !data[ app_model_article ] + data[ app_model_article ] = {} end - if !data[ Ticket::Article.to_app_model ][ id ] - data[ Ticket::Article.to_app_model ][ id ] = attributes + if !data[ app_model_article ][ id ] + data[ app_model_article ][ id ] = attributes # add attachment list to article - data[ Ticket::Article.to_app_model ][ id ]['attachments'] = attachments + data[ app_model_article ][ id ]['attachments'] = attachments - if !data[ Ticket::Article.to_app_model ][ id ]['attachments'].empty? - if data[ Ticket::Article.to_app_model ][ id ]['content_type'] =~ %r{text/html}i - if data[ Ticket::Article.to_app_model ][ id ]['body'] =~ /