Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes #3449 - Cannot select multiple tickets in ticket overview with shift+click in Firefox

Browse source
This commit is contained in:
Romit Choudhary 2021-07-28 16:05:34 +02:00 committed by Thorsten Eckel
parent cfa3f27dc4
commit 8a42ec4f7b
4 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/app/controllers/_ui_element/user_permission.coffee
View file

@ -82,7 +82,7 @@ class App.UiElement.user_permission
throttled = _.throttle( (e) ->
input = $(@).find('input')
upcoming_state = !input.prop('checked')
upcoming_state = if $(e.target).is(':checkbox') then input.prop('checked') else !input.prop('checked')
value = input.val()
if value is 'full' and upcoming_state is true

2
app/assets/stylesheets/zammad.scss
View file

@ -1444,9 +1444,9 @@ td .icon-trash {
input[type="checkbox"],
input[type="radio"] {
pointer-events: none;
position: absolute;
opacity: 0;
cursor: pointer;
&:disabled ~ .icon {
opacity: 0.33;

20
test/browser/agent_ticket_overview_level0_test.rb
View file

@ -46,17 +46,17 @@ class AgentTicketOverviewLevel0Test < TestCase
# select both via bulk action
click(
css: %(.content.active table tr td input[value="#{ticket1[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket1[:id]}"]),
fast: true,
)
# scroll to reply - needed for chrome
scroll_to(
position: 'top',
css: %(.content.active table tr td input[value="#{ticket2[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket2[:id]}"]),
)
click(
css: %(.content.active table tr td input[value="#{ticket2[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket2[:id]}"]),
fast: true,
)
@ -263,17 +263,17 @@ class AgentTicketOverviewLevel0Test < TestCase
# select both via bulk action
click(
css: %(.content.active table tr td input[value="#{ticket1[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket1[:id]}"]),
fast: true,
)
# scroll to reply - needed for chrome
scroll_to(
position: 'top',
css: %(.content.active table tr td input[value="#{ticket2[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket2[:id]}"]),
)
click(
css: %(.content.active table tr td input[value="#{ticket2[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket2[:id]}"]),
fast: true,
)
@ -411,17 +411,17 @@ class AgentTicketOverviewLevel0Test < TestCase
# select both via bulk action
click(
css: %(.content.active table tr td input[value="#{ticket1[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket1[:id]}"]),
fast: true,
)
# scroll to reply - needed for chrome
scroll_to(
position: 'top',
css: %(.content.active table tr td input[value="#{ticket2[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket2[:id]}"]),
)
click(
css: %(.content.active table tr td input[value="#{ticket2[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{ticket2[:id]}"]),
fast: true,
)
@ -574,7 +574,7 @@ class AgentTicketOverviewLevel0Test < TestCase
# then select the ticket that we do not have change rights to
scroll_to(
position: 'top',
css: %(.content.active table tr td input[value="#{cannot_change_ticket[:id]}"] + .icon-checkbox.icon-unchecked),
css: %(.content.active table tr td input[value="#{cannot_change_ticket[:id]}"]),
)
check(
css: %(.content.active table tr td input[value="#{cannot_change_ticket[:id]}"]),

2
test/browser/maintenance_session_message_test.rb
View file

@ -147,7 +147,7 @@ class MaintenanceSessionMessageTest < TestCase
)
click(
browser: browser1,
css: '.content.active .js-Message input[name="reload"] + .icon-checkbox.icon-unchecked',
css: '.content.active .js-Message input[name="reload"]',
)
click(
browser: browser1,