From 92f0045bfc8d3d7cc29863135c9c1d3851c28a29 Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Wed, 25 Sep 2013 15:58:25 +0200 Subject: [PATCH 1/2] Improved error handling. --- app/models/channel/email_parser.rb | 2 +- test/unit/email_process_test.rb | 23 +++++++++++++++++++++-- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/app/models/channel/email_parser.rb b/app/models/channel/email_parser.rb index 12208abb6..46ebc897c 100644 --- a/app/models/channel/email_parser.rb +++ b/app/models/channel/email_parser.rb @@ -66,7 +66,7 @@ class Channel::EmailParser # set all headers mail.header.fields.each { |field| - data[field.name.downcase.to_sym] = Encode.conv( 'utf8', field.to_s ) + data[field.name.to_s.downcase.to_sym] = Encode.conv( 'utf8', field.to_s ) } # set extra headers diff --git a/test/unit/email_process_test.rb b/test/unit/email_process_test.rb index 51cbd342d..810a70d62 100644 --- a/test/unit/email_process_test.rb +++ b/test/unit/email_process_test.rb @@ -47,7 +47,7 @@ Some Text', To: customer@example.com Subject: äöü some subject -Some Textäöü".encode("ISO-8859-1"), +Some Textäöü", :success => true, :result => { 0 => { @@ -61,6 +61,25 @@ Some Textäöü".encode("ISO-8859-1"), }, }, }, + { + :data => "From: me@example.com +To: customer@example.com +Subject: äöü some subject + +Some Textäöü".encode("ISO-8859-1"), + :success => true, + :result => { + 0 => { + :ticket_priority => '2 normal', + :title => '', # should be äöü some subject, but can not be parsed from mime tools + }, + 1 => { + :body => 'Some Textäöü', + :ticket_article_sender => 'Customer', + :ticket_article_type => 'email', + }, + }, + }, ] files.each { |file| @@ -90,4 +109,4 @@ Some Textäöü".encode("ISO-8859-1"), end } end -end \ No newline at end of file +end From 8aaf65b3f8d917e93bd2375e798acbf2ff8e70c7 Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Wed, 25 Sep 2013 20:29:49 +0200 Subject: [PATCH 2/2] Fixed namespace. --- ...130529124443_taskbar.rb => 20130529124443_taskbar_create.rb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename db/migrate/{20130529124443_taskbar.rb => 20130529124443_taskbar_create.rb} (95%) diff --git a/db/migrate/20130529124443_taskbar.rb b/db/migrate/20130529124443_taskbar_create.rb similarity index 95% rename from db/migrate/20130529124443_taskbar.rb rename to db/migrate/20130529124443_taskbar_create.rb index bc70f58f8..a407497d0 100644 --- a/db/migrate/20130529124443_taskbar.rb +++ b/db/migrate/20130529124443_taskbar_create.rb @@ -1,4 +1,4 @@ -class Taskbar < ActiveRecord::Migration +class TaskbarCreate < ActiveRecord::Migration def up create_table :taskbars do |t| t.column :user_id, :integer, :null => false