From 955608a427131a3dc4dd22a884824572ffe0f2a8 Mon Sep 17 00:00:00 2001 From: Thorsten Eckel Date: Fri, 14 Dec 2018 18:41:46 +0100 Subject: [PATCH] Marked flanky browser tests for further investigation. --- test/browser/admin_role_test.rb | 1 + test/browser/agent_ticket_online_notification_test.rb | 3 +++ .../agent_ticket_overview_group_by_organization_test.rb | 1 + test/unit/job_test.rb | 1 + 4 files changed, 6 insertions(+) diff --git a/test/browser/admin_role_test.rb b/test/browser/admin_role_test.rb index d670085cc..6bfda37be 100644 --- a/test/browser/admin_role_test.rb +++ b/test/browser/admin_role_test.rb @@ -43,6 +43,7 @@ class AdminRoleTest < TestCase ) logout() + # flanky login( username: email, password: password, diff --git a/test/browser/agent_ticket_online_notification_test.rb b/test/browser/agent_ticket_online_notification_test.rb index 6e7e52ae6..084008ed8 100644 --- a/test/browser/agent_ticket_online_notification_test.rb +++ b/test/browser/agent_ticket_online_notification_test.rb @@ -107,6 +107,8 @@ class AgentTicketOnlineNotificationTest < TestCase value: 'online notification #3', timeout: 6, ) + + # flanky watch_for( browser: browser2, css: '.js-notificationsCounter', @@ -166,6 +168,7 @@ class AgentTicketOnlineNotificationTest < TestCase items = browser2.find_elements(css: '.js-notificationsContainer .js-item') assert_equal(3, items.count) + # flanky items = browser2.find_elements(css: '.js-notificationsContainer .js-item.is-inactive') assert_equal(3, items.count) diff --git a/test/browser/agent_ticket_overview_group_by_organization_test.rb b/test/browser/agent_ticket_overview_group_by_organization_test.rb index 069595f68..b5583fa72 100644 --- a/test/browser/agent_ticket_overview_group_by_organization_test.rb +++ b/test/browser/agent_ticket_overview_group_by_organization_test.rb @@ -64,6 +64,7 @@ class AgentTicketOverviewGroupByOrganizationTest < TestCase elements = instance.find_elements(xpath: '//b[contains(text(),"äöüß & Test Organization")]') elements = elements.select { |x| x.text.present? } assert elements + # flanky assert_equal 'äöüß & Test Organization', elements.first.text end end diff --git a/test/unit/job_test.rb b/test/unit/job_test.rb index 9042c27cb..29873f806 100644 --- a/test/unit/job_test.rb +++ b/test/unit/job_test.rb @@ -185,6 +185,7 @@ class JobTest < ActiveSupport::TestCase end job1.timeplan['minutes'][min.to_s] = true job1.save! + # flanky assert(job1.in_timeplan?(time)) job1.timeplan['hours'][time.hour] = true