From 9aba32eab0453541b60d42eb691746304f873454 Mon Sep 17 00:00:00 2001
From: Felix Niklas <mrflix@gmail.com>
Date: Fri, 18 Sep 2015 17:52:12 +0200
Subject: [PATCH] business hours: add validation

- red border visualisation for debugging
---
 .../app/lib/app_post/business_hours.js.coffee | 67 +++++++++++++++++--
 app/assets/stylesheets/zammad.css.scss        |  7 ++
 2 files changed, 70 insertions(+), 4 deletions(-)

diff --git a/app/assets/javascripts/app/lib/app_post/business_hours.js.coffee b/app/assets/javascripts/app/lib/app_post/business_hours.js.coffee
index 0bbc9bd18..13486b66c 100644
--- a/app/assets/javascripts/app/lib/app_post/business_hours.js.coffee
+++ b/app/assets/javascripts/app/lib/app_post/business_hours.js.coffee
@@ -21,12 +21,12 @@ class App.BusinessHours extends Spine.Controller
       sun: App.i18n.translateInline('Sunday')
 
   render: =>
-    maxTimeframeDay = _.max @hours, (day) -> day.timeframes.length
+    @updateMaxTimeframes()
 
     html = App.view('generic/business_hours')
       days: @days
       hours: @options.hours
-      maxTimeframes: maxTimeframeDay.timeframes.length
+      maxTimeframes: @maxTimeframes
 
     @html html
 
@@ -35,13 +35,21 @@ class App.BusinessHours extends Spine.Controller
         showMeridian: false # meridian = am/pm
       .on 'changeTime.timepicker', @onTimeChange
 
+    @el.toggleClass 'is-invalid', !@validate()
+
+  updateMaxTimeframes: =>
+    maxTimeframeDay = _.max @hours, (day) -> day.timeframes.length
+    @maxTimeframes = maxTimeframeDay.timeframes.length
+
   onTimeChange: (event) =>
     input = @$(event.currentTarget)
     day = input.attr('data-day')
     slot = input.attr('data-slot')
     i = input.attr('data-i')
-    console.log "something changed", event.time
-    @options.hours[day].timeframes[slot][i] = "#{event.time.hours}:#{event.time.minutes}"
+    @options.hours[day].timeframes[slot][i] = event.time.hoursAndMinutes
+    console.log event.time.hoursAndMinutes
+
+    @el.toggleClass 'is-invalid', !@validate()
 
   addTime: (event) =>
     day = @$(event.currentTarget).attr('data-day')
@@ -58,3 +66,54 @@ class App.BusinessHours extends Spine.Controller
     day = checkbox.attr('data-target')
     @options.hours[day].active = checkbox.prop('checked')
     @$("[data-day=#{day}]").toggleClass('is-active', checkbox.prop('checked'))
+
+    @el.toggleClass 'is-invalid', !@validate()
+
+  validate: =>
+    for day, hours of @options.hours
+      break if not hours.active
+
+      # edge case: full day
+      if hours.timeframes[0][0] is '00:00' and hours.timeframes[hours.timeframes.length - 1][1] is '00:00'
+        return true
+
+      # check each timeframe
+      for slot in [0..hours.timeframes.length - 1]
+
+        # check if start time is earlier than end time
+        if not @earlier hours.timeframes[slot][0], hours.timeframes[slot][1]
+          return false
+
+        # check if start time of slot is later than end time of slot before
+        if slot > 0 && not @later hours.timeframes[slot][0], hours.timeframes[slot-1][1]
+          return false
+
+    # all passed
+    return true
+
+  later: (a, b) ->
+    # a later b
+    # input 'hh:mm'
+    [ha, ma] = a.split(':').map (val) -> parseInt val, 10
+    [hb, mb] = b.split(':').map (val) -> parseInt val, 10
+
+    if ha > hb
+      return true
+    if ha is hb
+      if ma > mb
+        return true
+    return false
+
+  earlier: (a, b) ->
+    # a earlier than b
+    # input 'hh:mm'
+
+    [ha, ma] = a.split(':').map (val) -> parseInt val, 10
+    [hb, mb] = b.split(':').map (val) -> parseInt val, 10
+
+    if ha < hb
+      return true
+    if ha is hb
+      if ma < mb
+        return true
+    return false
\ No newline at end of file
diff --git a/app/assets/stylesheets/zammad.css.scss b/app/assets/stylesheets/zammad.css.scss
index 92adfc3ba..a13395bf8 100644
--- a/app/assets/stylesheets/zammad.css.scss
+++ b/app/assets/stylesheets/zammad.css.scss
@@ -5868,6 +5868,13 @@ output {
   background: white;
   table-layout: auto;
   
+  &.is-invalid {
+    border-radius: 3px;
+    box-shadow: 
+      0 0 0 2px white,
+      0 0 0 4px hsl(0,90%,70%);
+  }
+  
   &.settings-list--stretch {
     width: 100%;
   }