From 9beb793e3bca919934f2f487c2af8e61bcbcb76f Mon Sep 17 00:00:00 2001 From: Dominik Klein Date: Thu, 23 Sep 2021 10:21:15 +0200 Subject: [PATCH] Maintenance: Try to improve the stabilzation of the security settings selenium test. --- spec/system/settings/security_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/system/settings/security_spec.rb b/spec/system/settings/security_spec.rb index b5ac89cab..4449ef959 100644 --- a/spec/system/settings/security_spec.rb +++ b/spec/system/settings/security_spec.rb @@ -6,12 +6,11 @@ RSpec.describe 'Manage > Settings > Security', type: :system do describe 'configure third-party applications' do shared_examples 'for third-party applications button in login page' do context 'for third-party applications button in login page', authenticated_as: false do - before { visit 'login' } - context 'when feature is on' do before { Setting.set(app_setting, true) } it 'has authentication button in login page' do + visit 'login' expect(page).to have_button(app_name) end end @@ -20,6 +19,7 @@ RSpec.describe 'Manage > Settings > Security', type: :system do before { Setting.set(app_setting, false) } it 'does not have authentication button in login page' do + visit 'login' expect(page).to have_no_button(app_name) end end