From 9c7ddb7a9dd99e6a51717170646a575c1b10fbcd Mon Sep 17 00:00:00 2001 From: Thorsten Eckel Date: Thu, 22 Jul 2021 16:03:33 +0200 Subject: [PATCH] Maintenance: Removed unneeded authenticated: true meta attribute for system tests which is the default. --- spec/system/admin/knowledge_base/public_menu_spec.rb | 2 +- spec/system/cti_spec.rb | 2 +- spec/system/dashboard_spec.rb | 2 +- spec/system/knowledge_base/locale/answer/edit_spec.rb | 2 +- spec/system/knowledge_base_public/editor_search_spec.rb | 2 +- spec/system/knowledge_base_public/editor_spec.rb | 2 +- spec/system/profile/devices_spec.rb | 2 +- spec/system/search_spec.rb | 2 +- spec/system/system/object_manager_spec.rb | 2 +- spec/system/ticket/history_spec.rb | 2 +- spec/system/ticket/inserting_knowledge_base_answer_spec.rb | 2 +- spec/system/ticket/view_spec.rb | 2 +- spec/system/user/history_spec.rb | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/spec/system/admin/knowledge_base/public_menu_spec.rb b/spec/system/admin/knowledge_base/public_menu_spec.rb index 8ce688ba6..e8829fb31 100644 --- a/spec/system/admin/knowledge_base/public_menu_spec.rb +++ b/spec/system/admin/knowledge_base/public_menu_spec.rb @@ -3,7 +3,7 @@ require 'rails_helper' # https://github.com/zammad/zammad/issues/266 -RSpec.describe 'Admin Panel > Knowledge Base > Public Menu', type: :system, authenticated_as: true do +RSpec.describe 'Admin Panel > Knowledge Base > Public Menu', type: :system do include_context 'basic Knowledge Base' include_context 'Knowledge Base menu items' diff --git a/spec/system/cti_spec.rb b/spec/system/cti_spec.rb index ea2be15b3..7750fef13 100644 --- a/spec/system/cti_spec.rb +++ b/spec/system/cti_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Caller log', type: %i[system request], authenticated_as: true do # rubocop:disable RSpec/DescribeClass +RSpec.describe 'Caller log', type: %i[system request] do # rubocop:disable RSpec/DescribeClass let(:admin) do create(:admin, groups: Group.all) end diff --git a/spec/system/dashboard_spec.rb b/spec/system/dashboard_spec.rb index ba8dc8773..f4ac11344 100644 --- a/spec/system/dashboard_spec.rb +++ b/spec/system/dashboard_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Dashboard', type: :system, authenticated_as: true do +RSpec.describe 'Dashboard', type: :system do it 'shows default widgets' do visit 'dashboard' diff --git a/spec/system/knowledge_base/locale/answer/edit_spec.rb b/spec/system/knowledge_base/locale/answer/edit_spec.rb index 123729588..bc1f333e9 100644 --- a/spec/system/knowledge_base/locale/answer/edit_spec.rb +++ b/spec/system/knowledge_base/locale/answer/edit_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Knowledge Base Locale Answer Edit', type: :system, authenticated_as: true do +RSpec.describe 'Knowledge Base Locale Answer Edit', type: :system do include_context 'basic Knowledge Base' before do diff --git a/spec/system/knowledge_base_public/editor_search_spec.rb b/spec/system/knowledge_base_public/editor_search_spec.rb index 7546a9e09..e7062427d 100644 --- a/spec/system/knowledge_base_public/editor_search_spec.rb +++ b/spec/system/knowledge_base_public/editor_search_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Public Knowledge Base for guest search', type: :system, authenticated_as: true, searchindex: true do +RSpec.describe 'Public Knowledge Base for guest search', type: :system, searchindex: true do include_context 'basic Knowledge Base' before do diff --git a/spec/system/knowledge_base_public/editor_spec.rb b/spec/system/knowledge_base_public/editor_spec.rb index 7122dbd1a..f215e8e2e 100644 --- a/spec/system/knowledge_base_public/editor_spec.rb +++ b/spec/system/knowledge_base_public/editor_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Public Knowledge Base for editor', type: :system, authenticated_as: true do +RSpec.describe 'Public Knowledge Base for editor', type: :system do include_context 'basic Knowledge Base' before do diff --git a/spec/system/profile/devices_spec.rb b/spec/system/profile/devices_spec.rb index 2bd4b7a34..7edf14f32 100644 --- a/spec/system/profile/devices_spec.rb +++ b/spec/system/profile/devices_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Profile > Devices', type: :system, authenticated_as: true do +RSpec.describe 'Profile > Devices', type: :system do subject!(:device) { create(:user_device, user_id: User.find_by(login: 'master@example.com').id) } it 'allows to remove device' do diff --git a/spec/system/search_spec.rb b/spec/system/search_spec.rb index 1e748fd70..9b664f6db 100644 --- a/spec/system/search_spec.rb +++ b/spec/system/search_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Search', type: :system, authenticated: true, searchindex: true do +RSpec.describe 'Search', type: :system, searchindex: true do before do configure_elasticsearch(required: true, rebuild: true) end diff --git a/spec/system/system/object_manager_spec.rb b/spec/system/system/object_manager_spec.rb index 8b9a6a51b..4ccf95c0e 100644 --- a/spec/system/system/object_manager_spec.rb +++ b/spec/system/system/object_manager_spec.rb @@ -3,7 +3,7 @@ require 'rails_helper' # https://github.com/zammad/zammad/issues/266 -RSpec.describe 'Admin Panel > Objects', type: :system, authenticated_as: true do +RSpec.describe 'Admin Panel > Objects', type: :system do before do visit '/#system/object_manager' end diff --git a/spec/system/ticket/history_spec.rb b/spec/system/ticket/history_spec.rb index da2f4015c..b650e3ef0 100644 --- a/spec/system/ticket/history_spec.rb +++ b/spec/system/ticket/history_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Ticket history', type: :system, authenticated_as: true, time_zone: 'Europe/London' do +RSpec.describe 'Ticket history', type: :system, time_zone: 'Europe/London' do let(:group) { Group.find_by(name: 'Users') } let(:ticket) { create(:ticket, group: group) } let!(:session_user) { User.find_by(login: 'master@example.com') } diff --git a/spec/system/ticket/inserting_knowledge_base_answer_spec.rb b/spec/system/ticket/inserting_knowledge_base_answer_spec.rb index 7b0606660..228bba35c 100644 --- a/spec/system/ticket/inserting_knowledge_base_answer_spec.rb +++ b/spec/system/ticket/inserting_knowledge_base_answer_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'inserting Knowledge Base answer', type: :system, authenticated_as: true, searchindex: true do +RSpec.describe 'inserting Knowledge Base answer', type: :system, searchindex: true do include_context 'basic Knowledge Base' let(:field) { find(:richtext) } diff --git a/spec/system/ticket/view_spec.rb b/spec/system/ticket/view_spec.rb index 26e14dc62..2eb65e9f1 100644 --- a/spec/system/ticket/view_spec.rb +++ b/spec/system/ticket/view_spec.rb @@ -89,7 +89,7 @@ RSpec.describe 'Ticket views', type: :system do end end - it 'can use macro to create article', authenticated_as: true do + it 'can use macro to create article' do refresh visit '#ticket/view/all_open' diff --git a/spec/system/user/history_spec.rb b/spec/system/user/history_spec.rb index 00871963e..90e6386eb 100644 --- a/spec/system/user/history_spec.rb +++ b/spec/system/user/history_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -RSpec.describe 'Ticket history', type: :system, authenticated_as: true, time_zone: 'Europe/London' do +RSpec.describe 'Ticket history', type: :system, time_zone: 'Europe/London' do let(:group) { Group.find_by(name: 'Users') } let(:customer) { create(:customer) } let!(:session_user) { User.find_by(login: 'master@example.com') }