Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Maintenance: Fixed typo (refresh_xoaut2 -> refresh_xoauth2).

Browse source
This commit is contained in:
Thorsten Eckel 2020-11-20 11:47:11 +01:00
parent 85573432c0
commit a90423cc88
4 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/models/channel.rb
View file

@ -8,7 +8,7 @@ class Channel < ApplicationModel
store :options store :options
store :preferences store :preferences
after_initialize :refresh_xoaut2! after_initialize :refresh_xoauth2!
after_create :email_address_check after_create :email_address_check
after_update :email_address_check after_update :email_address_check
after_destroy :email_address_check after_destroy :email_address_check
@ -336,7 +336,7 @@ get instance of channel driver
self.class.driver_class(options[:adapter]) self.class.driver_class(options[:adapter])
end end
def refresh_xoaut2! def refresh_xoauth2!
return if options.dig(:auth, :type) != 'XOAUTH2' return if options.dig(:auth, :type) != 'XOAUTH2'
result = ExternalCredential.refresh_token(options[:auth][:provider], options[:auth]) result = ExternalCredential.refresh_token(options[:auth][:provider], options[:auth])

2
spec/factories/channel.rb
View file

@ -1,6 +1,6 @@
FactoryBot.define do FactoryBot.define do
factory :channel do factory :channel do
# ensure the `refresh_xoaut2!` `after_initialize` callback gets executed # ensure the `refresh_xoauth2!` `after_initialize` callback gets executed
# https://stackoverflow.com/questions/5916162/problem-with-factory-girl-association-and-after-initialize#comment51639005_28057070 # https://stackoverflow.com/questions/5916162/problem-with-factory-girl-association-and-after-initialize#comment51639005_28057070
initialize_with { new(attributes) } initialize_with { new(attributes) }

6
spec/lib/external_credential/google_spec.rb
View file

@ -241,7 +241,7 @@ RSpec.describe ExternalCredential::Google do
it 'does not refresh' do it 'does not refresh' do
expect do expect do
channel.refresh_xoaut2! channel.refresh_xoauth2!
end.not_to change { channel.options['auth']['created_at'] } end.not_to change { channel.options['auth']['created_at'] }
end end
end end
@ -265,7 +265,7 @@ RSpec.describe ExternalCredential::Google do
it 'refreshes token' do it 'refreshes token' do
expect do expect do
channel.refresh_xoaut2! channel.refresh_xoauth2!
end.to change { channel.options['auth'] }.to a_hash_including( end.to change { channel.options['auth'] }.to a_hash_including(
'created_at' => Time.zone.now, 'created_at' => Time.zone.now,
'access_token' => refreshed_access_token, 'access_token' => refreshed_access_token,
@ -286,7 +286,7 @@ RSpec.describe ExternalCredential::Google do
shared_examples 'failed attempt' do shared_examples 'failed attempt' do
it 'raises an exception' do it 'raises an exception' do
expect do expect do
channel.refresh_xoaut2! channel.refresh_xoauth2!
end.to raise_error(RuntimeError, exception_message) end.to raise_error(RuntimeError, exception_message)
end end
end end

6
spec/lib/external_credential/microsoft365_spec.rb
View file

@ -202,7 +202,7 @@ RSpec.describe ExternalCredential::Microsoft365 do
it 'does not refresh' do it 'does not refresh' do
expect do expect do
channel.refresh_xoaut2! channel.refresh_xoauth2!
end.not_to change { channel.options['auth']['created_at'] } end.not_to change { channel.options['auth']['created_at'] }
end end
end end
@ -226,7 +226,7 @@ RSpec.describe ExternalCredential::Microsoft365 do
it 'refreshes token' do it 'refreshes token' do
expect do expect do
channel.refresh_xoaut2! channel.refresh_xoauth2!
end.to change { channel.options['auth'] }.to a_hash_including( end.to change { channel.options['auth'] }.to a_hash_including(
'created_at' => Time.zone.now, 'created_at' => Time.zone.now,
'access_token' => refreshed_access_token, 'access_token' => refreshed_access_token,
@ -247,7 +247,7 @@ RSpec.describe ExternalCredential::Microsoft365 do
shared_examples 'failed attempt' do shared_examples 'failed attempt' do
it 'raises an exception' do it 'raises an exception' do
expect do expect do
channel.refresh_xoaut2! channel.refresh_xoauth2!
end.to raise_error(RuntimeError, exception_message) end.to raise_error(RuntimeError, exception_message)
end end
end end