Improved code layout.

This commit is contained in:
Martin Edenhofer 2016-01-24 01:14:14 +01:00
parent 06a32ad071
commit aa4fffad32

View file

@ -3,34 +3,32 @@
class ObjectLookup < ApplicationModel class ObjectLookup < ApplicationModel
@@cache_object = {} # rubocop:disable Style/ClassVars @@cache_object = {} # rubocop:disable Style/ClassVars
def self.by_id( id ) def self.by_id(id)
# use cache # use cache
return @@cache_object[ id ] if @@cache_object[ id ] return @@cache_object[ id ] if @@cache_object[ id ]
# lookup # lookup
lookup = self.lookup( id: id ) lookup = self.lookup(id: id)
return if !lookup return if !lookup
@@cache_object[ id ] = lookup.name @@cache_object[ id ] = lookup.name
lookup.name lookup.name
end end
def self.by_name( name ) def self.by_name(name)
# use cache # use cache
return @@cache_object[ name ] if @@cache_object[ name ] return @@cache_object[ name ] if @@cache_object[ name ]
# lookup # lookup
lookup = self.lookup( name: name ) lookup = self.lookup(name: name)
if lookup if lookup
@@cache_object[ name ] = lookup.id @@cache_object[ name ] = lookup.id
return lookup.id return lookup.id
end end
# create # create
lookup = create( lookup = create(name: name)
name: name
)
@@cache_object[ name ] = lookup.id @@cache_object[ name ] = lookup.id
lookup.id lookup.id
end end